[CDB] Thanks for posts

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
User avatar
Mitch1063
Registered User
Posts: 512
Joined: Wed Jul 28, 2004 2:49 pm
Location: WWW
Contact:

Re: [DEV] Thanks for posts

Post by Mitch1063 » Thu Feb 23, 2017 5:35 pm

Thanks for the Help.
I did have it working with prosilver_se version for phpBB 3.1.8. I just updated SE to 3.2 a few minutes ago
I will have to try and find the author.
thanks
Mitch

rxu
Extensions Development Team
Posts: 2855
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Thu Feb 23, 2017 5:43 pm

For 3.2, you have to update the extension as well from the branch https://github.com/rxu/thanks_for_posts ... elop-3.2.x

User avatar
Leinad4Mind
Translator
Posts: 831
Joined: Sun Jun 01, 2008 11:08 pm
Contact:

Re: [DEV] Thanks for posts

Post by Leinad4Mind » Thu Feb 23, 2017 5:45 pm

What rxu said... PLUS:
You need to update your theme at least to 3.1.10 and then we can't talk to update to 3.2.

So first go here: https://area51.phpbb.com/code-changes/3 ... -prosilver

And apply manually all changes of the prosilver theme on your theme.

After that done then you can take a look at this: https://gist.github.com/Crizz0/6bd13317 ... 99b37f1c2e :twisted:

PS: You can download too prosilver 3.1.10 and prosilver 3.2.0 and then compare them with WinMerge, that way you'll know too all the changes between them, maybe its better for you.

Good luck!
Last edited by Leinad4Mind on Thu Feb 23, 2017 5:48 pm, edited 2 times in total.
Want to access all my portuguese MOD and Extension translations?
Become my Patreon!
phpBB Portugal Translator and Moderator

User avatar
Hippie459MN
Registered User
Posts: 885
Joined: Mon Oct 15, 2007 10:13 pm
Location: Minnesota, USA
Contact:

Re: [DEV] Thanks for posts

Post by Hippie459MN » Thu Feb 23, 2017 5:45 pm

rxu wrote:
Thu Feb 23, 2017 5:43 pm
For 3.2, you have to update the extension as well from the branch https://github.com/rxu/thanks_for_posts ... elop-3.2.x
Does this also work for 3.1.x also still?

rxu
Extensions Development Team
Posts: 2855
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Thu Feb 23, 2017 5:48 pm

develop-3.2.x branch is for phpBB 3.2 only.

User avatar
Mitch1063
Registered User
Posts: 512
Joined: Wed Jul 28, 2004 2:49 pm
Location: WWW
Contact:

Re: [DEV] Thanks for posts

Post by Mitch1063 » Thu Feb 23, 2017 5:57 pm

Thank you RXU I will try to update I checked the developers site for prosilver black and he has not updated it I joined his forum in the mean time when I get approved I will ask him to update.
And in the mean time I will try to do it myself thanks

tHeWiZaRdOfDoS
Registered User
Posts: 13
Joined: Fri Mar 12, 2010 1:54 pm

Re: [DEV] Thanks for posts

Post by tHeWiZaRdOfDoS » Sat Feb 25, 2017 4:09 pm

I have recently updated my forum to 3.2 and installed the mod (downloaded today from github)
I used some ancient version before and got some exceptions when activating the mod but after renaming thanks_from to poster_id and thanks_to to user_id in DB, I could activate it. :ugeek:

But now I have no image on the button in proSilver, i.e. it's barely visible.
And clicking it results in:

Catchable fatal error: Argument 1 passed to phpbb\notification\type\base::__construct() must implement interface phpbb\db\driver\driver_interface, instance of phpbb\user_loader given, called in /<...>/forum/cache/production/container_4335734bbdd20f586549a504dff5f80c.php on line 2036 and defined in /<...>/forum/phpbb/notification/type/base.php on line 87

But obviously the "thanks" was accepted properly.
Any ideas?

rxu
Extensions Development Team
Posts: 2855
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Sat Feb 25, 2017 5:25 pm

tHeWiZaRdOfDoS wrote:
Sat Feb 25, 2017 4:09 pm
downloaded today from github
You had to download from develop-3.2.x branch as the master is for phpBB 3.1.

tHeWiZaRdOfDoS
Registered User
Posts: 13
Joined: Fri Mar 12, 2010 1:54 pm

Re: [DEV] Thanks for posts

Post by tHeWiZaRdOfDoS » Sat Feb 25, 2017 6:42 pm

rxu wrote:
Sat Feb 25, 2017 5:25 pm
tHeWiZaRdOfDoS wrote:
Sat Feb 25, 2017 4:09 pm
downloaded today from github
You had to download from develop-3.2.x branch as the master is for phpBB 3.1.
Damn! My bad - works as intended, thx a lot.

construaprende
Registered User
Posts: 59
Joined: Tue May 18, 2004 7:40 pm
Location: Mexico
Contact:

Re: [DEV] Thanks for posts

Post by construaprende » Wed Mar 01, 2017 6:57 am

Hippie459MN wrote:
Thu Feb 23, 2017 3:32 pm
construaprende wrote:
Thu Feb 23, 2017 3:12 pm
Mitch1063 wrote:
Thu Feb 23, 2017 2:52 pm
rxu wrote:
Thu Feb 23, 2017 2:47 pm
Scanialady wrote:
Sun Feb 19, 2017 12:24 pm
Is this extension abandoned?
Partially. I have no time for active development for now.
Do you have any questions?
Could you help me with my problem above your post of images not being found on other then prosilver.
and they are prosilver based themes
I have the same problem
I have no icons

Using Milk theme from themeforest
While it is a prosilver based style, it might not use parts of or all of prosilver as a parent theme so you might need to go to the ext styles folder, make a new folder that is named the same as your style, and copy all the contents of the prosilver folder into the folder for your styles [name]. Hope you understand. Then, purge your cache.
ok
created the Milk_v2 folder inside the \ext\gfksx\ThanksForPosts\styles\ folder, copy the contents of the \ext\gfksx\ThanksForPosts\styles\prosilver folder into it

If I change my style to prosilver, I don´t have the "thanks" icon either
Only the icon to thank a user is missing
There is only a blank button

Any idea?

Thank you

rxu
Extensions Development Team
Posts: 2855
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Wed Mar 01, 2017 4:39 pm

What phpBB version?

construaprende
Registered User
Posts: 59
Joined: Tue May 18, 2004 7:40 pm
Location: Mexico
Contact:

Re: [DEV] Thanks for posts

Post by construaprende » Wed Mar 01, 2017 4:47 pm

Phpbb 3.2

rxu
Extensions Development Team
Posts: 2855
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [DEV] Thanks for posts

Post by rxu » Thu Mar 02, 2017 4:48 pm

construaprende wrote:
Wed Mar 01, 2017 4:47 pm
Phpbb 3.2
Have you noticed that? viewtopic.php?p=14667166#p14667166

construaprende
Registered User
Posts: 59
Joined: Tue May 18, 2004 7:40 pm
Location: Mexico
Contact:

Re: [DEV] Thanks for posts

Post by construaprende » Sun Mar 05, 2017 9:22 pm

rxu wrote:
Thu Mar 02, 2017 4:48 pm
construaprende wrote:
Wed Mar 01, 2017 4:47 pm
Phpbb 3.2
Have you noticed that? viewtopic.php?p=14667166#p14667166
Hi
Yes
I did a search in this forum first
And downloaded the version for 3.2 from that link

User avatar
ALXGS
Registered User
Posts: 57
Joined: Wed Jan 11, 2017 4:27 pm

Re: [DEV] Thanks for posts

Post by ALXGS » Mon Mar 06, 2017 5:17 pm

I use we_clearblue style at 3.2

When I install the extension, the icons and text are mixed up at upper left corner. Is there a solution for this?

Also, if there is a way to remove the icons, I rather. I want only the text. Can I?

Image

Locked

Return to “Extensions in Development”

Who is online

Users browsing this forum: Galixte de EzCom, Paul, Peter77sx, profKroy and 18 guests