Page 55 of 75

Re: [DEV] Thanks for posts

Posted: Thu Feb 23, 2017 5:35 pm
by Mitch1063
Thanks for the Help.
I did have it working with prosilver_se version for phpBB 3.1.8. I just updated SE to 3.2 a few minutes ago
I will have to try and find the author.
thanks
Mitch

Re: [DEV] Thanks for posts

Posted: Thu Feb 23, 2017 5:43 pm
by rxu
For 3.2, you have to update the extension as well from the branch https://github.com/rxu/thanks_for_posts ... elop-3.2.x

Re: [DEV] Thanks for posts

Posted: Thu Feb 23, 2017 5:45 pm
by Leinad4Mind
What rxu said... PLUS:
You need to update your theme at least to 3.1.10 and then we can't talk to update to 3.2.

So first go here: https://area51.phpbb.com/code-changes/3 ... -prosilver

And apply manually all changes of the prosilver theme on your theme.

After that done then you can take a look at this: https://gist.github.com/Crizz0/6bd13317 ... 99b37f1c2e :twisted:

PS: You can download too prosilver 3.1.10 and prosilver 3.2.0 and then compare them with WinMerge, that way you'll know too all the changes between them, maybe its better for you.

Good luck!

Re: [DEV] Thanks for posts

Posted: Thu Feb 23, 2017 5:45 pm
by Hippie459MN
rxu wrote:
Thu Feb 23, 2017 5:43 pm
For 3.2, you have to update the extension as well from the branch https://github.com/rxu/thanks_for_posts ... elop-3.2.x
Does this also work for 3.1.x also still?

Re: [DEV] Thanks for posts

Posted: Thu Feb 23, 2017 5:48 pm
by rxu
develop-3.2.x branch is for phpBB 3.2 only.

Re: [DEV] Thanks for posts

Posted: Thu Feb 23, 2017 5:57 pm
by Mitch1063
Thank you RXU I will try to update I checked the developers site for prosilver black and he has not updated it I joined his forum in the mean time when I get approved I will ask him to update.
And in the mean time I will try to do it myself thanks

Re: [DEV] Thanks for posts

Posted: Sat Feb 25, 2017 4:09 pm
by tHeWiZaRdOfDoS
I have recently updated my forum to 3.2 and installed the mod (downloaded today from github)
I used some ancient version before and got some exceptions when activating the mod but after renaming thanks_from to poster_id and thanks_to to user_id in DB, I could activate it. :ugeek:

But now I have no image on the button in proSilver, i.e. it's barely visible.
And clicking it results in:

Catchable fatal error: Argument 1 passed to phpbb\notification\type\base::__construct() must implement interface phpbb\db\driver\driver_interface, instance of phpbb\user_loader given, called in /<...>/forum/cache/production/container_4335734bbdd20f586549a504dff5f80c.php on line 2036 and defined in /<...>/forum/phpbb/notification/type/base.php on line 87

But obviously the "thanks" was accepted properly.
Any ideas?

Re: [DEV] Thanks for posts

Posted: Sat Feb 25, 2017 5:25 pm
by rxu
tHeWiZaRdOfDoS wrote:
Sat Feb 25, 2017 4:09 pm
downloaded today from github
You had to download from develop-3.2.x branch as the master is for phpBB 3.1.

Re: [DEV] Thanks for posts

Posted: Sat Feb 25, 2017 6:42 pm
by tHeWiZaRdOfDoS
rxu wrote:
Sat Feb 25, 2017 5:25 pm
tHeWiZaRdOfDoS wrote:
Sat Feb 25, 2017 4:09 pm
downloaded today from github
You had to download from develop-3.2.x branch as the master is for phpBB 3.1.
Damn! My bad - works as intended, thx a lot.

Re: [DEV] Thanks for posts

Posted: Wed Mar 01, 2017 6:57 am
by construaprende
Hippie459MN wrote:
Thu Feb 23, 2017 3:32 pm
construaprende wrote:
Thu Feb 23, 2017 3:12 pm
Mitch1063 wrote:
Thu Feb 23, 2017 2:52 pm
rxu wrote:
Thu Feb 23, 2017 2:47 pm
Scanialady wrote:
Sun Feb 19, 2017 12:24 pm
Is this extension abandoned?
Partially. I have no time for active development for now.
Do you have any questions?
Could you help me with my problem above your post of images not being found on other then prosilver.
and they are prosilver based themes
I have the same problem
I have no icons

Using Milk theme from themeforest
While it is a prosilver based style, it might not use parts of or all of prosilver as a parent theme so you might need to go to the ext styles folder, make a new folder that is named the same as your style, and copy all the contents of the prosilver folder into the folder for your styles [name]. Hope you understand. Then, purge your cache.
ok
created the Milk_v2 folder inside the \ext\gfksx\ThanksForPosts\styles\ folder, copy the contents of the \ext\gfksx\ThanksForPosts\styles\prosilver folder into it

If I change my style to prosilver, I don´t have the "thanks" icon either
Only the icon to thank a user is missing
There is only a blank button

Any idea?

Thank you

Re: [DEV] Thanks for posts

Posted: Wed Mar 01, 2017 4:39 pm
by rxu
What phpBB version?

Re: [DEV] Thanks for posts

Posted: Wed Mar 01, 2017 4:47 pm
by construaprende
Phpbb 3.2

Re: [DEV] Thanks for posts

Posted: Thu Mar 02, 2017 4:48 pm
by rxu
construaprende wrote:
Wed Mar 01, 2017 4:47 pm
Phpbb 3.2
Have you noticed that? viewtopic.php?p=14667166#p14667166

Re: [DEV] Thanks for posts

Posted: Sun Mar 05, 2017 9:22 pm
by construaprende
rxu wrote:
Thu Mar 02, 2017 4:48 pm
construaprende wrote:
Wed Mar 01, 2017 4:47 pm
Phpbb 3.2
Have you noticed that? viewtopic.php?p=14667166#p14667166
Hi
Yes
I did a search in this forum first
And downloaded the version for 3.2 from that link

Re: [DEV] Thanks for posts

Posted: Mon Mar 06, 2017 5:17 pm
by ALXGS
I use we_clearblue style at 3.2

When I install the extension, the icons and text are mixed up at upper left corner. Is there a solution for this?

Also, if there is a way to remove the icons, I rather. I want only the text. Can I?

Image