Page 14 of 18

Re: [RC] RH Topic Tags

Posted: Sun Aug 23, 2015 6:54 pm
by combuster
floxx wrote: I've seen a problem during using this extension. After I wrote the tags, when I send the message, the tags doesn't appears... I must edit the message to write again the tags.
When editing, is the tag already there or do you need to enter it again?

Re: [RC] RH Topic Tags

Posted: Sun Aug 23, 2015 6:58 pm
by combuster
@floxx and @feliciamay , I can reproduce the bug and will have a look at it, you can get status upates here: https://github.com/RobertHeim/phpbb-ext ... /issues/59

Re: [RC] RH Topic Tags

Posted: Sun Aug 23, 2015 7:02 pm
by floxx
combuster wrote:
floxx wrote: I've seen a problem during using this extension. After I wrote the tags, when I send the message, the tags doesn't appears... I must edit the message to write again the tags.
When editing, is the tag already there or do you need to enter it again?
Sorry i'm late.
When i'm editing, i have to enter the tag again, and after it's working. But, if i edit again, i have to enter again the tags.

Thanks for the issue status link on github ;)

Good luck to fix it

Re: [RC] RH Topic Tags

Posted: Sun Aug 23, 2015 7:24 pm
by combuster
I already fixed it, you can use current master version if you want.

Re: [RC] RH Topic Tags

Posted: Tue Aug 25, 2015 8:19 am
by TriKe27
Hello,

how do you think this ext affect search engines? Positively? Or maybe, in worst case, negatively because of keyword-spam?


Thanks in advance

Martin

Re: [RC] RH Topic Tags

Posted: Thu Sep 03, 2015 9:09 am
by piatachki
Author, thank you for cool extension! Exellent!

What you think about change at Russian language pack string

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[\- a-z0-9]{3,30}$/i',
to

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[A-я0-9]{3,30}$/i',
to allow Russian tags by default?

Re: [RC] RH Topic Tags

Posted: Sun Sep 06, 2015 11:53 am
by combuster
piatachki wrote:What you think about change at Russian language pack string

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[\- a-z0-9]{3,30}$/i',
to

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[A-я0-9]{3,30}$/i',
to allow Russian tags by default?
Seems good, we also need to adjust

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_EXP_FOR_USERS_DEFAULT'	=> '-, 0-9, a-z, A-Z, пробелы (будут конвертированы -), мин: 3, макс: 30',
As I am not able to speak russian, someone needs to adjust it. Best would be a pull-request on github for such improvements!

Re: [RC] RH Topic Tags

Posted: Mon Sep 07, 2015 7:18 am
by piatachki

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_EXP_FOR_USERS_DEFAULT'   => 'Допускаются буквы, цифры, дефисы и пробелы (будут конвертированы в дефисы). Мин.: 3 символов, макс.: 30 символов',

Re: [RC] RH Topic Tags

Posted: Wed Sep 09, 2015 11:02 am
by piatachki
Hm, there is some problem

When user create new topic, he is filling tags. After it if user attach file to post then tags disappear, when page save.

1. Fill the subject
2. Fill tags
3. Fill post body
4. Attach file
5. Save page
6. Tags disappear

Does anybody have similar?

Re: [RC] RH Topic Tags

Posted: Thu Sep 10, 2015 9:29 am
by combuster
piatachki wrote:

Code: Select all

	'ACP_RH_TOPICTAGS_REGEX_DEFAULT'				=> '/^[A-я0-9]{3,30}$/i',
Have you actually tested this regex?
piatachki wrote: When user create new topic, he is filling tags. After it if user attach file to post then tags disappear, when page save.
Which version of RH Topic Tags are you using?

Re: [RC] RH Topic Tags

Posted: Thu Sep 10, 2015 9:43 am
by piatachki
combuster wrote:Have you actually tested this regex?
This string works on my forum correctly, but i allow only literal and numeric symbols without "-", spaces etc.

If you wait till tomorrow, i'll test more common regexp with "-" and spaces:

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_DEFAULT'            => '/^[\- A-я0-9]{3,30}$/i',
combuster wrote:Which version of RH Topic Tags are you using?
0.0.14-RC1

Re: [RC] RH Topic Tags

Posted: Thu Sep 10, 2015 10:04 am
by piatachki
Ok. Common regexp tested

Code: Select all

'ACP_RH_TOPICTAGS_REGEX_DEFAULT'            => '/^[\- A-я0-9]{3,30}$/i',
Image

Re: [RC] RH Topic Tags

Posted: Thu Sep 10, 2015 12:22 pm
by combuster
piatachki wrote:
0.0.14-RC1
you should update to 1.0.1 which should fix your bug regarding editing first post.

Re: [RC] RH Topic Tags

Posted: Thu Sep 10, 2015 12:50 pm
by FomenkoAndrey
v.1.0.1
why this extension creates +40 queries on page viewforum (was 33-34, became 74)?

Re: [RC] RH Topic Tags

Posted: Thu Sep 10, 2015 1:35 pm
by combuster
FomenkoAndrey wrote:v.1.0.1
why this extension creates +40 queries on page viewforum (was 33-34, became 74)?
I will optimize db usage in some of the next releases.