Code: Select all
Fatal error: Uncaught exception 'Twig_Error_Loader' with message 'Unable to find template "@robertheim_topictags/../theme/rh_topictags.css" (looked into: ./ext/robertheim/topictags/styles/all/template, ./ext/robertheim/topictags/styles/all/template) in "@robertheim_topictags/event/overall_header_head_append.html" at line 6.' in /home/lankahostingtalk/public_html/vendor/twig/twig/lib/Twig/Loader/Filesystem.php:195 Stack trace: #0 /home/lankahostingtalk/public_html/phpbb/template/twig/loader.php(107): Twig_Loader_Filesystem->findTemplate('@robertheim_top...') #1 /home/lankahostingtalk/public_html/vendor/twig/twig/lib/Twig/Loader/Filesystem.php(138): phpbb\template\twig\loader->findTemplate('@robertheim_top...') #2 /home/lankahostingtalk/public_html/phpbb/template/twig/environment.php(202): Twig_Loader_Filesystem->getCacheKey('@robertheim_top...') #3 /home/lankahostingtalk/public_html/cache/twig/b/b/bb938edfd26eb5e6b0255d226d65f8bd34368921ae89b69330485cde9a946b4d.php(36): phpbb\template\twig\environment->findTemplate('@rober in /home/lankahostingtalk/public_html/vendor/twig/twig/lib/Twig/Loader/Filesystem.php on line 195
Some adjustments are required for 3.2.x that do not work on 3.1.x .3Di wrote:Why did you create 2 branches then?
An extension that works ALSO on 3.2.x does not need to have to have those. Am I missing something?
Yes, this is what the branches are for since I already made it 3.2 compatible (breaking backward compatiblity). But the 3.1.x branch will be developed until 3.2. is released.3Di wrote:Well, once the extensions for RHEA will be submit(ables) to the CDB you should re submit it.
If in the meantime you will find a solution then your ext will be fully backward compatible to ASCRAEUS.
I do neither belief nor do I trust such code. If we have learned one lessen in computer science, then to never change the context of a software component without proper QA processes (e.g., ). But more importantly, if I would start implementing this way, there would come more features that require backward compatiblity and which make the code even more ugly and harder to understand.. which in turn raises issues regarding quality, maintainability and security.3Di wrote:I didn't check your code but a question arises.. did you try to code an if statement where IF the phpBB version is 3.1 do this or ELSE IF the phpBB version is 3.2 do that?
In some cases that's the trick that makes the extension fully BC.