Page 15 of 18

Re: [RC] RH Topic Tags

Posted: Thu Sep 17, 2015 7:04 am
by 365man
How to i seperate the tags while i enter them, I thought a comma will be default. But i get error. Below is the screenshot.

Image

Re: [RC] RH Topic Tags

Posted: Sun Sep 20, 2015 3:48 pm
by Dazbobaby
type the word(s) then press enter.

Loving this, I know it's in beta but I will be using this a LOT! Worth a donation I think.

Re: [RC] RH Topic Tags

Posted: Mon Sep 28, 2015 3:23 pm
by Emil-AC
Sorry, haven't read the whole thread yet ...

I run a support forum and find that usually topic starters don't know tags names, that are precise enough to describe their problem. But more experienced users who answer often do.

So imho it would be nice if users that reply could also add tags to the topic.


Thanx for reading, Emil

Re: [RC] RH Topic Tags

Posted: Mon Oct 26, 2015 4:16 am
by CyberBoy
:P Hello!
After installed, it's displaying below error code in my site. (ACP is working.)
phpbb v 1.3.6

Code: Select all

Fatal error: Uncaught exception 'Twig_Error_Loader' with message 'Unable to find template "@robertheim_topictags/../theme/rh_topictags.css" (looked into: ./ext/robertheim/topictags/styles/all/template, ./ext/robertheim/topictags/styles/all/template) in "@robertheim_topictags/event/overall_header_head_append.html" at line 6.' in /home/lankahostingtalk/public_html/vendor/twig/twig/lib/Twig/Loader/Filesystem.php:195 Stack trace: #0 /home/lankahostingtalk/public_html/phpbb/template/twig/loader.php(107): Twig_Loader_Filesystem->findTemplate('@robertheim_top...') #1 /home/lankahostingtalk/public_html/vendor/twig/twig/lib/Twig/Loader/Filesystem.php(138): phpbb\template\twig\loader->findTemplate('@robertheim_top...') #2 /home/lankahostingtalk/public_html/phpbb/template/twig/environment.php(202): Twig_Loader_Filesystem->getCacheKey('@robertheim_top...') #3 /home/lankahostingtalk/public_html/cache/twig/b/b/bb938edfd26eb5e6b0255d226d65f8bd34368921ae89b69330485cde9a946b4d.php(36): phpbb\template\twig\environment->findTemplate('@rober in /home/lankahostingtalk/public_html/vendor/twig/twig/lib/Twig/Loader/Filesystem.php on line 195
Thank you!

Re: [RC] RH Topic Tags

Posted: Mon Nov 09, 2015 7:08 am
by CtrlSystem
I use version 3.1.6 and cant show in ext in admin menu :( any idea what to do ? ty

Re: [ABD] RH Topic Tags

Posted: Wed Nov 11, 2015 9:58 pm
by Derky
This topic has been marked as [ABD] - Abandoned as the extension author has not been active recently. If the extension author wishes to continue development, please PM anyone on the Extensions Team to request this topic be unlocked.

Notice!
We do not recommend that a user of the phpBB software install this extension, or any other extension that is marked as “abandoned” or “in development”, on a live forum. Doing so may cause your forum to not perform in the manner it should.


Thank you,
The phpBB Extensions Team

Re: [ABD] RH Topic Tags

Posted: Tue Jun 07, 2016 10:01 am
by Paul
Reopened as requested.

Re: [ABD] RH Topic Tags

Posted: Tue Jun 07, 2016 10:33 am
by combuster
Thank you Paul!

A new version has been submitted to the validation team.

Also I confirm that the extension will support 3.2.x:

3.1.x -> Branch 3.1.x : https://github.com/RobertHeim/phpbb-ext ... tree/3.1.x
3.2.x -> Branch master: https://github.com/RobertHeim/phpbb-ext ... ree/master

Re: [RC] RH Topic Tags

Posted: Tue Jun 07, 2016 10:53 am
by 3Di
Why did you create 2 branches then?
An extension that works ALSO on 3.2.x does not need to have to have those. Am I missing something?

Re: [RC] RH Topic Tags

Posted: Tue Jun 07, 2016 11:01 am
by combuster
3Di wrote:Why did you create 2 branches then?
An extension that works ALSO on 3.2.x does not need to have to have those. Am I missing something?
Some adjustments are required for 3.2.x that do not work on 3.1.x [1].

[1] starting from line 5654 (resp. line 285+286) https://gist.github.com/Nicofuma/9e7da20b773efb11176b

Re: [RC] RH Topic Tags

Posted: Tue Jun 07, 2016 11:26 am
by 3Di
Well, once the extensions for RHEA will be submit(ables) to the CDB you should re submit it.
If in the meantime you will find a solution then your ext will be fully backward compatible to ASCRAEUS. :)

Re: [RC] RH Topic Tags

Posted: Tue Jun 07, 2016 12:28 pm
by combuster
3Di wrote:Well, once the extensions for RHEA will be submit(ables) to the CDB you should re submit it.
If in the meantime you will find a solution then your ext will be fully backward compatible to ASCRAEUS. :)
Yes, this is what the branches are for since I already made it 3.2 compatible (breaking backward compatiblity). But the 3.1.x branch will be developed until 3.2. is released.

Re: [RC] RH Topic Tags

Posted: Tue Jun 07, 2016 12:42 pm
by 3Di
I didn't check your code but a question arises.. did you try to code an if statement where IF the phpBB version is 3.1 do this or ELSE IF the phpBB version is 3.2 do that?

In some cases that's the trick that makes the extension fully BC. ;)

Re: [RC] RH Topic Tags

Posted: Tue Jun 07, 2016 12:58 pm
by combuster
3Di wrote:I didn't check your code but a question arises.. did you try to code an if statement where IF the phpBB version is 3.1 do this or ELSE IF the phpBB version is 3.2 do that?

In some cases that's the trick that makes the extension fully BC. ;)
I do neither belief nor do I trust such code. If we have learned one lessen in computer science, then to never change the context of a software component without proper QA processes (e.g., [1]). But more importantly, if I would start implementing this way, there would come more features that require backward compatiblity and which make the code even more ugly and harder to understand.. which in turn raises issues regarding quality, maintainability and security.

Proper code management and CVS on the other side enable tracking changes to keep branches clean and compatible. However, I will drop support for 3.1.x at some point.

[1] https://en.wikipedia.org/wiki/Cluster_( ... ch_failure

Re: [RC] RH Topic Tags

Posted: Tue Jun 07, 2016 1:16 pm
by 3Di
This is the URL you posted above in a clear form

https://en.wikipedia.org/wiki/Cluster_%28spacecraft%29#Launch_failure

Anyway.. I do have to agree with you if the code is already complex to begin with (I didn't check your code, has been already said?) but in some cases (already said?).

Once again it depends on the code.