Page 2 of 6

Re: [RC] ELONW

Posted: Thu Oct 30, 2014 9:18 pm
by szulik
I see nofollow in the code of extension, however when the extension is applied, external links don't have nofollow attribute.

Re: [RC] ELONW

Posted: Thu Oct 30, 2014 10:16 pm
by RMcGirr83

Re: [RC] ELONW

Posted: Fri Oct 31, 2014 6:54 am
by szulik
RMcGirr83 wrote:http://www.rosjapl.info/forum/viewtopic.php?p=360#p360

there is a nofollow in the a tag
Yes there is, but this is 3.0.12 phpBB with Prime links MOD. :)

On 3.1 test forum with ELONW enabled source code of the link looks like:

Code: Select all

<!-- m --><a class="postlink" href="http://webpage.com">link</a>
Opening in new window works without issues, but for google bot such a link means: "follow".

Re: [RC] ELONW

Posted: Fri Oct 31, 2014 9:12 am
by RMcGirr83
Post a link to the test forum please.

Re: [RC] ELONW

Posted: Fri Oct 31, 2014 11:01 am
by szulik
RMcGirr83 wrote:Post a link to the test forum please.
I don't want to have indexed by google a test forum, what's why you need to add "11" to folder name. The folder of test forum is "forum11", not "forum".

http://www.rosjapl.info/forum/viewtopic ... 709#p90461

Re: [RC] ELONW

Posted: Fri Oct 31, 2014 11:20 am
by RMcGirr83
no follow is being added
<a href="http://tvn24bis.pl/informacje,187/polsk ... 73684.html" class="postlink" onclick="window.open(this.href);return false;" rel="nofollow">http://tvn24bis.pl/informacje,187/polsk ... 73684.html</a>
:roll:

Re: [RC] ELONW

Posted: Fri Oct 31, 2014 12:02 pm
by szulik
RMcGirr83 wrote:no follow is being added
<a href="http://tvn24bis.pl/informacje,187/polsk ... 73684.html" class="postlink" onclick="window.open(this.href);return false;" rel="nofollow">http://tvn24bis.pl/informacje,187/polsk ... 73684.html</a>
:roll:

Well, not really. It must depand on browser.

Eg. My nofollow extension in Chrome shows that nofollow works, however if you look at source code there is no nofollow.
I checked it also with http://validator.w3.org with source code show option. The result is without nofollow (see below), so I assume google bot will also use "follow" rule

Code: Select all

<div class="content"><!-- m --><a class="postlink" href="http://tvn24bis.pl/informacje,187/polska-wprowadzila-dwuletnie-wizy-turystyczne-dla-bialorusinow,473684.html">http://tvn24bis.pl/informacje,187/polsk ... 73684.html</a><!-- m --><br /><br />Nareszcie..

Re: [RC] ELONW

Posted: Fri Oct 31, 2014 3:37 pm
by Myllox
Hey

and thanks for your great work.

Question though regarding how forum links, would it be possible to get the feature to work with forum created links?

To be more specific its links that you create with the forum feature not simple "[url]" tags

Cheers
Myllox

Re: [RC] ELONW

Posted: Fri Oct 31, 2014 4:33 pm
by RMcGirr83
Myllox wrote:To be more specific its links that you create with the forum feature not simple "[url]" tags

Cheers
Myllox
Any link no matter how it is posted with have the mod applied.

Re: [RC] ELONW

Posted: Fri Oct 31, 2014 10:46 pm
by Myllox
RMcGirr83 wrote:
Myllox wrote:To be more specific its links that you create with the forum feature not simple "[url]" tags

Cheers
Myllox
Any link no matter how it is posted with have the mod applied.
Hmm .. well if i make a linked forum it opens in target=_self instead of target=_blank.

Could it be anything related to the style that causes that behaviour? Because as i mentioned in my post, normal links inside posts or on custom pages work as intended.

Would you like a link to my site? not sure if its ok to post a link to my site in here

Cheers
//Myllox

Re: [RC] ELONW

Posted: Sat Nov 01, 2014 7:32 am
by RMcGirr83
Just installed it on a clean 3.1 board and the extension does add the window.open into the link
Image

Re: [RC] ELONW

Posted: Sat Nov 01, 2014 10:57 am
by Mark011
RMcGirr83 wrote:Extension has been updated to now include this.
Thanks! :)
szulik wrote:Well, not really. It must depand on browser.

Eg. My nofollow extension in Chrome shows that nofollow works, however if you look at source code there is no nofollow.
I checked it also with http://validator.w3.org with source code show option. The result is without nofollow (see below), so I assume google bot will also use "follow" rule
Same problem. If view only source code link, is correctly with nofollow attribute:

Code: Select all

<a rel="nofollow" onclick="window.open(this.href);return false;" class="postlink" href="http://link">text</a>
If view source code full page, nofollow missing:

Code: Select all

<a class="postlink" href="http://link">text</a>
Question is...sees bots attribute nofollow? :)

Re: [RC] ELONW

Posted: Sat Nov 01, 2014 12:12 pm
by RMcGirr83
Mark011 wrote:Question is...sees bots attribute nofollow? :)
Some bots do and some don't as not all execute javacript which is how the nofollow attribute is inserted.

Re: [RC] ELONW

Posted: Sat Nov 01, 2014 3:53 pm
by Myllox
RMcGirr83 wrote:Just installed it on a clean 3.1 board and the extension does add the window.open into the link
Image
I found the reason, when you enable redirect count for the created link. the links is to viewforum instead of the destination link .. therefore it opens in self, then redirects ..

As soon as i create a link forum without redirect count setting it works as it should.

Cheers
//Myllox

Re: [RC] ELONW

Posted: Sat Nov 01, 2014 9:18 pm
by Swanny
Can you update the thread title so it makes sense to people? ELONW doesn't make me want to click the link other than out of curiosity. It turns out this is something I'd like to have.