[CDB] ELONW aka "External Links Open in New Window"

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by RMcGirr83 » Sun Nov 02, 2014 12:41 pm

Done
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
John connor
Registered User
Posts: 2119
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Name: Aaron
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by John connor » Tue Nov 18, 2014 9:48 am

Nice one thanks!

User avatar
LokoLobo
Registered User
Posts: 27
Joined: Tue Oct 10, 2006 8:15 am
Location: Minnesota, USA
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by LokoLobo » Thu Nov 20, 2014 2:47 pm

:?: Ok call me a nob, but I am lost here.
I downloaded, unzipped and installed 3 of your extensions including "elonw-master", in the directory you specified.

ext>phpbb>rmcgirr83>elenw-master
ext>phpbb>rmcgirr83>phpbb-3.1-ext-adduser-master
ext>phpbb>rmcgirr83>topfive-master

But none of them are showing up in the Manage extension manager.
What am I missing? How do I fix this?

User avatar
Mick
Support Team Member
Support Team Member
Posts: 21153
Joined: Fri Aug 29, 2008 9:49 am
Location: Watching cricket - definitely

Re: [RC] ELONW aka "External Links Open in New Window"

Post by Mick » Thu Nov 20, 2014 3:40 pm

Copy the files from the elonw-master folder to ./ext/rmcgirr83/elonw, I just tried it it works. Presumably it will be similar for the other extensions.
"The more connected we get the more alone we become" - Kyle Broflovski

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by RMcGirr83 » Thu Nov 20, 2014 4:24 pm

https://github.com/RMcGirr83/elonw
Clone (or download and move) the repository into the folder phpBB3/ext/rmcgirr83/elonw
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
LokoLobo
Registered User
Posts: 27
Joined: Tue Oct 10, 2006 8:15 am
Location: Minnesota, USA
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by LokoLobo » Thu Nov 20, 2014 11:00 pm

I downloaded the zip file, but I think the zip file is missing some things. It seems to only have the styles parts but none of the other files I seen in github.

ext>phpbb>rmcgirr83>elonw
styles/all/template/event
.gitattributes
.gitignore
.travis.yml
LICENSE.txt
README.md
composer.json

loaded, but still nothing in the ext manager?

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by RMcGirr83 » Fri Nov 21, 2014 1:58 am

ext>phpbb>rmcgirr83>elonw
it should be
ext>rmcgirr83>elonw
within the root of your forum and all the files that are needed are in the download zip.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
LokoLobo
Registered User
Posts: 27
Joined: Tue Oct 10, 2006 8:15 am
Location: Minnesota, USA
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by LokoLobo » Fri Nov 21, 2014 5:33 am

That was the trick. Thanks for sticking with me.

User avatar
LokoLobo
Registered User
Posts: 27
Joined: Tue Oct 10, 2006 8:15 am
Location: Minnesota, USA
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by LokoLobo » Sun Nov 23, 2014 7:46 pm

After getting this installed I'm noticing that when posting URL's that if you use the BBCode for inserting the url it doesn't show up in the post, but if you don't use the bbcode it works just fine.

I'm not sure what to do now, if I should try and remove the url bbcode or fix it so it works again?
What do you think and if so, how should I go about it or do it?

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by RMcGirr83 » Mon Nov 24, 2014 2:18 am

It works either way.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

Nully
Registered User
Posts: 453
Joined: Thu Jan 29, 2009 10:11 pm
Location: France
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by Nully » Wed Nov 26, 2014 1:24 pm

For information: link in ACP goes to 404 page.
https://github.com/RMcGirr83/php-3.1-ext-elonw

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by RMcGirr83 » Wed Nov 26, 2014 6:36 pm

Thanks, I'll fix that tonight.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
LokoLobo
Registered User
Posts: 27
Joined: Tue Oct 10, 2006 8:15 am
Location: Minnesota, USA
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by LokoLobo » Thu Nov 27, 2014 2:14 pm

RMcGirr83 wrote:It works either way.
No it doesn't work either way. If the [url] bbcode is used the link does not show up in the published post.

I wound up removing the [url] bbcode button on my forum.

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by RMcGirr83 » Thu Nov 27, 2014 2:58 pm

Sorry, yes it does. Provide a link where you state it doesn't.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
HabNurNeFrage
Registered User
Posts: 49
Joined: Sun Nov 09, 2014 10:54 pm

Re: [RC] ELONW aka "External Links Open in New Window"

Post by HabNurNeFrage » Thu Nov 27, 2014 3:48 pm

Hi,

no need to parse url by regex ;)

Code: Select all

$(document).ready(function() {
	$("a[href^=http]").each(function(){
	  if(this.href.indexOf(location.hostname) == -1) {
	  $(this).attr({ onclick : "window.open(this.href);return false;", rel : "nofollow" });
	}
  })
});
Cheers, HaNNF

Locked

Return to “Extensions in Development”