[CDB] ELONW aka "External Links Open in New Window"

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 4017
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by HiFiKabin » Sun Dec 28, 2014 9:47 am

I have finally worked out what Moot's problem is.

If you have a subforum link showing in the parent, clicking the link in that parent does not open in a new tab/window

Image
imgurl

clicking the phpbb text in the screenshot above opens the new link in the same window. If you open the parent

Image
imgurl

clicking the link opens in a new window.

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by RMcGirr83 » Sun Dec 28, 2014 12:05 pm

Can't think of a way to fix that as the script thinks the subforum link is part of the domain (because it is using ./viewtopic.php?f=x). Only way I can think of getting this to work is by using the subforum class within the script to inject the code...but that will open every subforum in a new window/tab whether that subforum is on the same domain or not.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
moot
Registered User
Posts: 100
Joined: Sat Sep 15, 2007 11:57 pm

Re: [RC] ELONW aka "External Links Open in New Window"

Post by moot » Sun Dec 28, 2014 12:08 pm

HiFiKabin wrote:I have finally worked out what Moot's problem is.
Thank you very much for taking the time to clearly explain the issue I am having.
I am still very new to phpBB forums and it's flow/structure...
This has been a very good practical lesson for me.
I now see how I must flowchart the details and be more concise in describing an issue.

I now have a clearer picture of how to layout my board index, whether or not the link issue is resolved.

Thanks again for your patience and taking the extra steps needed to explain the issue...
You can lead a horse to water...but you can't make 'em think.

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 4017
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by HiFiKabin » Sun Dec 28, 2014 12:30 pm

We were all noobs at one time :lol:

I thought that might be the case Rich.

My solution is not to list all the links in the parent (which I don't do anyway)

Holger
Registered User
Posts: 1756
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [RC] ELONW aka "External Links Open in New Window"

Post by Holger » Mon Dec 29, 2014 12:04 pm

Swedish translation

Code: Select all

	'ELONW_CHOICE'			=> 'Öppna externa länkar i ett nytt fönster',

CD130
Registered User
Posts: 76
Joined: Thu Nov 13, 2014 2:09 pm

Re: [RC] ELONW aka "External Links Open in New Window"

Post by CD130 » Sun Jan 04, 2015 9:24 am

Many thanks! The extension works great!!!

Dutch translation (nl)

Code: Select all

	'ELONW_CHOICE'			=> 'Open externe link in nieuw venster',

User avatar
Raul [ThE KuKa]
Style Customisations
Style Customisations
Posts: 6527
Joined: Mon Dec 08, 2003 9:24 pm
Location: Spain
Name: Raul Arroyo
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by Raul [ThE KuKa] » Sun Jan 04, 2015 11:18 am

Thanks Rich!

Spanish translation (es)

Code: Select all

	'ELONW_CHOICE'			=> 'Abrir enlace externo en nueva ventana',
;)
All unsolicited PMs will be ignored.
:warning: Knowledge Base | Documentation | Board rules | phpBB Styles Rules & Policies :warning:


If you like my styles, translations, etc. and want to show some appreciation, then feel free to Donate with Image
:flag_es: phpBB Spain - Online Since 2003 :heart:



tienyen
Registered User
Posts: 11
Joined: Wed Dec 24, 2014 3:24 pm

Re: [RC] ELONW aka "External Links Open in New Window"

Post by tienyen » Sun Jan 04, 2015 1:33 pm

can't install in phpBB 3.1.2

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 4017
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by HiFiKabin » Sun Jan 04, 2015 1:42 pm

It is working correctly in 3 of my 3.1.2 fora.

Have you put the extension in the correct location, enabled it, and checked the settings are correct?

Holger
Registered User
Posts: 1756
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [RC] ELONW aka "External Links Open in New Window"

Post by Holger » Mon Jan 05, 2015 8:16 am

HiFiKabin wrote:Have you put the extension in the correct location, enabled it, ...
(Use the extension "Upload Extension")

tienyen
Registered User
Posts: 11
Joined: Wed Dec 24, 2014 3:24 pm

Re: [RC] ELONW aka "External Links Open in New Window"

Post by tienyen » Mon Jan 05, 2015 9:03 am

phpBB 3.1.2 Working fine !!!
correct: ext/rmcgirr83/elonw
incorrect: ext/rmcgirr83/elonw-master
i've unzip and upload with default folder

User avatar
advocatus
Registered User
Posts: 290
Joined: Tue Aug 12, 2014 11:58 am
Location: Ontario, Canada.
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by advocatus » Mon Jan 05, 2015 12:02 pm

Github automatically adds "-master" to the end of the folder name. You need to remove it for the extension to be recognized.
Hi, I'm advocatus and I own www.forumgames.in.

User avatar
GoBieN
Registered User
Posts: 543
Joined: Fri Mar 05, 2004 5:22 pm
Location: Belgium
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by GoBieN » Sat Jan 10, 2015 11:06 pm

I download master from github, uploaded the extension in /ext/rmcgirr83/elonw, I was able to install the extension in the ACP Customize tab.
It is now enabled, however I see no difference, not with links between URL bbcode or automagically links.
Am I forgetting something?

User avatar
GoBieN
Registered User
Posts: 543
Joined: Fri Mar 05, 2004 5:22 pm
Location: Belgium
Contact:

Re: [RC] ELONW aka "External Links Open in New Window"

Post by GoBieN » Sat Jan 10, 2015 11:08 pm

Okay, I disabled the extension, deleted data and re-enabled. Now it is working.
Maybe this is a bug, no idea, but thanks!

Mattix
Registered User
Posts: 25
Joined: Sat Oct 25, 2014 7:00 pm

Re: [RC] ELONW aka "External Links Open in New Window"

Post by Mattix » Fri Jan 30, 2015 11:50 am

I found an issue: this extension seems to work on the textarea when editing a post which was made in the past (either before installing ELONW or before upgrading to 3.1.2. I can't tell as it happened at the same moment on my forum :)). A link which starts out like this:

Code: Select all

http://en.wikipedia.org/wiki/Tex_Ritter
Ends up looking like this:

Code: Select all

http://en.wikipedia.org/wiki/Tex_Ritter" onclick="window.open(this.href);return false;
works normally.

As said, this only seems to work on already existing links, new ones are not affected.

I also have s9e Mediaembed installed, which could have something to do with this as well, I suppose, as you are both using regexes on urls.
Last edited by Mattix on Fri Jan 30, 2015 12:03 pm, edited 1 time in total.

Locked

Return to “Extensions in Development”