[RC] phpBB Gallery

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Fri May 06, 2016 4:48 pm

Quick tip - do not update to today's build - It's broken as hell! I will fix it soon (watch for the green build badge).
canonknipser wrote:Just a question: Can you check if your ext has a potential vulnerability by the use of imagemagick? -> viewtopic.php?f=64&t=2371166
I have no idea. Really - couldn't find test case, but I presume no - I check the image type both as extension and as mime type ... so I presume it's secure, but I will check when I find working test case.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [RC] phpBB Gallery

Post by Siava » Sat May 07, 2016 7:38 pm

I don't know is it bug or not... Image (jpeg photo) quality with watermark less than without watermark.
I'm using 100% quality for images and 85% for thumbs, GD2, png-watermark.

User avatar
shortmort37
Registered User
Posts: 417
Joined: Sat Aug 26, 2006 8:40 pm

Re: [RC] phpBB Gallery

Post by shortmort37 » Mon May 09, 2016 12:59 am

Satanasov wrote: Add Lightbox/darkbox/whatever JS extension for viewing images
I vote for including mp4's along with images in the gallery - and, using a Lightbox variant like Magnific PopUp http://dimsemenov.com/plugins/magnific-popup/ that will permit you to mix content types.

Dan

scoub29
Registered User
Posts: 9
Joined: Mon Nov 10, 2014 12:24 pm

Re: [RC] phpBB Gallery

Post by scoub29 » Sat May 14, 2016 9:40 am

Hello,

There is a little typing mistake in core/album/manage.php
Line 929

Code: Select all

AND ' . (($action == 'move_up') ? 'ight_id < ' . $album_row['right_id'] . ' ORDER BY right_id DESC' : 'left_id > ' . $album_row['left_id'] . ' ORDER BY left_id ASC');
should be

Code: Select all

AND ' . (($action == 'move_up') ? 'right_id < ' . $album_row['right_id'] . ' ORDER BY right_id DESC' : 'left_id > ' . $album_row['left_id'] . ' ORDER BY left_id ASC');

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Sat May 14, 2016 3:44 pm

scoub29 wrote:Hello,

There is a little typing mistake in core/album/manage.php
Line 929

Code: Select all

AND ' . (($action == 'move_up') ? 'ight_id < ' . $album_row['right_id'] . ' ORDER BY right_id DESC' : 'left_id > ' . $album_row['left_id'] . ' ORDER BY left_id ASC');
should be

Code: Select all

AND ' . (($action == 'move_up') ? 'right_id < ' . $album_row['right_id'] . ' ORDER BY right_id DESC' : 'left_id > ' . $album_row['left_id'] . ' ORDER BY left_id ASC');
Thank you. I lost about 10 hours with this file due a small mistake in the early morning... Someone just posted a PR to fix it.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [RC] phpBB Gallery

Post by Siava » Sat May 14, 2016 6:12 pm

Satanasov, hi! I just download the lastest build.

Recent photos on index page sorted ascending, but I set descending for all photos. How fix it?

Another bug on UCP -> subscription page. Blank page with error

Code: Select all

2016/05/14 21:13:43 [error] 9177#9177: *4110089 FastCGI sent in stderr: "PHP message: PHP Catchable fatal error:  Argument 1 passed to phpbbgallery\core\notification::__construct() must implement interface phpbb\db\driver\driver_interface, none given, called in /.../forum/ext/phpbbgallery/core/ucp/main_module.php on line 931 and defined in /.../forum/ext/phpbbgallery/core/notification.php on line 19" while reading response header from upstream, client: xxx.xxx.xxx.xxx, server: siava.ru, request: "GET /forum/ucp.php?i=-phpbbgallery-core-ucp-main_module&mode=manage_subscriptions HTTP/1.0", upstream: "fastcgi://unix:/var/run/php5-fpm.sock:", host: "siava.ru", referrer: "https://siava.ru/forum/ucp.php?i=-phpbbgallery-core-ucp-settings_module&mode=manage"

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Sat May 14, 2016 7:47 pm

Siava wrote:Satanasov, hi! I just download the lastest build.

Recent photos on index page sorted ascending, but I set descending for all photos. How fix it?

Another bug on UCP -> subscription page. Blank page with error

Code: Select all

2016/05/14 21:13:43 [error] 9177#9177: *4110089 FastCGI sent in stderr: "PHP message: PHP Catchable fatal error:  Argument 1 passed to phpbbgallery\core\notification::__construct() must implement interface phpbb\db\driver\driver_interface, none given, called in /.../forum/ext/phpbbgallery/core/ucp/main_module.php on line 931 and defined in /.../forum/ext/phpbbgallery/core/notification.php on line 19" while reading response header from upstream, client: xxx.xxx.xxx.xxx, server: siava.ru, request: "GET /forum/ucp.php?i=-phpbbgallery-core-ucp-main_module&mode=manage_subscriptions HTTP/1.0", upstream: "fastcgi://unix:/var/run/php5-fpm.sock:", host: "siava.ru", referrer: "https://siava.ru/forum/ucp.php?i=-phpbbgallery-core-ucp-settings_module&mode=manage"
Please wait for the travis to go green - it's fixed.

About the default order - It appears I have hardcoded it ... no idea why and when.

I think I have to redo all my functional tests ...
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [RC] phpBB Gallery

Post by Siava » Sat May 14, 2016 8:41 pm

Satanasov wrote:About the default order - It appears I have hardcoded it ... no idea why and when.

I think I have to redo all my functional tests ...
See https://github.com/satanasov/phpbbgallery/pull/89/files
I try fix it... but I think this is not enough..

Sorry, all was wrong. Delete my pull request.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Sat May 14, 2016 9:49 pm

Siava wrote:
Satanasov wrote:About the default order - It appears I have hardcoded it ... no idea why and when.

I think I have to redo all my functional tests ...
See https://github.com/satanasov/phpbbgallery/pull/89/files
I try fix it... but I think this is not enough..

Sorry, all was wrong. Delete my pull request.
I fixed it. It was issue with tests - they were missing order by and order direction option ...

The order is added lower in line 445 where the main request is done. So no need to add it where you did.

Siava - thanks for all the help.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Sun May 15, 2016 3:17 am

So ... this is the last build for the night.

I think I've fixed all issues returned by Extension database validation team. And ... I'll start 7 day bug hunt before putting this version up for validation again. So ... please test! Actively!
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

sgtevmckay
Registered User
Posts: 200
Joined: Tue Apr 27, 2010 4:32 am
Contact:

Re: [RC] phpBB Gallery

Post by sgtevmckay » Sun May 15, 2016 3:57 am

Thank you again :)

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [RC] phpBB Gallery

Post by Siava » Sun May 15, 2016 9:06 am

Recent photos sort order not fixed... :roll:

/gallery/search/recent/
Images on every page sorted descending, but where are old images.

For example (4 images per page):

/gallery/search/recent/
image-1 04.01.2004 23:10
image-3 04.01.2004 15:36
image-2 04.01.2004 01:07
image-4 04.01.2004 00:43

/gallery/search/recent/2
image-5 09.01.2004 18:17
image-6 08.01.2004 20:11
image-7 05.01.2004 20:00
image-8 04.01.2004 23:10

etc...

User avatar
watisnf.nl
Registered User
Posts: 607
Joined: Sat Mar 13, 2010 12:53 pm
Location: The Netherlands
Name: David
Contact:

Re: [RC] phpBB Gallery

Post by watisnf.nl » Sun May 15, 2016 10:03 am

Well I was playing around a bit, to see if everything works fine. I just noticed something in the Gallery log, it has two logs now because I created two albums. The Action field is empty I would expect a line like "New Album created" it's not really a bug. But you might want to look into that ;)

I can't seem to get the multiple upload to work. Setting and permissions should be okay but I'm still limited to one image. Not sure if it's something I missed or it it's a bug.

Thanks for all your hard work so far, keep up the good work!
Dutch Translator | Looking for, Dutch extensions translations

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Sun May 15, 2016 10:23 am

Siava wrote:Recent photos sort order not fixed... :roll:

/gallery/search/recent/
Images on every page sorted descending, but where are old images.

For example (4 images per page):

/gallery/search/recent/
image-1 04.01.2004 23:10
image-3 04.01.2004 15:36
image-2 04.01.2004 01:07
image-4 04.01.2004 00:43

/gallery/search/recent/2
image-5 09.01.2004 18:17
image-6 08.01.2004 20:11
image-7 05.01.2004 20:00
image-8 04.01.2004 23:10

etc...
Darn it! Well back to the drawing board,as they say in movies. I will have it fixed tonight.
watisnf.nl wrote:Well I was playing around a bit, to see if everything works fine. I just noticed something in the Gallery log, it has two logs now because I created two albums. The Action field is empty I would expect a line like "New Album created" it's not really a bug. But you might want to look into that ;)

I can't seem to get the multiple upload to work. Setting and permissions should be okay but I'm still limited to one image. Not sure if it's something I missed or it it's a bug.

Thanks for all your hard work so far, keep up the good work!
The missing log action is a bug. I'll fix it.
The multiple files issue... I am sure they work.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Max_69
Registered User
Posts: 56
Joined: Thu Jun 05, 2014 9:19 am
Location: Udine-Italy
Contact:

Re: [RC] phpBB Gallery

Post by Max_69 » Sun May 15, 2016 1:22 pm

Hi guys, when open user pannel at the subscription page in the gallery i have a blank page with this message:

Code: Select all

Catchable fatal error: Argument 1 passed to phpbbgallery\core\notification::__construct() must implement interface phpbb\db\driver\driver_interface, none given, called in /data/vhosts/gameinvaders.it/httpdocs/forum/ext/phpbbgallery/core/ucp/main_module.php on line 931 and defined in /data/vhosts/gameinvaders.it/httpdocs/forum/ext/phpbbgallery/core/notification.php on line 19
with the modifications described above, nothing has changed.
How resolve? Thanks

Locked

Return to “Extensions in Development”