[RC] phpBB Gallery

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Suggested Hosts
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Sun May 15, 2016 2:56 pm

Max_69 wrote:Hi guys, when open user pannel at the subscription page in the gallery i have a blank page with this message:

Code: Select all

Catchable fatal error: Argument 1 passed to phpbbgallery\core\notification::__construct() must implement interface phpbb\db\driver\driver_interface, none given, called in /data/vhosts/gameinvaders.it/httpdocs/forum/ext/phpbbgallery/core/ucp/main_module.php on line 931 and defined in /data/vhosts/gameinvaders.it/httpdocs/forum/ext/phpbbgallery/core/notification.php on line 19
with the modifications described above, nothing has changed.
How resolve? Thanks
I will take a look, but this was resolved this morning...
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Max_69
Registered User
Posts: 56
Joined: Thu Jun 05, 2014 9:19 am
Location: Udine-Italy
Contact:

Re: [RC] phpBB Gallery

Post by Max_69 » Sun May 15, 2016 3:05 pm

Satanasov wrote:
Max_69 wrote:Hi guys, when open user pannel at the subscription page in the gallery i have a blank page with this message:

Code: Select all

Catchable fatal error: Argument 1 passed to phpbbgallery\core\notification::__construct() must implement interface phpbb\db\driver\driver_interface, none given, called in /data/vhosts/gameinvaders.it/httpdocs/forum/ext/phpbbgallery/core/ucp/main_module.php on line 931 and defined in /data/vhosts/gameinvaders.it/httpdocs/forum/ext/phpbbgallery/core/notification.php on line 19
with the modifications described above, nothing has changed.
How resolve? Thanks
I will take a look, but this was resolved this morning...
Thanks so much

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Sun May 15, 2016 5:52 pm

Siava wrote:...
watisnf.nl wrote:...
Max_69 wrote:...
Sorry guys, but I was unable to reproduce those errors.

I've made a small change for time sort, if the image number is different order from time ...
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [RC] phpBB Gallery

Post by Siava » Sun May 15, 2016 8:50 pm

Satanasov wrote:if the image number is different order from time ...
image_id or image_time... for me the same. Sort order as this: viewtopic.php?p=14431326#p14431326
But this fixes wrong sort order in recent photos for me.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [RC] phpBB Gallery

Post by Siava » Sun May 15, 2016 9:01 pm

Bug?
/gallery/search/toprated

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/phpbbgallery/core/image/image.php on line 616: Undefined index: album_id

Code: Select all

Parameter "album_id" for route "phpbbgallery_core_album" must match "[^/]++" ("" given) to generate a corresponding URL.

https://github.com/satanasov/phpbbgallery/pull/93/files
Micro fix for search utf-words with capital chars. This bug was in all previous versions.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Sun May 15, 2016 9:28 pm

Siava wrote:
Satanasov wrote:if the image number is different order from time ...
image_id or image_time... for me the same. Sort order as this: viewtopic.php?p=14431326#p14431326
But this fixes wrong sort order in recent photos for me.
Please rebase your the PR. I will allow it even if I can't see why should work or not.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [RC] phpBB Gallery

Post by Siava » Sun May 15, 2016 9:42 pm

Another old small bug:

in viewtopic no personal album icon

Image

In UCP -> private message I see personal album icon in contact info below avatar

Image
Last edited by Siava on Sun May 15, 2016 10:04 pm, edited 2 times in total.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Sun May 15, 2016 10:01 pm

Siava wrote:Another old small bug:

in viewtopic no personal album icon

Image

In UCP -> private message I see personal album icon in contact info below avatar

Image
This is due issues with contact fields. I will have to redo some the whole contact field thing in 1.2.1. It's not that easy (belive me I tried last summer)
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [RC] phpBB Gallery

Post by Siava » Sun May 15, 2016 10:05 pm

Satanasov wrote:This is due issues with contact fields
Ok)

Another one.
I try move photo from one album to another.
After move action I was redirected to site.com/gallery/image/XXX
But it is wrong, because correct path is site.com/forum/gallery/image/XXX

In core/controller/moderate.php
strings 745-746 code:

Code: Select all

		$album_backlink = append_sid('/gallery/album/' . $album_id);
		$image_backlink = append_sid('/gallery/image/' . $image_id);
may be correct backlinks are?

Code: Select all

		$album_backlink = append_sid('./gallery/album/' . $album_id);
		$image_backlink = append_sid('./gallery/image/' . $image_id);
or

Code: Select all

		$album_backlink = append_sid('gallery/album/' . $album_id);
		$image_backlink = append_sid('gallery/image/' . $image_id);
or this modern style)

Code: Select all

		$album_backlink = $this->helper->route('phpbbgallery_core_album', array('album_id' => $image_data['image_album_id']));
		$image_backlink = $this->helper->route('phpbbgallery_core_image', array('image_id' => $image_id));		
Because path began from / is absolute.
If I'm right in this file will need change the same backlinks in other functions...
Last edited by Siava on Sun May 15, 2016 10:14 pm, edited 1 time in total.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Sun May 15, 2016 10:12 pm

Siava wrote:
Satanasov wrote:This is due issues with contact fields
Ok)

Another one.
I try move photo from one album to another.
After move action I was redirected to site.com/gallery/image/XXX
But it is wrong, because correct path is site.com/forum/gallery/image/XXX

In core/controller/moderate.php
strings 745-746 code:

Code: Select all

		$album_backlink = append_sid('/gallery/album/' . $album_id);
		$image_backlink = append_sid('/gallery/image/' . $image_id);
may be correct backlinks are?

Code: Select all

		$album_backlink = append_sid('./gallery/album/' . $album_id);
		$image_backlink = append_sid('./gallery/image/' . $image_id);
or

Code: Select all

		$album_backlink = append_sid('gallery/album/' . $album_id);
		$image_backlink = append_sid('gallery/image/' . $image_id);
Because path began from / is absolute.
If I'm right in this file will need change the same backlinks in other functions...
Just pushed the fix.
Last edited by Satanasov on Sun May 15, 2016 10:19 pm, edited 1 time in total.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

sgtevmckay
Registered User
Posts: 200
Joined: Tue Apr 27, 2010 4:32 am
Contact:

Re: [RC] phpBB Gallery

Post by sgtevmckay » Sun May 15, 2016 10:17 pm

I must not be installing correctly :/

May I ask what the file path structure is supposed to look like?

Thanks in advance

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [RC] phpBB Gallery

Post by Siava » Sun May 15, 2016 10:23 pm

Satanasov wrote:Just pushed the fix.
Great, thank you!
I go sleep :)
sgtevmckay wrote:May I ask what the file path structure is supposed to look like?
ext/phpbbgallery/acpcleanup
ext/phpbbgallery/acpimport
ext/phpbbgallery/core
ext/phpbbgallery/exif

or what you mean?

sgtevmckay
Registered User
Posts: 200
Joined: Tue Apr 27, 2010 4:32 am
Contact:

Re: [RC] phpBB Gallery

Post by sgtevmckay » Sun May 15, 2016 11:36 pm

Okies....Thanks...
LOL...for some reason that I did not understand the time....it would only show one extension...
For some reason ....on my end...not all of the files made it over to server....

Thank you

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [RC] phpBB Gallery

Post by Satanasov » Mon May 16, 2016 3:05 am

OK. I think I've done enough damage for tonight.

Please test and I hope all is OK ... seven days start now.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [RC] phpBB Gallery

Post by Siava » Mon May 16, 2016 1:25 pm

Satanasov wrote:Please test
viewtopic.php?p=14431706#p14431706 - you forgot to look :)

Locked

Return to “Extensions in Development”