[RC] phpBB Gallery

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
User avatar
John connor
Registered User
Posts: 2119
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Name: Aaron
Contact:

Re: [BETA] phpBB Gallery

Post by John connor » Wed Oct 21, 2015 7:00 am

Found the problem. It was the EXT Posting Rest Button. I had to update that EXT. However I have two other issues. When clicking on the Gallery Log in the ACP under Maintenance I get this SQL error:
SQL ERROR [ mysqli ]

[0]

An SQL error occurred while fetching this page. Please contact the Board Administrator if this problem persists.


The log works in the extension though.

Also, I see an MCP in the gallery for all users and when I click the link I get this error:
SQL ERROR [ mysqli ]

[0]

An SQL error occurred while fetching this page. Please contact the Board Administrator if this problem persists.

User avatar
KlausiMaus
Registered User
Posts: 128
Joined: Sat Nov 15, 2014 4:55 pm

Re: [BETA] phpBB Gallery

Post by KlausiMaus » Fri Oct 23, 2015 9:30 pm

Does the Exif add-on work? Where to find the info from the pictures?
Klaus (http://forum.kuhnert.ch/) :: Keep it simple, stupid :!:

User avatar
Fast_Eddie
Registered User
Posts: 204
Joined: Tue Jun 09, 2015 8:32 pm
Name: Ed

Re: [BETA] phpBB Gallery

Post by Fast_Eddie » Sun Oct 25, 2015 7:40 pm

I had a spammer slip thru and he posted some junk in gallery, I deleted the account and gallery album. Now when you click on his name in gallery I get something like:

""/""Invalid album

I went into admin gallery and tried the clean-up gallery option and it finds nothing wrong.
Am I missing something here? Or could this be a bug?

Thanks:)

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Wed Oct 28, 2015 6:32 pm

Fast_Eddie wrote:I had a spammer slip thru and he posted some junk in gallery, I deleted the account and gallery album. Now when you click on his name in gallery I get something like:

""/""Invalid album

I went into admin gallery and tried the clean-up gallery option and it finds nothing wrong.
Am I missing something here? Or could this be a bug?

Thanks:)
I will look into it ... but I don't know when. Sorry too much to do around here ...
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Fast_Eddie
Registered User
Posts: 204
Joined: Tue Jun 09, 2015 8:32 pm
Name: Ed

Re: [BETA] phpBB Gallery

Post by Fast_Eddie » Wed Oct 28, 2015 8:39 pm

will look into it ... but I don't know when. Sorry too much to do around here ...
Thanx man :mrgreen:

User avatar
Joyce&Luna
Registered User
Posts: 263
Joined: Wed Oct 14, 2015 3:46 pm
Location: Germany
Name: Anke
Contact:

Re: [BETA] phpBB Gallery

Post by Joyce&Luna » Fri Oct 30, 2015 10:43 pm

Hello

I'm a bit disappointed, I get no answer here after such a long time. The problem is still there.
You can not moderate the Gallery if you forwards his forum withhttp://www.example.com. Adjusting it to you on http://example.com it works again.

An information which you look at the whole time would have been nice and so I have expected. But my post is simply ignored.
I am really disappointed, unfortunately there is no help on phpbb.de for the Gallery.
Even if you had not found a solution to an info would have been good.

J & L
My contributions are translated from German to English by google. This can lead to misunderstanding.

phpBB Style Design

User avatar
3Di
Former Team Member
Posts: 13791
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [BETA] phpBB Gallery

Post by 3Di » Fri Oct 30, 2015 11:08 pm

Joyce&Luna wrote:Hello

I'm a bit disappointed, I get no answer here after such a long time. The problem is still there.
You can not moderate the Gallery if you forwards his forum withhttp://www.example.com. Adjusting it to you on http://example.com it works again.

An information which you look at the whole time would have been nice and so I have expected. But my post is simply ignored.
I am really disappointed, unfortunately there is no help on phpbb.de for the Gallery.
Even if you had not found a solution to an info would have been good.

J & L
Attention: only able to redirect within the same domain if $disable_cd_check is false (yourdomain.com -> www.yourdomain.com will not work)
speaks books to me.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
👨‍🏫 | Take a tour to | The Studio | 👨‍🏫

User avatar
Joyce&Luna
Registered User
Posts: 263
Joined: Wed Oct 14, 2015 3:46 pm
Location: Germany
Name: Anke
Contact:

Re: [BETA] phpBB Gallery

Post by Joyce&Luna » Sat Oct 31, 2015 12:08 am

Hello

There will be diverted within my domain.
My Site to be called only with http://www.example.com and not additionally with http://example.com Otherwise there is duplicate content.

J & L

My text is translated into English with google.
Those who want to have an explanation in German, I can gladly write via PM.
My contributions are translated from German to English by google. This can lead to misunderstanding.

phpBB Style Design

User avatar
JezUK1
Registered User
Posts: 735
Joined: Wed Jul 27, 2005 11:12 pm
Location: England, Somerset
Contact:

Re: [BETA] phpBB Gallery

Post by JezUK1 » Sun Nov 01, 2015 2:14 pm

Is this still being worked on at all?
Jez

ControlThis.co.uk - Your online model shop

belleejac
Registered User
Posts: 8
Joined: Mon Nov 02, 2015 8:22 pm

Re: [DEV] phpBB Gallery

Post by belleejac » Mon Nov 02, 2015 8:58 pm

shortmort37 wrote:"Album has been updated successfully." Well done!

But, I still can't view images in my Album - I've got those pesky fractured icons:

Image
Hi, i have the same problem on a fresh install forum even if url rewrite is enabled or disabled
Image

Image

Image

even if i use domain.tld/app.php/gallery/image/$some_image_id/source i have the same problem. No image

images are allowed from all sites. Upload is working because i can see files in /files/phpbbgallery/core/source/

someone has had the same problem and how to fix it?

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Tue Nov 03, 2015 9:56 pm

JezUK1 wrote:Is this still being worked on at all?
Yes it is worked. I had to do a lot of other things and had no time to contribute to my extensions. I will be back on fixing bugs as soon as I have some time ... (in that time I learned how to use bootstrap, so I will be redoing part of the theme for the gallery)
belleejac wrote:
shortmort37 wrote:"Album has been updated successfully." Well done!

But, I still can't view images in my Album - I've got those pesky fractured icons:

Image
Hi, i have the same problem on a fresh install forum even if url rewrite is enabled or disabled
Image

Image

Image

even if i use domain.tld/app.php/gallery/image/$some_image_id/source i have the same problem. No image

images are allowed from all sites. Upload is working because i can see files in /files/phpbbgallery/core/source/

someone has had the same problem and how to fix it?

Ok ... I will need to see that in person - please send me URL to your board. I will need to see where the images are pointing to.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [BETA] phpBB Gallery

Post by Siava » Wed Nov 04, 2015 11:08 am

I have a lot of fixes for gallery 1.2.0, but my english is not fine :roll:

1. Move image to another album. Hide a lot of albums where no permissions to move:

/ext/phpbbgallery/core/album/album.php
find

Code: Select all

         if ($list)
         {
            $selected = (is_array($select_id)) ? ((in_array($row['album_id'], $select_id)) ? ' selected="selected"' : '') : (($row['album_id'] == $select_id) ? ' selected="selected"' : '');
            $album_list .= '<option value="' . $row['album_id'] . '"' . (($disabled) ? ' disabled="disabled" class="disabled-option"' : $selected) . '>' . $padding . $row['album_name'] . ' (ID: ' . $row['album_id'] . ')</option>';
         }
replace with

Code: Select all

         if ($list && !$disabled)
         {
            $selected = (is_array($select_id)) ? ((in_array($row['album_id'], $select_id)) ? ' selected="selected"' : '') : (($row['album_id'] == $select_id) ? ' selected="selected"' : '');
            $album_list .= '<option value="' . $row['album_id'] . '"' . (($disabled) ? ' disabled="disabled" class="disabled-option"' : $selected) . '>' . $padding . $row['album_name'] . ' (ID: ' . $row['album_id'] . ')</option>';
         }
2. This fix disables move images to albums where no permissions to move:

/ext/phpbbgallery/core/controller/moderate.php
find

Code: Select all

            if ($action == 'move')
            {
               $category_select = $this->album->get_albumbox(false, 'moving_target', $album_id, 'i_upload', $album_id);
replace with

Code: Select all

            if ($action == 'move')
            {
               $category_select = $this->album->get_albumbox(false, 'moving_target', $album_id, 'm_move', $album_id);
find

Code: Select all

         $category_select = $this->album->get_albumbox(false, 'moving_target', $album_id, 'i_upload', $album_id);
replace with

Code: Select all

         $category_select = $this->album->get_albumbox(false, 'moving_target', $album_id, 'm_move', $album_id);
3. Fix for move up down personal albums in ucp:

/ext/phpbbgallery/core/ucp/main_module.php
missed $phpbb_ext_gallery in

Code: Select all

   function move_album()
   {
      global $cache, $db, $user, $phpbb_ext_gallery, $phpbb_ext_gallery_core_album, $albums_table, $request;
4. Fix when view subscriptions in ucp:

/ext/phpbbgallery/core/ucp/main_module.php
missed $phpbb_ext_gallery_core_album in

Code: Select all

   function manage_subscriptions()
   {
      global $db, $template, $user, $phpbb_container, $phpbb_ext_gallery, $phpbb_ext_gallery_core_album, $phpbb_gallery_notification, $watch_table, $albums_table, $contests_table;
5. Make album images responsible:
/ext/phpbbgallery/core/styles/prosilver/template/gallery/viewimage_body.html
add classes postbody_album and postimage to image block:

Code: Select all

      <div class="postbody_album" id="image">
         <!-- IF UC_IMAGE_ACTION --><dl class="thumbnail"><a href="{UC_IMAGE_ACTION}"><!-- ENDIF --><img src="{UC_IMAGE}" class="postimage" alt="{IMAGE_NAME}" /><!-- IF UC_IMAGE_ACTION --></a></dl><!-- ENDIF -->
         <!-- IF S_IMAGE_REPORTED --><br /><br /><a href="{U_IMAGE_REPORTED}"><span class="error">{L_IMAGE_REPORTED}</span></a><!-- ENDIF -->
         <br /><span class="image-description">{IMAGE_DESC}</span>
      </div>
add to css:

Code: Select all

.postbody_album {
   text-align:center;
}
.postbody_album img.postimage {
   max-width: 100%;
   -webkit-box-sizing: border-box;
   -moz-box-sizing: border-box;
   box-sizing: border-box;
}
6. Make album pics clickable:

/ext/phpbbgallery/core/styles/prosilver/template/gallery/albumlist_polaroid.html

Code: Select all

         <!-- IF albumrow.UC_THUMBNAIL -->
         <a href="{albumrow.U_VIEWALBUM}"><img src="{albumrow.UC_THUMBNAIL}" alt="{albumrow.UC_IMAGE_NAME}" title="{albumrow.UC_IMAGE_NAME}" /></a>
         <!-- ENDIF -->
7. Try to make sort personal gallery albums by decrease (last updated first), but how use images from personal subalbums?..

/ext/phpbbgallery/core/album/display.php

Code: Select all

      if (isset($mode_personal))
      {
         $sql_array['LEFT_JOIN'][] = array(
            'FROM'   => array(USERS_TABLE => 'u'),
            'ON'   => 'u.user_id = a.album_user_id',
         );
         $sql_array['ORDER_BY'] = 'a.album_last_image_id DESC';
      }

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Wed Nov 04, 2015 2:10 pm

Siava wrote:I have a lot of fixes for gallery 1.2.0, but my english is not fine :roll:

1. Move image to another album. Hide a lot of albums where no permissions to move:

/ext/phpbbgallery/core/album/album.php
find

Code: Select all

         if ($list)
         {
            $selected = (is_array($select_id)) ? ((in_array($row['album_id'], $select_id)) ? ' selected="selected"' : '') : (($row['album_id'] == $select_id) ? ' selected="selected"' : '');
            $album_list .= '<option value="' . $row['album_id'] . '"' . (($disabled) ? ' disabled="disabled" class="disabled-option"' : $selected) . '>' . $padding . $row['album_name'] . ' (ID: ' . $row['album_id'] . ')</option>';
         }
replace with

Code: Select all

         if ($list && !$disabled)
         {
            $selected = (is_array($select_id)) ? ((in_array($row['album_id'], $select_id)) ? ' selected="selected"' : '') : (($row['album_id'] == $select_id) ? ' selected="selected"' : '');
            $album_list .= '<option value="' . $row['album_id'] . '"' . (($disabled) ? ' disabled="disabled" class="disabled-option"' : $selected) . '>' . $padding . $row['album_name'] . ' (ID: ' . $row['album_id'] . ')</option>';
         }
2. This fix disables move images to albums where no permissions to move:

/ext/phpbbgallery/core/controller/moderate.php
find

Code: Select all

            if ($action == 'move')
            {
               $category_select = $this->album->get_albumbox(false, 'moving_target', $album_id, 'i_upload', $album_id);
replace with

Code: Select all

            if ($action == 'move')
            {
               $category_select = $this->album->get_albumbox(false, 'moving_target', $album_id, 'm_move', $album_id);
find

Code: Select all

         $category_select = $this->album->get_albumbox(false, 'moving_target', $album_id, 'i_upload', $album_id);
replace with

Code: Select all

         $category_select = $this->album->get_albumbox(false, 'moving_target', $album_id, 'm_move', $album_id);
3. Fix for move up down personal albums in ucp:

/ext/phpbbgallery/core/ucp/main_module.php
missed $phpbb_ext_gallery in

Code: Select all

   function move_album()
   {
      global $cache, $db, $user, $phpbb_ext_gallery, $phpbb_ext_gallery_core_album, $albums_table, $request;
4. Fix when view subscriptions in ucp:

/ext/phpbbgallery/core/ucp/main_module.php
missed $phpbb_ext_gallery_core_album in

Code: Select all

   function manage_subscriptions()
   {
      global $db, $template, $user, $phpbb_container, $phpbb_ext_gallery, $phpbb_ext_gallery_core_album, $phpbb_gallery_notification, $watch_table, $albums_table, $contests_table;
5. Make album images responsible:
/ext/phpbbgallery/core/styles/prosilver/template/gallery/viewimage_body.html
add classes postbody_album and postimage to image block:

Code: Select all

      <div class="postbody_album" id="image">
         <!-- IF UC_IMAGE_ACTION --><dl class="thumbnail"><a href="{UC_IMAGE_ACTION}"><!-- ENDIF --><img src="{UC_IMAGE}" class="postimage" alt="{IMAGE_NAME}" /><!-- IF UC_IMAGE_ACTION --></a></dl><!-- ENDIF -->
         <!-- IF S_IMAGE_REPORTED --><br /><br /><a href="{U_IMAGE_REPORTED}"><span class="error">{L_IMAGE_REPORTED}</span></a><!-- ENDIF -->
         <br /><span class="image-description">{IMAGE_DESC}</span>
      </div>
add to css:

Code: Select all

.postbody_album {
   text-align:center;
}
.postbody_album img.postimage {
   max-width: 100%;
   -webkit-box-sizing: border-box;
   -moz-box-sizing: border-box;
   box-sizing: border-box;
}
6. Make album pics clickable:

/ext/phpbbgallery/core/styles/prosilver/template/gallery/albumlist_polaroid.html

Code: Select all

         <!-- IF albumrow.UC_THUMBNAIL -->
         <a href="{albumrow.U_VIEWALBUM}"><img src="{albumrow.UC_THUMBNAIL}" alt="{albumrow.UC_IMAGE_NAME}" title="{albumrow.UC_IMAGE_NAME}" /></a>
         <!-- ENDIF -->
7. Try to make sort personal gallery albums by decrease (last updated first), but how use images from personal subalbums?..

/ext/phpbbgallery/core/album/display.php

Code: Select all

      if (isset($mode_personal))
      {
         $sql_array['LEFT_JOIN'][] = array(
            'FROM'   => array(USERS_TABLE => 'u'),
            'ON'   => 'u.user_id = a.album_user_id',
         );
         $sql_array['ORDER_BY'] = 'a.album_last_image_id DESC';
      }
Hello Siava.

Thanks for the propositions. I will take a look tomorrow evening and get back to you with the changes. You could always make PR in github, this way your changes will be passed trough automated tests and it will be easy to review them. But - thanks!
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

belleejac
Registered User
Posts: 8
Joined: Mon Nov 02, 2015 8:22 pm

Re: [BETA] phpBB Gallery

Post by belleejac » Wed Nov 04, 2015 5:13 pm

Lucifer4o wrote:
JezUK1 wrote:Is this still being worked on at all?
Yes it is worked. I had to do a lot of other things and had no time to contribute to my extensions. I will be back on fixing bugs as soon as I have some time ... (in that time I learned how to use bootstrap, so I will be redoing part of the theme for the gallery)
belleejac wrote:
shortmort37 wrote:"Album has been updated successfully." Well done!

But, I still can't view images in my Album - I've got those pesky fractured icons:

Image
Hi, i have the same problem on a fresh install forum even if url rewrite is enabled or disabled
Image

Image

Image

even if i use domain.tld/app.php/gallery/image/$some_image_id/source i have the same problem. No image

images are allowed from all sites. Upload is working because i can see files in /files/phpbbgallery/core/source/

someone has had the same problem and how to fix it?

Ok ... I will need to see that in person - please send me URL to your board. I will need to see where the images are pointing to.

thanks but i have to reach 5 messages to pm you

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Wed Nov 04, 2015 5:16 pm

belleejac wrote:
Lucifer4o wrote:
JezUK1 wrote:Is this still being worked on at all?
Yes it is worked. I had to do a lot of other things and had no time to contribute to my extensions. I will be back on fixing bugs as soon as I have some time ... (in that time I learned how to use bootstrap, so I will be redoing part of the theme for the gallery)
belleejac wrote:
shortmort37 wrote:"Album has been updated successfully." Well done!

But, I still can't view images in my Album - I've got those pesky fractured icons:

Image
Hi, i have the same problem on a fresh install forum even if url rewrite is enabled or disabled
Image

Image

Image

even if i use domain.tld/app.php/gallery/image/$some_image_id/source i have the same problem. No image

images are allowed from all sites. Upload is working because i can see files in /files/phpbbgallery/core/source/

someone has had the same problem and how to fix it?
Please try to respond to the PM.


Ok ... I will need to see that in person - please send me URL to your board. I will need to see where the images are pointing to.

thanks but i have to reach 5 messages to pm you
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

Locked

Return to “Extensions in Development”