[RC] phpBB Gallery

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
belleejac
Registered User
Posts: 8
Joined: Mon Nov 02, 2015 8:22 pm

Re: [BETA] phpBB Gallery

Post by belleejac » Wed Nov 04, 2015 5:25 pm

Lucifer4o wrote:
belleejac wrote:
Lucifer4o wrote:
JezUK1 wrote:Is this still being worked on at all?
Yes it is worked. I had to do a lot of other things and had no time to contribute to my extensions. I will be back on fixing bugs as soon as I have some time ... (in that time I learned how to use bootstrap, so I will be redoing part of the theme for the gallery)
belleejac wrote:
shortmort37 wrote:"Album has been updated successfully." Well done!

But, I still can't view images in my Album - I've got those pesky fractured icons:

Image
Hi, i have the same problem on a fresh install forum even if url rewrite is enabled or disabled
Image

Image

Image

even if i use domain.tld/app.php/gallery/image/$some_image_id/source i have the same problem. No image

images are allowed from all sites. Upload is working because i can see files in /files/phpbbgallery/core/source/

someone has had the same problem and how to fix it?
Please try to respond to the PM.


Ok ... I will need to see that in person - please send me URL to your board. I will need to see where the images are pointing to.

thanks but i have to reach 5 messages to pm you
nope! but one more answer it will be ok

belleejac
Registered User
Posts: 8
Joined: Mon Nov 02, 2015 8:22 pm

Re: [BETA] phpBB Gallery

Post by belleejac » Wed Nov 04, 2015 5:26 pm

@lucifero4

i have reactivated the extension

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Fri Nov 06, 2015 2:40 am

Hello Siava.

I did your proposed corrections.

1. is merely cosmetic ... We can have it either way, so I added it ... you are right that this will lower the count of select items.

2. This is wrong. m_move is security option setting if the user has the right to move FROM this album. i_upload is the option that allows to move TO the album.

3 and 4 I did add (thanks for that).

5 is a simple CSS trick, and I did implement it.

6. Will require implementing some more code, this is why I will leave it for 1.2.1 (I need to set config for Album thumbnail).

7. I don't see why will you want to order by last ... Please explain this to me.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Fri Nov 06, 2015 2:54 am

OK guys - again 14 days for the Bug hunt. If you don't see any I will consider it done for the moment and I will try making it for EDB.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [BETA] phpBB Gallery

Post by Siava » Fri Nov 06, 2015 10:06 am

Lucifer4o, thank you for reply!
2. This is wrong. m_move is security option setting if the user has the right to move FROM this album.
I have several public albums with permissions for one group only for see photos, read comments and see albums (read only). But users from this group can move pics from their personal albums to these albums. Change 'i_upload' to 'm_move' fix this. May be it is wrong, but I do not know another way :mrgreen:
7. I don't see why will you want to order by last ... Please explain this to me.
Ok. When I open /gallery/users to view personal albums I always see albums sorted from A to Z.
In old phpbb2 Smartor Album with Full album pack personal albums sorted by newest uploads. I try make such but this

Code: Select all

      if (isset($mode_personal))
      {
         $sql_array['LEFT_JOIN'][] = array(
            'FROM'   => array(USERS_TABLE => 'u'),
            'ON'   => 'u.user_id = a.album_user_id',
         );
         $sql_array['ORDER_BY'] = 'a.album_last_image_id DESC';
      }
ignores newest photos from personal subalbums.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [BETA] phpBB Gallery

Post by Siava » Fri Nov 06, 2015 10:17 am

OK guys - again 14 days for the Bug hunt.
:D

1st:
I'm regular user. Open /gallery. See moderate link in header menu.
After click this link /gallery/moderate
SQL ERROR [ mysqli ]

[0]
and in other albums where I don't have permissions to moderate.

2nd:
Missed pagination in /gallery/moderate/album/XXXX/overview

3nd:
Another lot of fixes for 1.2.0 you may see
http://www.phpbbguru.net/community/post ... ml#p462022
http://www.phpbbguru.net/community/post ... ml#p462034
http://www.phpbbguru.net/community/post ... ml#p462037
http://www.phpbbguru.net/community/post ... ml#p462052

4nd:
phpbb_gallery_log column 'description' needs to change from VARCHAR to TEXT.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Fri Nov 06, 2015 3:12 pm

@Siava you have quite large community over there. Nice to see that you like the extension.

I logged few bug tickets for tonight and should have resolution until the morning.

For ordering last images first you will have to wait for 1.2.1 this need to be implemented with config as well as per letter selector.

This thing about log description is strange as the log uses fixed length strings. The strings should never exceed the VARCHAR limit.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [BETA] phpBB Gallery

Post by Siava » Fri Nov 06, 2015 3:48 pm

There was a case when create a new sub-album. There is original post.

Code: Select all

Data too long for column 'description' at row 1 [1406]

SQL

INSERT INTO XXX_gallery_log (log_time, log_type, log_action, log_user, log_ip, album, image, description) VALUES 

BACKTRACE


FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 855
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/ext/phpbbgallery/core/log.php
LINE: 56
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/ext/phpbbgallery/core/album/manage.php
LINE: 274
CALL: phpbbgallery\core\log->add_log()

FILE: [ROOT]/ext/phpbbgallery/core/acp/albums_module.php
LINE: 159
CALL: phpbbgallery\core\album\manage->update_album_data()

FILE: [ROOT]/includes/functions_module.php
LINE: 674
CALL: phpbbgallery\core\acp\albums_module->main()

FILE: [ROOT]/adm/index.php
LINE: 81
CALL: p_master->load_active()

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Fri Nov 06, 2015 3:55 pm

Siava wrote:There was a case when create a new sub-album. There is original post.

Code: Select all

Data too long for column 'description' at row 1 [1406]

SQL

INSERT INTO XXX_gallery_log (log_time, log_type, log_action, log_user, log_ip, album, image, description) VALUES 

BACKTRACE


FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 855
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/ext/phpbbgallery/core/log.php
LINE: 56
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/ext/phpbbgallery/core/album/manage.php
LINE: 274
CALL: phpbbgallery\core\log->add_log()

FILE: [ROOT]/ext/phpbbgallery/core/acp/albums_module.php
LINE: 159
CALL: phpbbgallery\core\album\manage->update_album_data()

FILE: [ROOT]/includes/functions_module.php
LINE: 674
CALL: phpbbgallery\core\acp\albums_module->main()

FILE: [ROOT]/adm/index.php
LINE: 81
CALL: p_master->load_active()
Ok ... I will have to fix this ... better safe then sorry - I will change the column type.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Sat Nov 07, 2015 2:11 am

Thanks @Siava!

I pushed all the proposed fixes. Almost all of them that is (the CSS and styling ones were not fully pushed). You were right for most of the things, but this is big piece of code and I haven't gone trough the whole code. Thank you for your help.

There are things that I will need to redo design wise for 1.2.1

You could all update to tonight's push. It has some small fixes.

Oh and the bughunt is resetet.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

Thunder_one
Registered User
Posts: 119
Joined: Sat May 09, 2015 11:00 pm

Re: [BETA] phpBB Gallery

Post by Thunder_one » Sun Nov 08, 2015 8:30 am

Hi

Where can I download the version 1.2.1? The package is still 1.2.0

Thank you.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Sun Nov 08, 2015 8:42 pm

Thunder_one wrote:Hi

Where can I download the version 1.2.1? The package is still 1.2.0

Thank you.
1.2.1 will be the next version.
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [BETA] phpBB Gallery

Post by Siava » Sat Nov 14, 2015 7:59 pm

Lucifer4o wrote:Oh and the bughunt is resetet.
Hi, Lucifer4o!

In 'Gallery Configuration' I set 'Upload multiple images' = 3
In 'Permissions' for one public album I set upload permissions for group and in 'Misc' section set 'Number of uploadable images' = 1
but all users of this group can upload 3 images, not 1.

Satanasov
Registered User
Posts: 1180
Joined: Sun Jul 29, 2012 5:48 am
Name: Stanislav Atanasov
Contact:

Re: [BETA] phpBB Gallery

Post by Satanasov » Sun Nov 15, 2015 5:00 am

Siava wrote:
Lucifer4o wrote:Oh and the bughunt is resetet.
Hi, Lucifer4o!

In 'Gallery Configuration' I set 'Upload multiple images' = 3
In 'Permissions' for one public album I set upload permissions for group and in 'Misc' section set 'Number of uploadable images' = 1
but all users of this group can upload 3 images, not 1.
I will need to review this ...

What is the state of the option Can upload unlimited images?
For list of all my extensions go to https://github.com/satanasov
If you want custom functions in some of my products - PM me and we will discuss it.

User avatar
Siava
Registered User
Posts: 134
Joined: Wed Jan 26, 2005 10:07 am
Contact:

Re: [BETA] phpBB Gallery

Post by Siava » Sun Nov 15, 2015 11:32 am

Lucifer4o wrote:What is the state of the option Can upload unlimited images?
set 'Yes'

Locked

Return to “Extensions in Development”