[3.2][BETA] Custom Code

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
martti
Registered User
Posts: 760
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [RC] Custom Code

Post by martti » Sun Sep 13, 2015 2:09 pm

martti wrote:
MarieNatalie wrote:
martti wrote:This extension does not work on the phpBB 3.1.6 version, please disable extension BEFORE update to 3.1.6 version.
Could you please tell us... just disable or and DELETE data?

Thanks in advance
Disable.
Finally, you probably also want to delete. However, if you want to reuse your codes, then copy the files first (from store/customcode)

rrbailey89
Registered User
Posts: 248
Joined: Fri Oct 24, 2014 3:00 pm

Re: [RC] Custom Code

Post by rrbailey89 » Sun Sep 13, 2015 2:11 pm

Im seriously hoping that this extension will be updated to be compatible. There are many of us myself included who were using this and wont understand how to get it working again on our own without a barney style guide.

User avatar
Solidjeuh
Registered User
Posts: 522
Joined: Wed Oct 06, 2010 11:20 pm
Location: Aalst / Belgium
Name: Andy Dm
Contact:

Re: [RC] Custom Code

Post by Solidjeuh » Sun Sep 13, 2015 2:12 pm

martti wrote:
Solidjeuh wrote:I noticed in phpbb update that auto update still is merging files
So would it not be easyer to just edit the code files like before?
Or am I mistaking?
It's always better to have a clean separation between the core and anything else, imho.
That's true. But for small things it should not be a problem..
I now use this: viewtopic.php?f=456&t=2275361&start=555#p14199116
And seems to work just fine ;)
I don't suffer from insanity. I enjoy every minute of it.

MarieNatalie
Registered User
Posts: 46
Joined: Tue May 05, 2015 1:19 pm
Location: Athens Greece
Name: Maria

Re: [RC] Custom Code

Post by MarieNatalie » Sun Sep 13, 2015 2:44 pm

martti wrote:
martti wrote:
MarieNatalie wrote:
martti wrote:This extension does not work on the phpBB 3.1.6 version, please disable extension BEFORE update to 3.1.6 version.
Could you please tell us... just disable or and DELETE data?

Thanks in advance
Disable.
Finally, you probably also want to delete. However, if you want to reuse your codes, then copy the files first (from store/customcode)
I have followed all of your instructions and your alternative solution
All are working perfect in 3.1.6 8-)

Image

User avatar
KillBill.
Registered User
Posts: 600
Joined: Tue Jun 02, 2009 4:07 pm
Contact:

Re: [RC] Custom Code

Post by KillBill. » Sun Sep 13, 2015 3:21 pm

david63 wrote:
KillBill. wrote:Idea change ext code:

1. you create new folder ext/marttiphpbb/customcode/styles/all/template/customcode
2. add info this folder change chmod 777
3. you change event/ all html include path
That idea, whilst good, would not get past validation.

It is not allowed to add/delete/modify files within an extension. The way that it is handled at the moment is, as I understand it, the correct way. The issue is to resolve the Twig change (which may be a bug)
hmmmm This escaped my attention. :roll:

Alternative:
Then could be given new option to download and manually upload files.

User avatar
John connor
Registered User
Posts: 2293
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Name: Aaron
Contact:

Re: [RC] Custom Code

Post by John connor » Wed Sep 16, 2015 5:53 am

Well this suxx. I updated my local install in Xampp to make sure 3.1.6 worked before I went live and I'm sure glad I did because I had a blank screen and I seen that I needed to disable this ext's style to get into the ACP.

So with that I won't be updating my live site until this extension works with 3.1.6. I need this ext since i have custom code that plays audio and code in the footer!

Guess I'll check out the other version latter until then just on the localhost for the time being. viewtopic.php?f=456&t=2275361&start=555#p14199116

User avatar
martti
Registered User
Posts: 760
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [RC] Custom Code

Post by martti » Wed Sep 16, 2015 5:59 am

John connor wrote:Well this suxx. I updated my local install in Xampp to make sure 3.1.6 worked before I went live and I'm sure glad I did because I had a blank screen and I seen that I needed to disable this ext's style to get into the ACP.

So with that I won't be updating my live site until this extension works with 3.1.6. I need this ext since i have custom code that plays audio and code in the footer!
It won't be possible to get this extension to work with 3.1.6 due to path limitation of the template engine. Please see here for a workaround.

User avatar
John connor
Registered User
Posts: 2293
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Name: Aaron
Contact:

Re: [RC] Custom Code

Post by John connor » Wed Sep 16, 2015 6:01 am

Will this path limitation be the same for future phpBB releases? Will you redesign this ext to work with this? Or are we stuck with the workaround?

User avatar
martti
Registered User
Posts: 760
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [RC] Custom Code

Post by martti » Wed Sep 16, 2015 6:06 am

John connor wrote:Will this path limitation be the same for future phpBB releases? Will you redesign this ext to work with this? Or are we stuck with the workaround?
I can't predict the course of phpBB. If it will be decided that extensions can add extra paths to the template engine then it will be possible to adapt this extension, otherwise not.

User avatar
martti
Registered User
Posts: 760
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [RC] Custom Code

Post by martti » Wed Sep 16, 2015 6:06 am

John connor wrote:Will this path limitation be the same for future phpBB releases? Will you redesign this ext to work with this? Or are we stuck with the workaround?
I can't predict the course of phpBB. If it will be decided that extensions can add extra paths to the template engine then it will be possible to adapt this extension, otherwise not.

User avatar
AmigoJack
Registered User
Posts: 5638
Joined: Tue Jun 15, 2010 11:33 am
Location: グリーン ヒル ゾーン
Contact:

Re: [RC] Custom Code

Post by AmigoJack » Wed Sep 16, 2015 6:58 am

Raul [ThE KuKa] wrote:not works on 3.1.6 version
Why does it fail?
The worst thing about censorship is ███████████
Affin wrote:
Tue Nov 20, 2018 9:51 am
The problem is probably not my English but you do not want to understand correctly.
...
We will not come anybody anyway, nevertheless, it's best to shit this.

User avatar
John connor
Registered User
Posts: 2293
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Name: Aaron
Contact:

Re: [RC] Custom Code

Post by John connor » Wed Sep 16, 2015 6:59 am

Inserttempaltecode seems to work. Thanks!

User avatar
martti
Registered User
Posts: 760
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [RC] Custom Code

Post by martti » Wed Sep 16, 2015 7:01 am

AmigoJack wrote:
Raul [ThE KuKa] wrote:not works on 3.1.6 version
Why does it fail?
See posts above yours.

User avatar
AmigoJack
Registered User
Posts: 5638
Joined: Tue Jun 15, 2010 11:33 am
Location: グリーン ヒル ゾーン
Contact:

Re: [RC] Custom Code

Post by AmigoJack » Wed Sep 16, 2015 7:19 am

That still doesn't precisely tell me why it worked on previous phpBB releases. Is it an issue to 3.1.6, or is it an issue with Twig?
The worst thing about censorship is ███████████
Affin wrote:
Tue Nov 20, 2018 9:51 am
The problem is probably not my English but you do not want to understand correctly.
...
We will not come anybody anyway, nevertheless, it's best to shit this.

User avatar
martti
Registered User
Posts: 760
Joined: Thu Jul 31, 2014 8:23 am
Location: Belgium

Re: [RC] Custom Code

Post by martti » Wed Sep 16, 2015 7:43 am

AmigoJack wrote:That still doesn't precisely tell me why it worked on previous phpBB releases. Is it an issue to 3.1.6, or is it an issue with Twig?
I don't know precisely if phpBB changed a configuration for Twig or that Twig got stricter itself. There was an update to a newer version of Twig. In a way it's better security to have the path restricted. But there's is no option for extensions to add template paths for I can see.

Post Reply

Return to “Extensions in Development”