[RC] Social Media Buttons with privacy

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
leschek
Registered User
Posts: 789
Joined: Tue Jul 18, 2006 12:49 pm
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by leschek » Mon Jan 05, 2015 1:33 am

Thank you for this extension.

When I click on topic name to open it I get this message during loading a page (when a topic is loaded the message disappear) :

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/tas2580/socialbuttons/event/listener.php on line 162: Undefined variable: running
[phpBB Debug] PHP Warning: in file [ROOT]/ext/tas2580/socialbuttons/event/listener.php on line 162: curl_multi_exec() has been disabled for security reasons
[phpBB Debug] PHP Notice: in file [ROOT]/ext/tas2580/socialbuttons/event/listener.php on line 164: Undefined variable: running
[phpBB Debug] PHP Warning: in file [ROOT]/ext/tas2580/socialbuttons/event/listener.php on line 171: curl_multi_remove_handle() expects parameter 2 to be resource, null given
[phpBB Debug] PHP Warning: in file [ROOT]/ext/tas2580/socialbuttons/event/listener.php on line 171: curl_multi_remove_handle() expects parameter 2 to be resource, null given
[phpBB Debug] PHP Warning: in file [ROOT]/ext/tas2580/socialbuttons/event/listener.php on line 171: curl_multi_remove_handle() expects parameter 2 to be resource, null given
[phpBB Debug] PHP Warning: in file [ROOT]/ext/tas2580/socialbuttons/event/listener.php on line 171: curl_multi_remove_handle() expects parameter 2 to be resource, null given
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 5129: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3839)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 5129: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3839)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 5129: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3839)

User avatar
tas2580
Registered User
Posts: 295
Joined: Wed May 30, 2007 1:56 am
Location: Stuttgart, Germany
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by tas2580 » Mon Jan 05, 2015 1:37 am

curl_multi_exec() has been disabled for security reasons
Here you have the problem.

You can try to replace in .../event/listener.php

Code: Select all

if(function_exists('curl_multi_init'))
with

Code: Select all

if(function_exists('curl_multi_exec'))
Please let me know if this works.

leschek
Registered User
Posts: 789
Joined: Tue Jul 18, 2006 12:49 pm
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by leschek » Mon Jan 05, 2015 1:43 am

Wow. That was fast.
Almost forgot - it fixed the problem.
Thank you

User avatar
tas2580
Registered User
Posts: 295
Joined: Wed May 30, 2007 1:56 am
Location: Stuttgart, Germany
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by tas2580 » Mon Jan 05, 2015 1:45 am

OK thanks, I will change it in next version.

User avatar
John connor
Registered User
Posts: 2259
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Name: Aaron
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by John connor » Mon Jan 05, 2015 12:23 pm

tas2580 wrote:This is because the caching, purge the cache or wait some time an the counter should go up.

I believe the cache was purged. Just in case, what should the file permission be for the cache folder? It is currently. 755, but all the files in the cache folder are 644.

Edit- It works now.

mikef35
Registered User
Posts: 117
Joined: Wed Jun 15, 2011 5:43 pm
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by mikef35 » Tue Jan 06, 2015 12:34 am

I tested this and everything worked as should except when viewing from Iphone. When viewing from Iphone the whole thing is out of alignment.

User avatar
tas2580
Registered User
Posts: 295
Joined: Wed May 30, 2007 1:56 am
Location: Stuttgart, Germany
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by tas2580 » Tue Jan 06, 2015 4:55 am

Do you mean the buttons at the top? There I have the problem that phpBB has no good event for this position and I have tricked there with CSS. I hope in phpBB 3.1.3 there will be a better position. But before the next update I will check it on my phone, maybe I can fix it.

mikef35
Registered User
Posts: 117
Joined: Wed Jun 15, 2011 5:43 pm
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by mikef35 » Tue Jan 06, 2015 6:16 am

tas2580 wrote:Do you mean the buttons at the top? There I have the problem that phpBB has no good event for this position and I have tricked there with CSS. I hope in phpBB 3.1.3 there will be a better position. But before the next update I will check it on my phone, maybe I can fix it.

What it did was push all the buttons off the side of the forum into the background.

User avatar
KhurramMunawar
Registered User
Posts: 534
Joined: Tue Mar 25, 2014 2:20 am
Location: Islamabad, Pakistan
Name: Khurram Munawar
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by KhurramMunawar » Tue Jan 06, 2015 3:14 pm

tas well done. great work mate.

just a little bug i have been noticing since the first release.

When we select "At the Top only" option in ACP, we can still see the "Social Media" text and a line in the bottom.

Have a look at this issue please.
My forum:
DearHelper.org
Get Free Traffic To Your Website
Trafficonic.com - Free Traffic To Your Website

User avatar
KhurramMunawar
Registered User
Posts: 534
Joined: Tue Mar 25, 2014 2:20 am
Location: Islamabad, Pakistan
Name: Khurram Munawar
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by KhurramMunawar » Tue Jan 06, 2015 4:11 pm

just noticed that latest release is submitting wrong urls to Facebook.
My forum:
DearHelper.org
Get Free Traffic To Your Website
Trafficonic.com - Free Traffic To Your Website

User avatar
tas2580
Registered User
Posts: 295
Joined: Wed May 30, 2007 1:56 am
Location: Stuttgart, Germany
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by tas2580 » Tue Jan 06, 2015 7:27 pm

What do you meen with wrong URL? Do you use a SEO Mod?

User avatar
KhurramMunawar
Registered User
Posts: 534
Joined: Tue Mar 25, 2014 2:20 am
Location: Islamabad, Pakistan
Name: Khurram Munawar
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by KhurramMunawar » Wed Jan 07, 2015 6:23 am

yes i m using phpbb SEO for 3.1.2
My forum:
DearHelper.org
Get Free Traffic To Your Website
Trafficonic.com - Free Traffic To Your Website

User avatar
tas2580
Registered User
Posts: 295
Joined: Wed May 30, 2007 1:56 am
Location: Stuttgart, Germany
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by tas2580 » Thu Jan 08, 2015 3:53 am

OK that's the problem. I have used the canonical URL like successes in p13859001 this will work for SEO Mods, but without a SEO Mod the canonical URL contains & so that you share wrong URLs. So I have changed it back to my own URL output.

First I thought, OK make a switch and a option in ACP where you can say that you use a SEO Mod and then I can use the canonical URL or my own output. But the problem is that if you use the canonical URL you have the right URL to share but not for query the social platforms. So you will share "topictitle-t123.html" and query for "viewtopic.php?t=123" and you will get 0 shares because shares go to the SEO URL.

Normally its no problem to share the original URL because of the canonical URL search engines will cont all links to the SEO URL. But this is not relay beautiful so I try to find a way to get the SEO URL in my script so that I can make querys for this URL.

User avatar
tas2580
Registered User
Posts: 295
Joined: Wed May 30, 2007 1:56 am
Location: Stuttgart, Germany
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by tas2580 » Fri Jan 09, 2015 3:48 am

Next small update. I hope it will work now with SEO Urls.

SüKûT
Registered User
Posts: 48
Joined: Fri Mar 15, 2013 11:50 am
Location: Türkiye
Contact:

Re: [BETA] Social Media Buttons with privacy

Post by SüKûT » Fri Jan 09, 2015 1:04 pm

tas2580 wrote:Next small update. I hope it will work now with SEO Urls.
oo :) nice update :) It works perfectly now. Thanks @tas2580

but there is a tiny problem.
Examples link:

Code: Select all

http://www.sukutforum.com/son-umut-the-water-diviner-hd-official-fragman-trailer-t14139.html
share facebook(and others):

Code: Select all

https://www.facebook.com/sharer/sharer.php?u=http%3A%2F%2Fwww.sukutforum.com%2F[b]viewtopic.php[/b]%2Fson-umut-the-water-diviner-hd-official-fragman-trailer-t14139.html%3Fforum_uri%3Dson-umut-the-water-diviner-hd-official-fragman-trailer%26start%3D%26t%3D14139
If we use conical URLs in code.
Find:

Code: Select all

<!-- IF S_FACEBOOK -->
	<a href="#" onclick="return open_socialmedia('https://www.facebook.com/sharer/sharer.php?u={U_TOPICLINK}');" title="{L_SHARE_FACEBOOK}" class="socialmedia1 {SOCIAL_MEDIA_CLASS}">&nbsp;</a><!-- IF S_SHOWSHARES --><span class="social_count">{SHARES_FACEBOOK}</span><!-- ENDIF -->
	<!-- ENDIF -->
and Change:

Code: Select all

<!-- IF S_FACEBOOK -->
	<a href="#" onclick="return open_socialmedia('https://www.facebook.com/sharer/sharer.php?u={U_CANONICAL}');" title="{L_SHARE_FACEBOOK}" class="socialmedia1 {SOCIAL_MEDIA_CLASS}">&nbsp;</a><!-- IF S_SHOWSHARES --><span class="social_count">{SHARES_FACEBOOK}</span><!-- ENDIF -->
	<!-- ENDIF -->
share facebook(and others):

Code: Select all

https://www.facebook.com/sharer/sharer.php?u=http://www.sukutforum.com/son-umut-the-water-diviner-hd-official-fragman-trailer-t14139.html
and Turkish language file updates: common.php

Code: Select all

<?php
/**
*
* @package phpBB Extension - tas2580 Social Media Buttons
* @copyright (c) 2014 tas2580 (https://tas2580.net)
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/

if (!defined('IN_PHPBB'))
{
    exit;
}

if (empty($lang) || !is_array($lang))
{
    $lang = array();
}

$lang = array_merge($lang, array(
    'SOCIAL_BUTTONS'			=> 'Sosyal Medya'da Paylaş',
	'SHARE_FACEBOOK'			=> 'Facebook'ta Paylaş',
	'SHARE_TWITTER'				=> 'Twitter'da Paylaş',
	'SHARE_GOOGLEPLUS'			=> 'Google+'da Paylaş',
	'SHARE_LINKEDIN'			=> 'Linkedin'de Paylaş',
	'ACP_SETTINGS'				=> 'Ayarlar',
	'ACP_POSITION'				=> 'Pozisyon',
	'ACP_POSITION_EXPLAIN'		=> 'Butonların yerini belirleyiniz.',
	'ACP_SUBMIT'				=> 'Güncelleme değişiklikleri',
	'ACP_POSITION_ALL'			=> 'Hem üstte hem altta',
	'ACP_POSITION_TOP'			=> 'Üstte',
	'ACP_POSITION_BOTTOM'		=> 'Altta',
	'ACP_CACHETIME'				=> 'Önbellek aralığı',
	'ACP_CACHETIME_EXPLAIN'		=> 'Önbellek temizliği hangi zaman aralığında olsun?',
	'ACP_MULTIPLICATOR_SECONDS'	=> 'Saniye',
	'ACP_MULTIPLICATOR_MINUTES'	=> 'Dakika',
	'ACP_MULTIPLICATOR_HOURS'	=> 'Saat',
	'ACP_SET_PLATFORMS'			=> 'Aktif Et',
	'ACP_FACEBOOK'				=> 'Facebook',
	'ACP_TWITTER'				=> 'Twitter',
	'ACP_GOOGLE'				=> 'Google Plus',
	'ACP_LINKEDIN'				=> 'Linkedin',
	'ACP_SAVED'					=> 'Sosyal medya buton ayarları güncellendi.',
	'ACP_STYLE'					=> 'Alternatif Buton',
	'ACP_STYLE_EXPLAIN'			=> 'Alternatif butonlardan birini seçebilirsiniz',
	'CACHE_PATH_NOT_WRITEABLE'	=> 'Önbellek yolu "%s" yazılabilir değil!',
	'ACP_CACHE_PURGE_SUCCESS'	=> 'Önbellekteki tüm dosyalar silindi.',
	'ACP_SHOWSHARES'			=> 'Paylaşım sayısını görüntüle',
	'ACP_SHOWSHARES_EXPLAIN'	=> 'Buttonların sağında kaç kişi tarafından paylaşıldığı görüntülenir.',
	'ACP_PURGE_CACHE'			=> 'Önbellek temizliği',
	'ACP_PURGE_CACHE_EXPLAIN'	=> 'Önbellekteki tüm dosyaları sil',
	'RUN_NOW'					=> 'Şimdi Çalıştır',
));
Regards..

Post Reply

Return to “Extensions in Development”