[RC] [forum permission] Allow viewing topics started by others

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
heinrich_k
Registered User
Posts: 191
Joined: Fri Jul 17, 2009 11:40 am

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by heinrich_k » Fri Feb 16, 2018 11:29 am

Features like this have been asked for in 3.0 and 3.1 so I's really appreciate it, when someone from the project team would take over this extension and make it work.

It seems to be a not that trivial task, so it could really benefit if someone who is familiar with the workings of the forum code would pitch in.

User avatar
brunoais
QA Team
Posts: 407
Joined: Wed Jun 18, 2008 10:50 am

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by brunoais » Sun Feb 18, 2018 10:49 am

A new version was submitted for validation.

heinrich_k
Registered User
Posts: 191
Joined: Fri Jul 17, 2009 11:40 am

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by heinrich_k » Sun Feb 18, 2018 11:11 am

You are great!

kamaleon
Registered User
Posts: 416
Joined: Tue Sep 09, 2014 9:47 am
Location: Barcelona

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by kamaleon » Fri Feb 23, 2018 2:04 pm

Where to get the latest version?

From here??

https://github.com/brunoais/readOthersTopics

User avatar
brunoais
QA Team
Posts: 407
Joined: Wed Jun 18, 2008 10:50 am

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by brunoais » Sun Feb 25, 2018 5:59 pm

kamaleon wrote:
Fri Feb 23, 2018 2:04 pm
Where to get the latest version?

From here??

https://github.com/brunoais/readOthersTopics
brunoais wrote:
Sat Dec 13, 2014 11:29 am
Download:
1st release: https://github.com/brunoais/readOthersTopics/tree/1.0.1

kamaleon
Registered User
Posts: 416
Joined: Tue Sep 09, 2014 9:47 am
Location: Barcelona

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by kamaleon » Wed Feb 28, 2018 2:59 pm

I installed it thanks, but where is the admin for this extension?

heinrich_k
Registered User
Posts: 191
Joined: Fri Jul 17, 2009 11:40 am

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by heinrich_k » Wed Feb 28, 2018 3:26 pm

kamaleon wrote:
Wed Feb 28, 2018 2:59 pm
I installed it thanks, but where is the admin for this extension?
Havn't installed it yet, but my geuss is, there isn't a seperate admin console. If the extension is installed, there is a new enty with the forum permissions per forum. So you have to adjust the setting there for each forum you have.

kamaleon
Registered User
Posts: 416
Joined: Tue Sep 09, 2014 9:47 am
Location: Barcelona

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by kamaleon » Thu Mar 01, 2018 4:45 pm

From what I found it creates a new forum role.

Is there anything else I am missing?

User avatar
brunoais
QA Team
Posts: 407
Joined: Wed Jun 18, 2008 10:50 am

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by brunoais » Thu Mar 01, 2018 6:15 pm

It creates a new permission which is deactivated in that role.

If the installation went well, you should see no changes in your forums' apparent settings.
You will notice, though, that a new permission appeared under the "Can read forum"

In the extension version which was submitted for the extensions DB, though, that won't happen because they didn't allow me to.

heinrich_k
Registered User
Posts: 191
Joined: Fri Jul 17, 2009 11:40 am

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by heinrich_k » Thu Mar 01, 2018 6:44 pm

So, how does the version you submitted work?

You create a new forum and give all those you want to read only their own topics this new role, while mods get standard access to reply to all topics ?

User avatar
brunoais
QA Team
Posts: 407
Joined: Wed Jun 18, 2008 10:50 am

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by brunoais » Thu Mar 01, 2018 6:57 pm

heinrich_k wrote:
Thu Mar 01, 2018 6:44 pm
So, how does the version you submitted work?

You create a new forum and give all those you want to read only their own topics this new role, while mods get standard access to reply to all topics ?
This permission doesn't care who it is. It can even be an admin with founder status. If he doesn't have the permission, he cannot see what he's set as not supposed to.

In the extension in the extensions DB,
  1. The new permission will appear somewhere (I cannot control where)
  2. A new role is created but I cannot control what it contains, so it has whatever phpBB decides it should contain.
In the extension as I wanted,
  1. The new permission will appear under "Can read forum"
  2. The new role is created, which copies the "Standard access" role, and then sets this permission to "no"
  3. Mirrors the value of this permission based on groups's permissions' "Can read forum" permission

User avatar
3Di
Registered User
Posts: 13120
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by 3Di » Thu Mar 01, 2018 7:32 pm

^^ Why are you not using core.permissions event if I can ask? To set the right category where the new permission will be shown.
:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
brunoais
QA Team
Posts: 407
Joined: Wed Jun 18, 2008 10:50 am

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by brunoais » Thu Mar 01, 2018 9:14 pm

3Di wrote:
Thu Mar 01, 2018 7:32 pm
^^ Why are you not using core.permissions event if I can ask? To set the right category where the new permission will be shown.
This? https://github.com/phpbb/phpbb/blob/mas ... ns.php#L66
Does the extensions team allow that?

In any case, I'd have to study in what situations that event is called. I also find it weird that original permissions' category is set in the DB and extension's categories have to be adjusted after loading from the DB.
Last edited by brunoais on Thu Mar 01, 2018 9:25 pm, edited 1 time in total.

User avatar
canonknipser
Registered User
Posts: 1711
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by canonknipser » Thu Mar 01, 2018 9:21 pm

brunoais wrote:
Thu Mar 01, 2018 9:14 pm
Does the extensions team allow that?
It's in the official tutorial: https://area51.phpbb.com/docs/dev/exten ... sions.html
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB

User avatar
3Di
Registered User
Posts: 13120
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [BETA] [forum permission] Allow viewing topics started by others

Post by 3Di » Thu Mar 01, 2018 9:28 pm

brunoais wrote:
Thu Mar 01, 2018 9:14 pm
3Di wrote:
Thu Mar 01, 2018 7:32 pm
^^ Why are you not using core.permissions event if I can ask? To set the right category where the new permission will be shown.
This? https://github.com/phpbb/phpbb/blob/mas ... ns.php#L66
Does the extensions team allow that?

In any case, I'd have to study in what situations that event is called. I also find it weird that original permissions' category is set in the DB and extension's categories have to be adjusted after loading from the DB.
Yes it' allowed, moreover it's suggested:
https://github.com/3D-I/HighlightPosts/ ... er.php#L33
https://github.com/3D-I/HighlightPosts/ ... #L354-L386

migration https://github.com/3D-I/HighlightPosts/ ... hp#L13-L35

language https://github.com/3D-I/HighlightPosts/ ... hp#L11-L26

usage https://github.com/3D-I/HighlightPosts/ ... hp#L76-L86

And you can also copy native permissions into your new permission, see the guide:
https://area51.phpbb.com/docs/dev/3.2.x ... ssion.html

You'd need to rewrite your migration and get rid of all of those queries at a first glance.

And, your extension will be pretty finished. :)
:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: mortalites and 28 guests