[RC] [forum permission] Allow viewing topics started by others

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 24588
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: [RELEASED][forum permission] Allow viewing topics started by others

Post by Paul » Sun Apr 03, 2016 5:07 pm

Please update your prefix according to https://www.phpbb.com/extensions/rules- ... /#prefixes , otherwise we need to close your topic.

Thanks.

@Mauron, Please use the report function instead of posting in the topic yourself.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

Wesley88
Registered User
Posts: 115
Joined: Mon Jun 15, 2015 4:38 pm

Re: [RELEASED][forum permission] Allow viewing topics started by others

Post by Wesley88 » Tue Apr 05, 2016 12:42 am

brunoais wrote:...And it's released!
It is currently waiting to be approved.
So... eh... Fingers crossed? :twisted:

This extension is not ready. It fails badly when it comes to viewing peoples posts. It happens when for example moderator has no access to some forums where this ext is active. That same moderator is not able to view other people posts under profile page (says no posts when you click on their profile while they actually have posts in various forums). Once extension is disabled things are working normally. Just my 2 cents. Had it tested on test board. Some things needs fixing before this can be released. Tested on the latest version. Thanks

User avatar
brunoais
QA Team
Posts: 406
Joined: Wed Jun 18, 2008 10:50 am

Re: [RELEASED][forum permission] Allow viewing topics started by others

Post by brunoais » Tue Apr 05, 2016 7:05 am

Paul wrote:Please update your prefix according to https://www.phpbb.com/extensions/rules- ... /#prefixes , otherwise we need to close your topic.
Done. Sorry about that.
Wesley88 wrote:
brunoais wrote:...And it's released!
It is currently waiting to be approved.
So... eh... Fingers crossed? :twisted:

This extension is not ready. It fails badly when it comes to viewing peoples posts. It happens when for example moderator has no access to some forums where this ext is active. That same moderator is not able to view other people posts under profile page (says no posts when you click on their profile while they actually have posts in various forums). Once extension is disabled things are working normally. Just my 2 cents. Had it tested on test board. Some things needs fixing before this can be released. Tested on the latest version. Thanks
Let's see... You had 1 month to complain about that and you didn't because..........

Wesley88
Registered User
Posts: 115
Joined: Mon Jun 15, 2015 4:38 pm

Re: [RC][forum permission] Allow viewing topics started by others

Post by Wesley88 » Tue Apr 05, 2016 7:52 am

brunoais, i tested the extension yesterday and noticed the issue right away. Thanks :)

User avatar
Nikola
Registered User
Posts: 284
Joined: Fri Jun 12, 2015 11:47 am
Name: Nikola

Re: [RC][forum permission] Allow viewing topics started by others

Post by Nikola » Tue Apr 05, 2016 7:56 am

I've had similar issue and talked with bruno about it. I will test the new version later today to see if it does the same thing.
"What would happen if the autism gene was eliminated from the genetic pool?

You would have a bunch of people standing around in a cave, chatting and socializing and not getting anything done."

- Dr. Temple Grandin, A Personal Look at Autism and Asperger's Syndrome.

User avatar
brunoais
QA Team
Posts: 406
Joined: Wed Jun 18, 2008 10:50 am

Re: [RC][forum permission] Allow viewing topics started by others

Post by brunoais » Tue Apr 05, 2016 2:04 pm

Det. Lawliet wrote:I've had similar issue and talked with bruno about it. I will test the new version later today to see if it does the same thing.
Lawliet, I've been waiting for feedback from you and I haven't been having any. It's been months now...
Now you come back?

User avatar
Nikola
Registered User
Posts: 284
Joined: Fri Jun 12, 2015 11:47 am
Name: Nikola

Re: [RC][forum permission] Allow viewing topics started by others

Post by Nikola » Tue Apr 05, 2016 6:44 pm

Hey bruno. I was looking for you on the IRC several times after that. Then I went little inactive due to real life issues. I can come so we can test out stuff properly. Just tell me when. Cheers.
"What would happen if the autism gene was eliminated from the genetic pool?

You would have a bunch of people standing around in a cave, chatting and socializing and not getting anything done."

- Dr. Temple Grandin, A Personal Look at Autism and Asperger's Syndrome.

User avatar
thebigmattb
Registered User
Posts: 47
Joined: Tue Jan 29, 2008 8:21 pm
Location: Sheffield, UK
Contact:

Re: [RC][forum permission] Allow viewing topics started by others

Post by thebigmattb » Fri May 06, 2016 5:20 pm

Yeah I just noticed that after we started to use topic moderation for certain forums.

Also noticed another bug, it just randomly happened. Worked okay and has just randomly happened. Not changed anything.

Only happens when you click MCP

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/brunoais/readOthersTopics/event/main_listener.php on line 362: Undefined variable: post_list

Warning: Cannot modify header information - headers already sent by (output started at /home2/newyorks/public_html/includes/functions.php:3925) in /home2/newyorks/public_html/includes/functions.php on line 2537

General Error
SQL ERROR [ mysql4 ]

[0]

SQL

No values specified for SQL IN comparison

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 855
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 536
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 441
CALL: phpbb\db\driver\driver->sql_in_set()

FILE: [ROOT]/includes/mcp/mcp_front.php
LINE: 118
CALL: phpbb\db\driver\factory->sql_in_set()

FILE: [ROOT]/includes/mcp/mcp_main.php
LINE: 181
CALL: mcp_front_view()

FILE: [ROOT]/includes/functions_module.php
LINE: 674
CALL: mcp_main->main()

FILE: [ROOT]/mcp.php
LINE: 310
CALL: p_master->load_active()

User avatar
brunoais
QA Team
Posts: 406
Joined: Wed Jun 18, 2008 10:50 am

Re: [RC][forum permission] Allow viewing topics started by others

Post by brunoais » Sat May 07, 2016 4:00 pm

Thanks for the report. I'll look into it as soon as I get some free time.

User avatar
thebigmattb
Registered User
Posts: 47
Joined: Tue Jan 29, 2008 8:21 pm
Location: Sheffield, UK
Contact:

Re: [RC][forum permission] Allow viewing topics started by others

Post by thebigmattb » Sun May 08, 2016 12:55 pm

brunoais wrote:Thanks for the report. I'll look into it as soon as I get some free time.
It seems to have fixed itself.... strange.... very strange!

User avatar
thebigmattb
Registered User
Posts: 47
Joined: Tue Jan 29, 2008 8:21 pm
Location: Sheffield, UK
Contact:

Re: [RC][forum permission] Allow viewing topics started by others

Post by thebigmattb » Sun May 22, 2016 4:08 pm

Oh no its back... random as hell.

I think it seems to be when a post falls into a mod queue I am not part of. Soon as the mod clears it I can see MCP Again. I Can also see the posts in the notifications for forums where I am not a moderator.

User avatar
brunoais
QA Team
Posts: 406
Joined: Wed Jun 18, 2008 10:50 am

Re: [RC][forum permission] Allow viewing topics started by others

Post by brunoais » Sat May 28, 2016 9:18 am

I found the random and fixed it. I'll try looking into more today before I release another version.

User avatar
yasser33311
Registered User
Posts: 255
Joined: Sat Jul 27, 2013 1:27 pm
Location: algeria
Name: yasser ghe
Contact:

Re: [RC][forum permission] Allow viewing topics started by others

Post by yasser33311 » Sat Jun 18, 2016 10:33 am

arabic translation:

Code: Select all

<?php
/**
*
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/

/**
* DO NOT CHANGE
*/
if (!defined('IN_PHPBB'))
{
	exit;
}

if (empty($lang) || !is_array($lang))
{
	$lang = array();
}

// DEVELOPERS PLEASE NOTE
//
// All language files should use UTF-8 as their encoding and the files must not contain a BOM.

$lang = array_merge($lang, array(
	'SORRY_AUTH_READ_OTHER'			=> 'ليس لديك صلاحية لمشاهدة هذا الموضوع',
	
));

Code: Select all

<?php
/**
*
* @package phpBB Extension - brunoais readOthersTopics
* @copyright (c) 2015 phpBB Group
* @license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2
*
*/

/**
* DO NOT CHANGE
*/
if (!defined('IN_PHPBB'))
{
	exit;
}

if (empty($lang) || !is_array($lang))
{
	$lang = array();
}

// DEVELOPERS PLEASE NOTE
//
// All language files should use UTF-8 as their encoding and the files must not contain a BOM.

$lang = array_merge($lang, array(

	'ACL_F_READ_OTHERS_TOPICS' => 'يمكنه مشاهدة المواضيع التي بدأها آخرون',
	'BRUNOAIS_ROLE_READ_OTHERS_TOPICS' => 'يمكنه مشاهدة مواضيعه فقط',
	'BRUNOAIS_ROLE_DESCRIPTION_READ_OTHERS_TOPICS' => 'يمكنه استعمال خصائص المنتدى الرئيسية ماعدا مشاهدة المواضيع التي بدأها آخرون.',

));
PhpBB Services - install, update, upgrade, customize: https://phpbb.services

User avatar
brunoais
QA Team
Posts: 406
Joined: Wed Jun 18, 2008 10:50 am

Re: [RC][forum permission] Allow viewing topics started by others

Post by brunoais » Wed Jun 22, 2016 8:02 am

Thank you.
Unfortunately, I'm now completely overloaded. I can only resume this somewhere late next month

User avatar
RedArrow
Registered User
Posts: 128
Joined: Mon Jun 03, 2013 11:24 pm

Re: [RC][forum permission] Allow viewing topics started by others

Post by RedArrow » Fri Jul 01, 2016 3:30 pm

Hi brunoais,

Firstly - 'I'm sad to see your Request https://tracker.phpbb.com/browse/PHPBB3-10623 was rejected to get this function added to the core of phpBB.... It really needs something like this!

Are you able to get any headway with this Extension, will it support 3.1.9/3.2 when it's released & are you able to give any ETAs till this?

Please don't give up with this Extension! I'm sure it'll be VERY popular once you have completed all of it's support for latest versions of phpBB.

Many thanks.

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: Blitze, EFiNSTORM, Hippie459MN and 14 guests