[RC] [forum permission] Allow viewing topics started by others

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
brunoais
QA Team
Posts: 418
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Tue Feb 03, 2015 1:20 pm

qarclas wrote:any ETA on the 3.1.3 release (aware it will have security holes)
If all goes smoothly from here on, the alpha release should happen around mid February.
qarclas wrote: note: I don't know which is a topic, a thread or what terminology to use.
Just use topic.
qarclas wrote: Also to clarify, have been reading the posts above and want to make sure it actually does what I want it to.

We have a thread on our forums for new applications for joining our group.
This thread is visable by our current members. All posts.
Only the announce posts at the top should be visable by new registered users and any new posts they make.

eg. If 9 new people register on the forums and make a post in this thread, they should only see their OWN post and the announce posts at the top. Not the other 8 posts from other new users.

Is that how it can be configured to work?
Yes. This new permission will allow that.
MastaSukeh wrote:Is there a way to manage this permission per thread?
As in default for forum is that no one except the creator and admin/mods can see it, but if we want so that someone else can see this specific thread per their involvement?
No. This is not for such use-case. See: viewtopic.php?f=456&t=2283001&p=13929601#p13928701
The extension proposed there is what you want. I'll, most likely, pick that up if no one else does it.

User avatar
aka_void
Registered User
Posts: 108
Joined: Tue May 20, 2003 7:01 pm
Location: Location: Lost
Name: Mark
Contact:

Re: [Dev][forum permission] Allow view topics started by others

Post by aka_void » Tue Feb 03, 2015 1:40 pm

Is this just a self auth extension?

The topic title suggests it's a feature that's already in phpBB 3.1 by default (and all message board software)

brunoais
QA Team
Posts: 418
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Tue Feb 03, 2015 2:18 pm

Did you read the first post and the resources linked there?

MastaSukeh
Registered User
Posts: 12
Joined: Mon Feb 02, 2015 9:29 am

Re: [Dev][forum permission] Allow view topics started by others

Post by MastaSukeh » Wed Feb 04, 2015 9:56 am

brunoais wrote:
MastaSukeh wrote:Is there a way to manage this permission per thread?
As in default for forum is that no one except the creator and admin/mods can see it, but if we want so that someone else can see this specific thread per their involvement?
No. This is not for such use-case. See: viewtopic.php?f=456&t=2283001&p=13929601#p13928701
The extension proposed there is what you want. I'll, most likely, pick that up if no one else does it.
Well, it would be a nice addition, for sure.

brunoais
QA Team
Posts: 418
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Thu Feb 05, 2015 12:59 pm

Hello everyone.
Here's another update on this extension for the interested.
If you are willing to help me testing this extension then continue reading. If you are just waiting for the finished product, there's still more waiting to do.

At this point, I want to test if the basic setup is working as intended. This permission is not effective yet except for this test's purpose.

The new permission should only be applied to viewtopic.php file only. That is when you try to see the topic itself (not the topic list). The permission isn't enforced anywhere else at this point.
There are a lot of changes made to the core code, most being reusable code used to enforce this permission in multiple places.

Don't forget to purge the before testing, if you haven't.

Here's what I need tested:
  1. Normal topic access
  2. Topic access of user without permissions to see other's topics (no matter the rank)
Here's a grained list of things that should happen upon a correct execution:
  1. Right after installing the extension, all users have access to all topics of forums where they had "Can see forum" permission before the extension was installed.
  2. A user on a forum without the "Can read topics started by others" can see the topics in the list but if he tries to access one he didn't start, his access is denied.
  3. (same as previous one except when accessing a topic he started).
  4. It doesn't matter if the user is an admin, moderator, etc... If he doesn't have "Can read topics started by others", he must be unable to access viewtopic for a topic he didn't start.
All testing help you can give is very well welcome. This testing is very important to make sure that the auxiliary functions are working as intended and that the installation is working as intended.
Please do not test this on a real live forum. Please test this on a clone of your forum as it may fail at any point. A clone is a good idea because it should have large amount of data to work with that helps testing edge cases.
Please warn me here (unless a moderator states otherwise) on any bugs you find at this process based on the list above.

MastaSukeh
Registered User
Posts: 12
Joined: Mon Feb 02, 2015 9:29 am

Re: [Dev][forum permission] Allow view topics started by others

Post by MastaSukeh » Sun Feb 15, 2015 5:41 pm

Hmm, you should add an option if this should work for stickies and announcements;

What if I have an application section, and don't want people to see applications from other users, but I want them to be able to read the format in which they should apply - which is the sticky - which can't be accessed due to that permission.

User avatar
Puchahawa
Registered User
Posts: 768
Joined: Sat Jan 01, 2011 10:33 pm
Name: Randy

Re: [Dev][forum permission] Allow view topics started by others

Post by Puchahawa » Sun Feb 15, 2015 9:27 pm

Hi brunoais, I just d/l dev 0.0.5 and checked it out. working as desired. I tested it on my local board (v3.1.3) and set up a forum with standard registered user permissions with the exception of your permission Can read topics started by others which I set to no.

I then logged in as one of my test registered users and posted a topic. Then logged in as my second test registered user and tried to access it and was denied. :D

I did another test. second user posted new topic and first couldn't read it. :D :D

looked at both topics as an admin no problem. WELL DONE!

I did a third test. Posted a new topic as an admin and looked to see if the registered users could read it and they couldn't.

I had no problem loading the extension. You may want to edit the first post to give them the folder rename for testing the extension. brunoais\readOthersTopics

Only thing that I noticed and I'm not sure there is anything that can be done about it is when I posted the second time the first post was showing as unread which for the avg poster may prompt them to try and read it. Not that it would matter because they can't. That may not be an issue with a good explanation of what that forum is for.
Last edited by Puchahawa on Sun Feb 15, 2015 9:41 pm, edited 1 time in total.

User avatar
FoFa
Registered User
Posts: 200
Joined: Wed Dec 03, 2008 9:21 am
Name: Daniel L.
Contact:

Re: [Dev][forum permission] Allow view topics started by others

Post by FoFa » Sun Feb 15, 2015 9:36 pm

Hello,

Downloaded this extension, put it into the right folder ext/brunoais/readOthersTopics/

When I want to access a topic I am not supposed having access to, I got an error:

Language file ./ext/brunoais\readOthersTopics/language/en/common.php couldn't be opened.

Thanks :wink:
Formly ForumsFaciles :wink:

brunoais
QA Team
Posts: 418
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Mon Feb 16, 2015 10:51 am

MastaSukeh wrote:Hmm, you should add an option if this should work for stickies and announcements;

What if I have an application section, and don't want people to see applications from other users, but I want them to be able to read the format in which they should apply - which is the sticky - which can't be accessed due to that permission.
Make it a forum-specific announcement. If those are filtered out (like the other topics are) then it is a bug I have to fix.
Puchahawa wrote: --sip
looked at both topics as an admin no problem. WELL DONE!
Thanks
Puchahawa wrote: I had no problem loading the extension. You may want to edit the first post to give them the folder rename for testing the extension. brunoais\readOthersTopics
OK, done. Does it look correct that way?
Puchahawa wrote: Only thing that I noticed and I'm not sure there is anything that can be done about it is when I posted the second time the first post was showing as unread which for the avg poster may prompt them to try and read it. Not that it would matter because they can't. That may not be an issue with a good explanation of what that forum is for.
That may be some unfinished stuff with the current version. I'm finishing some stuff and I should be able to release 0.1.0-dev later today for testing.
ForumsFaciles wrote:Hello,
Downloaded this extension, put it into the right folder ext/brunoais/readOthersTopics/
When I want to access a topic I am not supposed having access to, I got an error:
Language file ./ext/brunoais\readOthersTopics/language/en/common.php couldn't be opened.
Thanks :wink:
Is the file there? If yes,
Is that running on Apache? Which OS are you using?

User avatar
Puchahawa
Registered User
Posts: 768
Joined: Sat Jan 01, 2011 10:33 pm
Name: Randy

Re: [Dev][forum permission] Allow view topics started by others

Post by Puchahawa » Mon Feb 16, 2015 4:00 pm

brunoais wrote:
Puchahawa wrote: I had no problem loading the extension. You may want to edit the first post to give them the folder rename for testing the extension. brunoais\readOthersTopics
OK, done. Does it look correct that way?
Yes. Will watch for release 0.1.0-dev. :D

brunoais
QA Team
Posts: 418
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Mon Feb 16, 2015 6:34 pm

Puchahawa wrote:
brunoais wrote:
Puchahawa wrote: I had no problem loading the extension. You may want to edit the first post to give them the folder rename for testing the extension. brunoais\readOthersTopics
OK, done. Does it look correct that way?
Yes. Will watch for release 0.1.0-dev. :D
I'm having some RL issues going on... I'm not so sure if I can release that version today... I'll see what I can.

User avatar
Puchahawa
Registered User
Posts: 768
Joined: Sat Jan 01, 2011 10:33 pm
Name: Randy

Re: [Dev][forum permission] Allow view topics started by others

Post by Puchahawa » Mon Feb 16, 2015 8:14 pm

No hurry. RL comes first.

MastaSukeh
Registered User
Posts: 12
Joined: Mon Feb 02, 2015 9:29 am

Re: [Dev][forum permission] Allow view topics started by others

Post by MastaSukeh » Tue Feb 17, 2015 9:32 am

brunoais wrote:
MastaSukeh wrote:Hmm, you should add an option if this should work for stickies and announcements;

What if I have an application section, and don't want people to see applications from other users, but I want them to be able to read the format in which they should apply - which is the sticky - which can't be accessed due to that permission.
Make it a forum-specific announcement. If those are filtered out (like the other topics are) then it is a bug I have to fix.
Tried. Filtered. User cannot see announcements.

Code: Select all

General Error
Language file ./ext/brunoais\readOthersTopics/language/en/common.php couldn't be opened.
1. users cannot open announcement topics if they don't have 'see other users post' permission.
2. when testing user's permissions I can open the announcement topic.
3. Please, give us an option to display a custom error message instead of General Error upon entering a topic without permission.

Thanks!

User avatar
FoFa
Registered User
Posts: 200
Joined: Wed Dec 03, 2008 9:21 am
Name: Daniel L.
Contact:

Re: [Dev][forum permission] Allow view topics started by others

Post by FoFa » Tue Feb 17, 2015 9:26 pm

brunoais wrote:
ForumsFaciles wrote:Hello,
Downloaded this extension, put it into the right folder ext/brunoais/readOthersTopics/
When I want to access a topic I am not supposed having access to, I got an error:
Language file ./ext/brunoais\readOthersTopics/language/en/common.php couldn't be opened.
Thanks :wink:
Is the file there? If yes,
Is that running on Apache? Which OS are you using?
File here. Running on Apache. Windows Seven.
Formly ForumsFaciles :wink:

User avatar
Puchahawa
Registered User
Posts: 768
Joined: Sat Jan 01, 2011 10:33 pm
Name: Randy

Re: [Dev][forum permission] Allow view topics started by others

Post by Puchahawa » Tue Feb 17, 2015 9:41 pm

Have you tried going to the customs tab and disabling then reinabling the extension? or disable then replacing the extensions files?

Post Reply

Return to “Extensions in Development”

cron