[RC] [forum permission] Allow viewing topics started by others

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
brunoais
QA Team
Posts: 420
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Thu Feb 26, 2015 1:17 pm

qarclas wrote:is that something I can fix?

Probably not, unless you know phpBB's source code.
qarclas wrote:
you can fix?

I don't know. I didn't investigate it yet.
qarclas wrote:
needs to be fixed in phpbb itself?

I think so, yes


My apologies. I misread the instructions and I used a function in an unintended way. This will be solved in the next sub-sub-version.
New release: https://github.com/brunoais/phpbbextf_r ... /0.1.1-dev

qarclas
Registered User
Posts: 21
Joined: Wed Jan 07, 2015 2:31 am

Re: [Dev][forum permission] Allow view topics started by others

Post by qarclas » Thu Feb 26, 2015 10:39 pm

Image

you fixed it :)

brunoais
QA Team
Posts: 420
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Sun Mar 01, 2015 11:47 pm

Status update
I believe I have nearly finished the extension. What I'm left is the search system where I can't set the pagination to work correctly and I need advice on how to make the best event to make it work how I want to.
There's also some other events that require merging to phpBB but they are all set to merge to phpBB in 3.1.4.
I'll announce the next release after enough of those events are merged.
The current version will seem broken because of the missing events.

User avatar
FoFa
Registered User
Posts: 200
Joined: Wed Dec 03, 2008 9:21 am
Name: Daniel L.
Contact:

Re: [Dev][forum permission] Allow view topics started by others

Post by FoFa » Mon Mar 02, 2015 11:12 pm

Hello,

I love this extension and thank you for working on it.

Nobodays, would like to suggest something...

Actually, without this extension, we have this case:
Take a forum, which name is "Support".
I, Paul, post a subject. If John is on index page, he can see that I posted something. If I am on index page, I can see that I posted something.
john can enter the forum, see and read this subject. I can do same thing.

But with this extension, we have this case:
Take a forum, which name is "Support".
I, Paul, post a subject. If John is on index page, he can't see that I posted something. If I am on index page, I can't see that I posted something.
John can enter the forum, but can't see nor read this subject. I can enter the forum, see and read the subject.

What I would appreciate is to have my last subject shown on index page and viewforum page. Did John post a new subject after me ? No problem, this extension shows me my last subject. And no "Classified Information". Didn't I post any subject on this forum ? Ok, let's say me "No subject".

Sorry, I speak French so hope you understand me :wink:

Thanks
Formly ForumsFaciles :wink:

brunoais
QA Team
Posts: 420
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Tue Mar 03, 2015 8:30 am

@ForumsFaciles
Such features are not part of the core concept of this extension.
That is thought but it will only be added after the extension is in a stable version and accepted by the validation team.

User avatar
FoFa
Registered User
Posts: 200
Joined: Wed Dec 03, 2008 9:21 am
Name: Daniel L.
Contact:

Re: [Dev][forum permission] Allow view topics started by others

Post by FoFa » Tue Mar 03, 2015 9:04 am

Hello,

I understant you want to have a validated extension before adding some more options.

If you tell me you're thinking about my request for a future version of your extension, it satisfy me.

Thanks, tested it and it works fine actually as it's supposed to be working.
Formly ForumsFaciles :wink:

brunoais
QA Team
Posts: 420
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Tue Mar 03, 2015 5:31 pm

ForumsFaciles wrote:Thanks, tested it and it works fine actually as it's supposed to be working.
Not really. Pagination is broken to bits in most pages for the current online version.

The version that is online now isn't the most updated and the most updated version requires new events that are waiting to be merged.

I'm making some final checks before updating the version and uploading what, probably, will be the first stable version's code.

User avatar
FoFa
Registered User
Posts: 200
Joined: Wed Dec 03, 2008 9:21 am
Name: Daniel L.
Contact:

Re: [Dev][forum permission] Allow view topics started by others

Post by FoFa » Tue Mar 03, 2015 5:39 pm

I tested it on board with one single topic. So no pagination tested.
Formly ForumsFaciles :wink:

brunoais
QA Team
Posts: 420
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Tue Mar 03, 2015 7:05 pm

Oh, also, this event is still not working for search.
I've tried to get help on where is the best place to place the events so that I can avoid doing something I shouldn't.... but I'm getting none, so I'll just do the planning myself.

User avatar
FoFa
Registered User
Posts: 200
Joined: Wed Dec 03, 2008 9:21 am
Name: Daniel L.
Contact:

Re: [Dev][forum permission] Allow view topics started by others

Post by FoFa » Thu Mar 05, 2015 12:03 am

Hello,

Noticed something...

On my index page I have:

CATEGORY 1 (permission set to YES)
------- SUB-CATEGORY 1 (permission set to YES)
-------------- FORUM 1 (permission set to NEVER)
-------------- FORUM 2 (permission set to YES)
-------------- FORUM 3 (permission set to YES)

If John creates a new topic in FORUM 1, I can't read it. If I enter the direct link to the topic, I'm told I can't read. Good.

BUT, when viewing my index page, I can see the topic created in FORUM 1 (without being able to read it, see above). So, on index page I don't have "Confidential access" but topic infos about a topic I'm not supposed to konw its existence.
Formly ForumsFaciles :wink:

brunoais
QA Team
Posts: 420
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Thu Mar 05, 2015 10:16 am

Thanks for the help, @ForumsFaciles.
It is now solved on my end. I'm now organizing some commits to get this version out.

Just note that due to some still missing PR merges, that version will still not work properly.

Korkel
Registered User
Posts: 391
Joined: Mon Jun 02, 2014 7:09 am
Location: ~/home/Liz/Desktop
Name: Liz Aalderink
Contact:

Re: [Dev][forum permission] Allow view topics started by others

Post by Korkel » Wed Mar 18, 2015 1:09 pm

Is this something like I requested? viewtopic.php?f=496&t=2304891
"If you lose your left arm, your right arm will be left."
“The most important property of a program is whether it accomplishes the intention of its user.”
Image

rawrjoel
Registered User
Posts: 14
Joined: Mon Mar 16, 2015 4:24 pm

Re: [Dev][forum permission] Allow view topics started by others

Post by rawrjoel » Thu Mar 19, 2015 1:11 am

I think ForumsFaciles was talking about what i'm wondering about;

I'm experiencing this:

CATEGORY 1.... YES
- FORUM 1... NO

If the user is looking from the forum index under category 1 it says "Classified information", good.
If the user clicks into forum 1, it displays all forum posts (their titles), bad
If the user clicks into a forum post, it says they do not have permission, good.

How can i change it so that they can't see the forum posts when they click into the forums?

brunoais
QA Team
Posts: 420
Joined: Wed Jun 18, 2008 10:50 am

Re: [Dev][forum permission] Allow view topics started by others

Post by brunoais » Fri Mar 20, 2015 8:38 am

rawrjoel:
brunoais wrote:Thanks for the help, @ForumsFaciles.
It is now solved on my end. I'm now organizing some commits to get this version out.

Just note that due to some still missing PR merges, that version will still not work properly.

User avatar
Puchahawa
Registered User
Posts: 768
Joined: Sat Jan 01, 2011 10:33 pm
Name: Randy

Re: [Dev][forum permission] Allow view topics started by others

Post by Puchahawa » Fri Mar 20, 2015 4:43 pm

Hi Brunoais, Looking forward to the release of this ext. I was messing with a new extension that David63 created. It allows global announcements to be shown on the index page of the board.

The reason I'm sharing this is that the global announcements show as they should in the test forum I have set up using your ext Allow view topics started by others and they can be read by all mbrs. I know that was an issue for some people as they want to use announcements to share rules or what not in their help forum and at the moment they can't.

I just thought that since the global is readable by everyone using Davids extension that there may be some bit of code in there that may help you to get the announcements to be readable by all in this ext. :)

Post Reply

Return to “Extensions in Development”