[CDB] Google Search

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
User avatar
KhurramMunawar
Registered User
Posts: 534
Joined: Tue Mar 25, 2014 2:20 am
Location: Islamabad, Pakistan
Name: Khurram Munawar
Contact:

Re: [RC] Google Search

Post by KhurramMunawar » Tue Feb 10, 2015 9:22 pm

very nice update. HifiKabin. Thanks bro.

Just a suggestion

"Google Forum Search" prefilled txt inside the search bar is quite big and does not fit in the search bar.
make it according to phpbb forum search bar default txt size

I think : "Google Search" will be better than "Google Forum Search"
Just a suggestion.
My forum:
DearHelper.org
Get Free Traffic To Your Website
Trafficonic.com - Free Traffic To Your Website

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3984
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] Google Search

Post by HiFiKabin » Wed Feb 11, 2015 9:37 am

KhurramMunawar wrote:very nice update. HifiKabin. Thanks bro.

Just a suggestion

"Google Forum Search" prefilled txt inside the search bar is quite big and does not fit in the search bar.
make it according to phpbb forum search bar default txt size

I think : "Google Search" will be better than "Google Forum Search"
Just a suggestion.
I had it that way so as to make it clear that it is a Google search of the forum not a Google search of the web.On my test forum it fills the box nicely. Is it a language issue? (ie, the words in your language files in use are physically longer)

Image
imgurl

User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

Re: [RC] Google Search

Post by javiexin » Tue Mar 24, 2015 8:38 pm

Thanks a lot for the extension.

I have some suggested changes: replace the content of overall_header_breadcrumbs_after.html by:

Code: Select all

<!-- IF S_DISPLAY_SEARCH -->
<li class="rightside responsive-hide">
	<div id="g-search-box" class="search-box" style="margin-top:2px;">
		<form method="get" action="http://www.google.com/search">
			<fieldset>
				<input action="text" name="q" type="search" maxlength="255" class="inputbox search tiny" size="20" value="{SEARCH_WORDS}" placeholder="Google {L_FORUM} {L_SEARCH}" />
				<button class="button icon-button search-icon" type="submit" name="sitesearch" value="{BOARD_URL}" title="Google {L_SEARCH} {SITENAME}" style="border-radius: 0px 4px 4px 0px;" />
			</fieldset>
		</form>
	</div>
</li>

<li class="rightside responsive-search" style="display: none;">
	<form method="get" action="http://www.google.com/search">
		<input type="text"   name="q" size="10"maxlength="255" placeholder="Google {L_SEARCH}"/>
		<input type="submit" type="submit" name="sa" value="{L_SEARCH}"  title="Google {L_SEARCH} {SITENAME}"/>
		<input type="hidden" name="sitesearch" value="{BOARD_URL}" checked="checked"><br />
	</form>
</li>
<!-- ENDIF -->
This will adjust the margins to go in line with Navbar Search extension of your own as well, and include a cleaner, parallel structure in both extensions; also, removing some unneeded CSS. Specifically, make the id of the search box unique (to avoid clashes with CSS), and make the search button "rounded" on the right, the same as the Navbar Search buttons.

One behaviour that I do not like is the one of the breadcrumbs when both extensions are used at the same time and the window is narrow (but not as much as to make responsive take over). There is something, probably in some JS file, that is not interacting correctly with these extensions... Could you take a look?

Again, thanks for the extension(s), and I hope this helps.
-javiexin

PD: I would suggest moving this file from the all styles folder to the prosilver folder, as these apply to prosilver styles only (not to subsilver2 or others).

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3984
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] Google Search

Post by HiFiKabin » Tue Mar 24, 2015 8:53 pm

javiexin wrote:Thanks a lot for the extension.

I have some suggested changes: replace the content of overall_header_breadcrumbs_after.html by:

<snip>
Thanks, I'll have a look at that while I am re writing the extension to make it CDB compliant.

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3984
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] Google Search

Post by HiFiKabin » Thu Mar 26, 2015 1:47 pm

v 1.4.2 Added language files and corrected https error.

Update from previous version:
  • Download the latest release and unzip it.
  • Disable Google Search in the ACP
  • Delete googlesearch folder from the server
  • Upload the the folder googlesearch to root/ext/hifikabin/
  • Enable it in the ACP

User avatar
Raul [ThE KuKa]
Style Customisations
Style Customisations
Posts: 6061
Joined: Mon Dec 08, 2003 9:24 pm
Location: Spain
Name: Raul Arroyo
Contact:

Re: [RC] Google Search

Post by Raul [ThE KuKa] » Thu Mar 26, 2015 5:39 pm

Nice work and good extension. ;)
All unsolicited PMs will be ignored.
:warning: Knowledge Base | Documentation | Board rules | phpBB Styles Rules & Policies :warning:


If you like my styles, translations, etc. and want to show some appreciation, then feel free to Donate with Image
:flag_es: phpBB Spain - Online Since 2003 :heart:



Anonymous_et_EE
Registered User
Posts: 138
Joined: Sun Jul 07, 2013 2:27 pm

Re: [RC] Google Search

Post by Anonymous_et_EE » Thu May 14, 2015 7:27 am

Here is an Estonian translation for the "Google Search Extension" by HiFiKabin:

http://www.phpbbeesti.com/foorum/viewto ... p=459#p459

(Included both github link, and zip file)

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3984
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] Google Search

Post by HiFiKabin » Thu May 14, 2015 8:47 am

Anonymous_et_EE wrote:Here is an Estonian translation for the "Google Search Extension" by HiFiKabin:

http://www.phpbbeesti.com/foorum/viewto ... p=459#p459

(Included both github link, and zip file)
Many thanks. I'll add it to my Ext site

Movie
Registered User
Posts: 127
Joined: Sun Nov 02, 2014 2:54 pm
Location: Chicago Illinois Area.

Re: [RC] Google Search

Post by Movie » Fri May 15, 2015 4:18 am

Brilliant extension thanks.
View signatures turned off.

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3984
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] Google Search

Post by HiFiKabin » Wed May 20, 2015 1:47 pm

*DELETED*
Last edited by HiFiKabin on Tue May 26, 2015 1:01 pm, edited 2 times in total.

valdos
Registered User
Posts: 29
Joined: Tue May 19, 2015 9:19 am

Re: [RC] Google Search

Post by valdos » Thu May 21, 2015 9:23 am

It would be great if the search area was in the standard search box.
Switching between search would be on click.
Like here
Image

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3984
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] Google Search

Post by HiFiKabin » Thu May 21, 2015 9:44 am

Now that would be clever, though a bit beyond me at the moment. I will certainly look into it later.

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3984
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] Google Search

Post by HiFiKabin » Tue May 26, 2015 8:55 am

v 1.5.0 Style elements are in separate files, the user can decide if the search opens in the same or different window and the search box is now compatible with more styles. AR and ET languages added.

Update from previous version:
  • Download the latest release and unzip it.
  • Disable Google Search in the ACP
  • Delete googlesearch folder from the server
  • Upload the the folder googlesearch to root/ext/hifikabin/
  • Enable it in the ACP

User avatar
yasser33311
Registered User
Posts: 266
Joined: Sat Jul 27, 2013 1:27 pm
Location: algeria
Name: yasser ghe
Contact:

Re: [RC] Google Search

Post by yasser33311 » Tue May 26, 2015 7:05 pm

1.5.0 not work for me
PhpBB Services - install, update, upgrade, customize: PM

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 3984
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [RC] Google Search

Post by HiFiKabin » Tue May 26, 2015 7:15 pm

yasser33311 wrote:1.5.0 not work for me
How odd.

In what way 'not work'? It enables/disables perfectly on my test forum.

Try deleting the extension files and download a new set from my site and try again

Locked

Return to “Extensions in Development”