[CDB] National Flags

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] National Flags

Post by RMcGirr83 » Mon Jun 08, 2015 10:58 am

I can't recreate this. The extension doesn't check the ban table at all.

Now if you are speaking of inactive users, then I found the issue. ;)

https://github.com/RMcGirr83/phpBB-3.1- ... 7fd3a2aa23
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
spaceace
Registered User
Posts: 1857
Joined: Wed Jan 30, 2008 8:50 pm
Contact:

Re: [RC] National Flags

Post by spaceace » Mon Jun 08, 2015 6:47 pm

RMcGirr83 wrote:I can't recreate this. The extension doesn't check the ban table at all.

Now if you are speaking of inactive users, then I found the issue. ;)

https://github.com/RMcGirr83/phpBB-3.1- ... 7fd3a2aa23
problem solved on my end. thanks :D

i'm also using Prime Ban to Group which adds banned members to an extension made group that i guess acts like an inactive user

User avatar
Pernod70
Registered User
Posts: 20
Joined: Sun Apr 08, 2012 11:35 pm
Location: Croydon, UK
Name: Nigel Barnes
Contact:

Re: [RC] National Flags

Post by Pernod70 » Thu Jun 11, 2015 9:25 pm

Excellent extension, thanks!

A minor request... could we also get the flag on the member list page?

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] National Flags

Post by RMcGirr83 » Fri Jun 12, 2015 10:17 am

There are no events on the required html page so at this time, no.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

Fact42
Registered User
Posts: 3
Joined: Sun Jun 14, 2015 6:38 am

Re: [RC] National Flags

Post by Fact42 » Sun Jun 14, 2015 6:56 am

Love the work, even added a few flags of my own.

I was wondering if limiting the flags displayed on index to 10 is as intended?
if yes, how would I go about changing that to add an additional row of flags so i could max it to maybe 20?

(atm, the site is using 12 flags with 33 )

also this could not be the case and im just an idiot.

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] National Flags

Post by RMcGirr83 » Mon Jun 15, 2015 9:45 am

Fact42 wrote:I was wondering if limiting the flags displayed on index to 10 is as intended?
if yes, how would I go about changing that to add an additional row of flags so i could max it to maybe 20?
Yes it is intended to change it open the php file found in the core directory of the extension and find this

$result = $this->db->sql_query_limit($this->db->sql_build_query('SELECT', $sql_array), 10);

change the 10 to whatever number you want.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

Fact42
Registered User
Posts: 3
Joined: Sun Jun 14, 2015 6:38 am

Re: [RC] National Flags

Post by Fact42 » Mon Jun 15, 2015 9:07 pm

Thank you for your quick reply!

User avatar
spaceace
Registered User
Posts: 1857
Joined: Wed Jan 30, 2008 8:50 pm
Contact:

Re: [RC] National Flags

Post by spaceace » Mon Jun 15, 2015 11:47 pm

RMcGirr83 wrote:Yes it is intended to change it open the php file found in the core directory of the extension and find this

$result = $this->db->sql_query_limit($this->db->sql_build_query('SELECT', $sql_array), 10);

change the 10 to whatever number you want.
would you consider adding the option to the ACP module?

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] National Flags

Post by RMcGirr83 » Tue Jun 16, 2015 10:44 am

Yes, once it is validated.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

Howy
Registered User
Posts: 35
Joined: Sun Jun 14, 2015 12:53 pm

Re: [RC] National Flags

Post by Howy » Thu Jul 02, 2015 5:41 am

Many thanks!

I come from Taiwan.

User avatar
donsenilo
Registered User
Posts: 303
Joined: Wed Oct 08, 2014 6:23 pm
Name: Markus
Contact:

No * as Required field

Post by donsenilo » Wed Jul 08, 2015 9:35 pm

Hi

When it is selected as required field there is no *

It's important for users to know that this is a required field.

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: No * as Required field

Post by RMcGirr83 » Thu Jul 09, 2015 2:29 am

donsenilo wrote:Hi

When it is selected as required field there is no *

It's important for users to know that this is a required field.
Minutia, if they don't choose a flag then an error message is displayed. This isn't a profile field.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
Galixte de EzCom
Registered User
Posts: 1028
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] National Flags

Post by Galixte de EzCom » Thu Jul 09, 2015 2:52 am

Hi,

if it’s a required information the user must be informed. this isn’t the user to make a mistake to know the informations required or not on the form.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21034
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: [RC] National Flags

Post by RMcGirr83 » Thu Jul 09, 2015 10:23 am

Everyone is free to take the code and modify it as they see fit. I will not be adding anything additional to this extension with the exception of being able to choose the number of flags to display on the index page.

Image

and the error if no flag is chosen and the option to require the flag on registration is set in the ACP.

Image
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
Oyabun1
Former Team Member
Posts: 23162
Joined: Sun May 17, 2009 1:05 pm
Location: Australia
Name: Bill

Re: [RC] National Flags

Post by Oyabun1 » Sat Jul 11, 2015 6:49 am

Galixte de EzCom wrote:if it’s a required information the user must be informed.
Except standard phpBB doesn't do that. On a standard board the standard fields on the registration page, which are all required fields, such as the username and email address, are not marked.
                      Support Request Template
3.0.x: Knowledge Base Styles Support MOD Requests
3.1.x: Knowledge BaseStyles SupportExtension Requests

Locked

Return to “Extensions in Development”