[CDB] National Flags

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
User avatar
2600
I've Been Banned!
Posts: 2567
Joined: Fri Nov 14, 2014 5:14 pm
Location: Area-51

Re: [RC] National Flags

Post by 2600 »

Where did you get your flags? I added a NATO flag, but it doesn't look as crisp as the default flags. Is there a good NATO flag? :lol:

Also, I notice in PMs that flags don't show up.
Morpheus: Unfortunately, no one can be told what The Matrix is. You'll have to see it for yourself.
Hack me.
Consider a canary token.
The nature of my chosen username
:ugeek:
User avatar
RMcGirr83
Former Team Member
Posts: 21823
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC] National Flags

Post by RMcGirr83 »

John connor wrote:Also, I notice in PMs that flags don't show up.
You're right they don't because the extension isn't built for them to display when viewing PM's.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
2600
I've Been Banned!
Posts: 2567
Joined: Fri Nov 14, 2014 5:14 pm
Location: Area-51

Re: [RC] National Flags

Post by 2600 »

Ok.
Morpheus: Unfortunately, no one can be told what The Matrix is. You'll have to see it for yourself.
Hack me.
Consider a canary token.
The nature of my chosen username
:ugeek:
sp3ctre
Registered User
Posts: 307
Joined: Sun Jul 15, 2007 11:06 am

Re: [RC] National Flags

Post by sp3ctre »

I might be missing something obvious, but I'm getting an error when I try to enable the extension:

Code: Select all

The selected extension cannot be enabled, please verify the extension’s requirements.
My phpbb version is 3.1.5 and PHP version is 5.4.34

Is there some other dependency I am missing?
User avatar
RMcGirr83
Former Team Member
Posts: 21823
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC] National Flags

Post by RMcGirr83 »

The extension on github now requires version 3.1.6-RC1 of phpBB as new events that the version in github uses are now in the core of phpBB dev

https://github.com/phpbb/phpbb/pull/3755

You can use this one which is the one sitting in the validation queue and should install and work fine on your 3.1.5 forum.

Saying that you shouldn't be installing any un-validated extension on a live forum but choice is yours.
Last edited by RMcGirr83 on Mon Jul 27, 2015 10:00 am, edited 1 time in total.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
sp3ctre
Registered User
Posts: 307
Joined: Sun Jul 15, 2007 11:06 am

Re: [RC] National Flags

Post by sp3ctre »

Interesting, the composer.json I installed says the following:

Code: Select all

"extra": {
		"display-name": "National Flags",
		"soft-require": {
			"phpbb/phpbb": ">=3.1.4,<3.2.*@dev"
		}
	}
Should that not install ok, or is the dependency on 3.1.6-RC1 mentioned somewhere else?

EDIT: I see now, it's listed in ext.php

Don't worry, I am installing onto my test board for the time being, the main site is still on 3.0. I just want to get all my ducks in a row before moving the main site to 3.1 :)
User avatar
Galixte de EzCom
Registered User
Posts: 1097
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] National Flags

Post by Galixte de EzCom »

Hi,

on top of the main page on GitHub and in the first post of this topic the version 3.1.4-RC1 is mentionned too.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.2.x & 3.3.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
RMcGirr83
Former Team Member
Posts: 21823
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC] National Flags

Post by RMcGirr83 »

And is the version that was submitted to the database. Just use the zip I provided a few posts above.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
draky
Registered User
Posts: 250
Joined: Tue Dec 10, 2002 2:04 pm
Location: France
Name: Gilles W.
Contact:

Re: [RC] National Flags

Post by draky »

Is it possible to disable (with an option in EXT admin tab) the display of flags at the bottom of index ?
User avatar
supanet
Registered User
Posts: 244
Joined: Sat Dec 15, 2012 4:20 pm
Location: UK
Contact:

Re: [RC] National Flags

Post by supanet »

draky wrote:Is it possible to disable (with an option in EXT admin tab) the display of flags at the bottom of index ?
I asked this in an earlier post and was told to do this:
Delete the html file from the extensions styles folder....otherwise known as index_body_forumlist_body_after
Hope that helps. ;)
User avatar
draky
Registered User
Posts: 250
Joined: Tue Dec 10, 2002 2:04 pm
Location: France
Name: Gilles W.
Contact:

Re: [RC] National Flags

Post by draky »

Thanks :)
User avatar
RMcGirr83
Former Team Member
Posts: 21823
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC] National Flags

Post by RMcGirr83 »

The queries will still run that produce the html. You will also want to remove/comment some lines from the listener file. Namely this one

https://github.com/RMcGirr83/phpBB-3.1- ... r.php#L123
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
2600
I've Been Banned!
Posts: 2567
Joined: Fri Nov 14, 2014 5:14 pm
Location: Area-51

Re: [RC] National Flags

Post by 2600 »

I'm using fade header. When I click a flag at the bottom of my forum the header is white and cycles to nothing but white. The link is app.php so not sure if that's the issue or not.

Also, I have an ext that shows 404's and I see a lot og 404's to this path: /flags/images/banner4.jpg /flags/images/banner1.jpg /flags/images/banner2.jpg, etc.


So I placed an images folder in flags and copied my banners to it, but that didn't solve the problem.
Morpheus: Unfortunately, no one can be told what The Matrix is. You'll have to see it for yourself.
Hack me.
Consider a canary token.
The nature of my chosen username
:ugeek:
User avatar
2600
I've Been Banned!
Posts: 2567
Joined: Fri Nov 14, 2014 5:14 pm
Location: Area-51

Re: [RC] National Flags

Post by 2600 »

RMcGirr83 wrote:The queries will still run that produce the html. You will also want to remove/comment some lines from the listener file. Namely this one

https://github.com/RMcGirr83/phpBB-3.1- ... r.php#L123

Thinking about pulling the flags from the bottom. So I comment out this line?

'core.index_modify_page_title' => 'index_modify_page_title',
Morpheus: Unfortunately, no one can be told what The Matrix is. You'll have to see it for yourself.
Hack me.
Consider a canary token.
The nature of my chosen username
:ugeek:
User avatar
donsenilo
Registered User
Posts: 306
Joined: Wed Oct 08, 2014 6:23 pm
Name: Markus
Contact:

Re: No * as Required field

Post by donsenilo »

RMcGirr83 wrote:
donsenilo wrote:Hi

When it is selected as required field there is no *

It's important for users to know that this is a required field.
Minutia, if they don't choose a flag then an error message is displayed. This isn't a profile field.
So ... I got it.
And btw. RMcGirr83 ... this is your extension ("Everyone is free to take the code and modify it as they see fit."). A little bit more understanding and work would be very helpful.
Locked

Return to “Extensions in Development”