Page 14 of 18

Re: [RC] National Flags

Posted: Sun Jul 12, 2015 11:04 am
by John connor
Where did you get your flags? I added a NATO flag, but it doesn't look as crisp as the default flags. Is there a good NATO flag? :lol:

Also, I notice in PMs that flags don't show up.

Re: [RC] National Flags

Posted: Sun Jul 12, 2015 11:28 am
by RMcGirr83
John connor wrote:Also, I notice in PMs that flags don't show up.
You're right they don't because the extension isn't built for them to display when viewing PM's.

Re: [RC] National Flags

Posted: Sun Jul 12, 2015 11:30 am
by John connor
Ok.

Re: [RC] National Flags

Posted: Mon Jul 20, 2015 3:33 pm
by sp3ctre
I might be missing something obvious, but I'm getting an error when I try to enable the extension:

Code: Select all

The selected extension cannot be enabled, please verify the extension’s requirements.
My phpbb version is 3.1.5 and PHP version is 5.4.34

Is there some other dependency I am missing?

Re: [RC] National Flags

Posted: Mon Jul 20, 2015 3:59 pm
by RMcGirr83
The extension on github now requires version 3.1.6-RC1 of phpBB as new events that the version in github uses are now in the core of phpBB dev

https://github.com/phpbb/phpbb/pull/3755

You can use this one which is the one sitting in the validation queue and should install and work fine on your 3.1.5 forum.

Saying that you shouldn't be installing any un-validated extension on a live forum but choice is yours.

Re: [RC] National Flags

Posted: Mon Jul 20, 2015 4:04 pm
by sp3ctre
Interesting, the composer.json I installed says the following:

Code: Select all

"extra": {
		"display-name": "National Flags",
		"soft-require": {
			"phpbb/phpbb": ">=3.1.4,<3.2.*@dev"
		}
	}
Should that not install ok, or is the dependency on 3.1.6-RC1 mentioned somewhere else?

EDIT: I see now, it's listed in ext.php

Don't worry, I am installing onto my test board for the time being, the main site is still on 3.0. I just want to get all my ducks in a row before moving the main site to 3.1 :)

Re: [RC] National Flags

Posted: Mon Jul 20, 2015 11:45 pm
by Galixte de EzCom
Hi,

on top of the main page on GitHub and in the first post of this topic the version 3.1.4-RC1 is mentionned too.

Re: [RC] National Flags

Posted: Tue Jul 21, 2015 1:10 am
by RMcGirr83
And is the version that was submitted to the database. Just use the zip I provided a few posts above.

Re: [RC] National Flags

Posted: Wed Jul 22, 2015 7:00 am
by draky
Is it possible to disable (with an option in EXT admin tab) the display of flags at the bottom of index ?

Re: [RC] National Flags

Posted: Thu Jul 23, 2015 8:34 am
by supanet
draky wrote:Is it possible to disable (with an option in EXT admin tab) the display of flags at the bottom of index ?
I asked this in an earlier post and was told to do this:
Delete the html file from the extensions styles folder....otherwise known as index_body_forumlist_body_after
Hope that helps. ;)

Re: [RC] National Flags

Posted: Thu Jul 23, 2015 1:51 pm
by draky
Thanks :)

Re: [RC] National Flags

Posted: Thu Jul 23, 2015 1:55 pm
by RMcGirr83
The queries will still run that produce the html. You will also want to remove/comment some lines from the listener file. Namely this one

https://github.com/RMcGirr83/phpBB-3.1- ... r.php#L123

Re: [RC] National Flags

Posted: Sat Jul 25, 2015 8:59 pm
by John connor
I'm using fade header. When I click a flag at the bottom of my forum the header is white and cycles to nothing but white. The link is app.php so not sure if that's the issue or not.

Also, I have an ext that shows 404's and I see a lot og 404's to this path: /flags/images/banner4.jpg /flags/images/banner1.jpg /flags/images/banner2.jpg, etc.


So I placed an images folder in flags and copied my banners to it, but that didn't solve the problem.

Re: [RC] National Flags

Posted: Sat Jul 25, 2015 9:02 pm
by John connor
RMcGirr83 wrote:The queries will still run that produce the html. You will also want to remove/comment some lines from the listener file. Namely this one

https://github.com/RMcGirr83/phpBB-3.1- ... r.php#L123

Thinking about pulling the flags from the bottom. So I comment out this line?

'core.index_modify_page_title' => 'index_modify_page_title',

Re: No * as Required field

Posted: Sun Jul 26, 2015 1:03 am
by donsenilo
RMcGirr83 wrote:
donsenilo wrote:Hi

When it is selected as required field there is no *

It's important for users to know that this is a required field.
Minutia, if they don't choose a flag then an error message is displayed. This isn't a profile field.
So ... I got it.
And btw. RMcGirr83 ... this is your extension ("Everyone is free to take the code and modify it as they see fit."). A little bit more understanding and work would be very helpful.