[CDB] National Flags

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
RMcGirr83
Former Team Member
Posts: 21679
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC] National Flags

Post by RMcGirr83 »

null2 wrote:
HeinrichP wrote:is it posible to hide the flags (+membelist) from guests?
+1

======

I solved that changing file ext/rmcgirr83/nationalflags/styles/prosilver/template/event/index_body_forumlist_body_after.html to:

Code: Select all

<!-- IF S_USER_LOGGED_IN --><!-- IF S_FLAGS -->
	<!-- INCLUDE index_flags.html -->
<!-- ENDIF --><!-- ENDIF -->
Can simply be

Code: Select all

<!-- IF S_USER_LOGGED_IN and S_FLAGS -->
	<!-- INCLUDE index_flags.html -->
<!-- ENDIF -->
but that will only affect the index. Won't have any affect of someone clicking on a flag in viewtopic and it won't stop the queries on index from running.

Question as to why still hasn't been answered.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
HeinrichP
Registered User
Posts: 28
Joined: Wed Oct 14, 2015 8:15 pm

Re: [RC] National Flags

Post by HeinrichP »

thank you very much null2 and RMcGirr83, this works fine!!
Question as to why still hasn't been answered.
now guests not logged in cannot see flags or memberlist clicking on the flags,
big thanks!
User avatar
RMcGirr83
Former Team Member
Posts: 21679
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC] National Flags

Post by RMcGirr83 »

But they can still see them by clicking on the flag for a user in a topic.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
HeinrichP
Registered User
Posts: 28
Joined: Wed Oct 14, 2015 8:15 pm

Re: [RC] National Flags

Post by HeinrichP »

yes, once logged in, and that is fine
User avatar
RMcGirr83
Former Team Member
Posts: 21679
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC] National Flags

Post by RMcGirr83 »

:roll:

Okay I give up, here's a pic of a user browsing the forum without being logged on. Let me be as specific as possible

Image

IF ONE CLICKS ON THE FLAG, YOU ARE TAKEN TO THE LIST OF USERS OF THAT FLAG WITHOUT BEING LOGGED IN AND THE USER CAN THEN VIEW ALL THE FLAGS CHOSEN BY USERS BY SIMPLY REMOVING THE /ID_OF_FLAG.

No one has ever responded to why they would want to hide the list of flags from unregistered users so, to me, it is now a non-issue.

You would think I was speaking some form of martian or something. :twisted:
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
null2
Registered User
Posts: 510
Joined: Wed Jan 20, 2010 11:03 am

Re: [RC] National Flags

Post by null2 »

RMcGirr83 wrote:Can simply be

Code: Select all

<!-- IF S_USER_LOGGED_IN and S_FLAGS -->
	<!-- INCLUDE index_flags.html -->
<!-- ENDIF -->
First time, I tried in this way but for some weird reason, it broke prosilver style. So, I did in an ugly way.

I think I did a mistake which I couldnt see.

=========

ANSWER TO "WHY": I just wanted to block in index because only logged in users can access my entire forum. There is no reason to let them see this statistic as a guest.
Sorry for my bad english. I'm from USA.
User avatar
RMcGirr83
Former Team Member
Posts: 21679
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC] National Flags

Post by RMcGirr83 »

null2 wrote: ANSWER TO "WHY": I just wanted to block in index because only logged in users can access my entire forum. There is no reason to let them see this statistic as a guest.
That might have been nice to know to begin with. They can still get to the flags with, eg

Code: Select all

http://mysite.com/flags
But if you're happy then who am I to argue.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
null2
Registered User
Posts: 510
Joined: Wed Jan 20, 2010 11:03 am

Re: [RC] National Flags

Post by null2 »

RMcGirr83 wrote:That might have been nice to know to begin with. They can still get to the flags with, eg

Code: Select all

http://mysite.com/flags
But if you're happy then who am I to argue.
Now, guests cant see flag statistics. Only after login.
Sorry for my bad english. I'm from USA.
HeinrichP
Registered User
Posts: 28
Joined: Wed Oct 14, 2015 8:15 pm

Re: [RC] National Flags

Post by HeinrichP »

now I see what you mean RMcGirr83, with

Code: Select all

http://mysite.com/flags
I can still see flags + memberlist, without logged in .... :shock:
User avatar
RMcGirr83
Former Team Member
Posts: 21679
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC] National Flags

Post by RMcGirr83 »

Exactly
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
Galixte de EzCom
Registered User
Posts: 1090
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] National Flags

Post by Galixte de EzCom »

Hi,
HeinrichP wrote:now I see what you mean RMcGirr83, with

Code: Select all

http://mysite.com/flags
I can still see flags + memberlist, without logged in .... :shock:

You can do this changes: https://github.com/RMcGirr83/phpBB-3.1- ... l/11/files.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.2.x & 3.3.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
User avatar
RMcGirr83
Former Team Member
Posts: 21679
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [RC] National Flags

Post by RMcGirr83 »

Won't stop the queries from still running but whatever. No one has stated why they don't want guests to see the list so seems to be a non-issue with me.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
Galixte de EzCom
Registered User
Posts: 1090
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] National Flags

Post by Galixte de EzCom »

RMcGirr83 wrote:Won't stop the queries from still running but whatever. No one has stated why they don't want guests to see the list so seems to be a non-issue with me.
You can replace those changes with new permissions, but it seems you don’t want to improve this: https://github.com/RMcGirr83/phpBB-3.1- ... -147181268.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.2.x & 3.3.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.
Holger
Registered User
Posts: 1843
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [RC] National Flags

Post by Holger »

Rich, in some parts of the world you maybe dont want to show where you are from openly.
Might be a reason for the request.
User avatar
null2
Registered User
Posts: 510
Joined: Wed Jan 20, 2010 11:03 am

Re: [RC] National Flags

Post by null2 »

I dont care if guests type http://mysite.com/flags. Usually, they dont know this address.

Usually, guests go to index page to log in. In this page, its not necessary to show flags statistics to them.

Its an user preference, so, its not mandatory to have this feature as an option in extension. If we have an option, ok, if not, ok too because we will modify it.
Sorry for my bad english. I'm from USA.
Locked

Return to “Extensions in Development”