Page 18 of 18

Re: [RC] National Flags

Posted: Fri Oct 16, 2015 3:30 pm
by RMcGirr83
Galixte de EzCom wrote:You can replace those changes with new permissions, but it seems you don’t want to improve this: https://github.com/RMcGirr83/phpBB-3.1- ... -147181268.
That PR is not a "permission" based PR. It is simply disallowing the viewing of the flags for guests and bots still doesn't stop the queries from running.
null2 wrote:Usually, guests go to index page to log in. In this page, its not necessary to show flags statistics to them.
The extension allows to not show the flags on the index page.

Once this extension gets validated I may consider disallowing guests to view the flags BUT it would seem to not really be worth it. Even if guests know one's location, countries are, usually pretty large so quite impossible for them to be able to do anything with it. I have mine set to US I highly doubt anyone would be able to determine where in the US I am located based off of that. I highly doubt if I will include a completely new permission.

Re: [RC] National Flags

Posted: Sun Oct 18, 2015 11:29 am
by RMcGirr83
Added a new config entry to allow the flags to be displayed to guests and bots or not. https://github.com/RMcGirr83/phpBB-3.1- ... 89b3239dbc

Re: [RC] National Flags

Posted: Sun Oct 18, 2015 2:13 pm
by HeinrichP
? WOW ..., great RMcGirr83, thank you very much!!

Re: [RC] National Flags

Posted: Sun Oct 18, 2015 7:01 pm
by Galixte de EzCom
Thanks to have added this option.

Re: [RC] National Flags

Posted: Mon Oct 19, 2015 7:26 am
by Holger
RMcGirr83 wrote:Once this extension gets validated I may consider disallowing guests to view the flags BUT it would seem to not really be worth it. Even if guests know one's location, countries are, usually pretty large so quite impossible for them to be able to do anything with it. I have mine set to US I highly doubt anyone would be able to determine where in the US I am located based off of that. I highly doubt if I will include a completely new permission.
In some parts of the world you might get "bullied" based on what country you come from. The part of the country does not matter.

Re: [RC] National Flags

Posted: Mon Oct 19, 2015 10:40 pm
by null2
Translation to Portuguese-Brazil: https://www.sendspace.com/file/ftzuct

Translation to Spanish: https://www.sendspace.com/file/zgsz9h

Re: [RC] National Flags

Posted: Tue Oct 20, 2015 10:32 am
by RMcGirr83
Holger wrote:In some parts of the world you might get "bullied" based on what country you come from. The part of the country does not matter.
And how, exactly, would a guest or a bot "bully" someone?

Re: [RC] National Flags

Posted: Tue Oct 20, 2015 11:58 am
by Holger
Oh, there are many ways ... if you really want to.
But this was just a thought from me about why someone might not want to show the flags for guests.

Re: [RC] National Flags

Posted: Wed Oct 21, 2015 8:01 pm
by eeji
wow, so much negativity in this topic! I thought I'd just post and say 'thank you', I just added this extension to my test site (3.1.6) and it works perfectly. Looking forward to seeing it validated, then its going on my live site :)

Re: [RC] National Flags

Posted: Thu Oct 22, 2015 1:51 am
by RMcGirr83
eeji wrote:wow, so much negativity in this topic! I thought I'd just post and say 'thank you', I just added this extension to my test site (3.1.6) and it works perfectly. Looking forward to seeing it validated, then its going on my live site :)
Thank you for the kind words. :)

Re: [CDB] National Flags

Posted: Wed Dec 02, 2015 11:50 am
by RMcGirr83
Extension has been validated and released. https://www.phpbb.com/customise/db/exte ... nal_flags/