[CDB] Topic Solved

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Suggested Hosts
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Clubkop
Registered User
Posts: 11
Joined: Sun Jan 11, 2015 5:27 pm

Re: [BETA] Topic Solved

Post by Clubkop »

Nice extension, thanks!

I have a problem using it...

When I want to mark a topic as solved, the URL goes to:

http://www.myforum.com/topicsolved/mark/solved/25


and that path is not found....
User avatar
bpetty
Registered User
Posts: 124
Joined: Thu Jan 08, 2015 5:35 am
Name: Bryan Petty

Re: [BETA] Topic Solved

Post by bpetty »

Clubkop wrote:http://www.myforum.com/topicsolved/mark/solved/25
That's odd, phpBB is supposed to automatically route that to "/app.php/topicsolved/..." if that's the way your forums are configured. I'm pretty sure this is the way extensions are supposed to generate links (and it seems to work for others this way):

Code: Select all

	return $this->helper->route('tierra_topicsolved_controller_mark',
		array(
			'solve' => 'solved',
			'post_id' => (int) $post_id,
		)
	);
Obviously it's finding the route correctly since the rest of it formed appropriately:

Code: Select all

tierra_topicsolved_controller_mark:
    path: /topicsolved/mark/{solve}/{post_id}
    defaults: { _controller: tierra.topicsolved.controller:mark }
    requirements:
        solve: solved|unsolved
        post_id: \d+
The docs are pretty clear about this.

With the way it generated the link for you, I would have guessed that you were experimenting with some short URL configuration that you never finished setting up correctly yet. I'm not really sure what might be wrong.
Clubkop
Registered User
Posts: 11
Joined: Sun Jan 11, 2015 5:27 pm

Re: [BETA] Topic Solved

Post by Clubkop »

Thanks, it is working now :)
Option URL Rewrite was on, now it is off and it works perfect :)
Korkel
Registered User
Posts: 391
Joined: Mon Jun 02, 2014 7:09 am
Location: ~/home/Liz/Desktop
Name: Liz Aalderink
Contact:

Re: [BETA] Topic Solved

Post by Korkel »

This is a great addon, when it's ready going to use it.
"If you lose your left arm, your right arm will be left."
“The most important property of a program is whether it accomplishes the intention of its user.”
Image
User avatar
uruguayito
Registered User
Posts: 266
Joined: Mon Dec 13, 2010 2:46 pm
Location: Montevideo - Uruguay

Re: [BETA] Topic Solved

Post by uruguayito »

nice ext.
thanks
I speak spanish
Sorry for my bad english
BF79
Registered User
Posts: 416
Joined: Fri Feb 13, 2015 1:28 pm
Name: Fouad B

Re: [BETA] Topic Solved

Post by BF79 »

bpetty wrote:
Komanche wrote:Emm but it seem I cannot get to working state, I had enabled, clear cache, but I don't see options in ACP to enable it...
Under any "Edit forum" page, as long as the forum type is "Forum" (and not "Category" or "Link"), you should see "Topic solved settings" at the bottom.

I haven't tried to enable the extension on pre-3.1.3 boards, but it should prevent you from enabling the extension on anything older than 3.1.3 as well.
under edit forum but I found nothing... plz need help.. !

thanks
User avatar
bpetty
Registered User
Posts: 124
Joined: Thu Jan 08, 2015 5:35 am
Name: Bryan Petty

Re: [BETA] Topic Solved

Post by bpetty »

BF79 wrote:under edit forum but I found nothing... plz need help.. !
What steps have you completed in order to install and enable the extension? Does it show as enabled in your list of extensions?
BF79
Registered User
Posts: 416
Joined: Fri Feb 13, 2015 1:28 pm
Name: Fouad B

Re: [BETA] Topic Solved

Post by BF79 »

The extension is corectly installed as all other .. in ext...
but it's not show in extension list to be enabled !!!
User avatar
bpetty
Registered User
Posts: 124
Joined: Thu Jan 08, 2015 5:35 am
Name: Bryan Petty

Re: [BETA] Topic Solved

Post by bpetty »

BF79 wrote:The extension is corectly installed as all other .. in ext...
but it's not show in extension list to be enabled !!!
Do you have it copied into the "phpBB/ext/tierra/topicsolved" folder? This is where the extension files should be.
User avatar
Geronimoz
Registered User
Posts: 27
Joined: Wed Jan 28, 2015 5:57 pm
Location: Toulouse (France)
Contact:

Re: [BETA] Topic Solved

Post by Geronimoz »

Hi there,

I have installed & activated the extension, I try to see the button but it does not appear...

First, I have already activated the rules for the forum which will need it, but no way, whatever options I apply, it stays hidden.
I don't understand what I missed, I've done everything correctly as it's explained here and on github, but no way.

Maybe it's cause of the style I use, because it has an effect to hide buttons and make them appears only when mouse a.hover the post.
So I tried to add the style folder in ext/tierra/topicsolved/style, with the same files witch are in the prosilver folder (it's a prosilver based style), but always nothing.
The base style is the pbtech, by Paybas. Lots of modifications but none on the post buttons.

I'm a bit lost for now after hours to find the good thing.
I hope you may help me.
Forum isn't "open" for now, so if you need to see it, I'll send you the url by PM ;)

Thanks a lot in advance for answer to come :)

Have a nice day/evening/night
Geronimo(z)
"Nothing is not inside nothing"
SCS MODS FR
User avatar
bpetty
Registered User
Posts: 124
Joined: Thu Jan 08, 2015 5:35 am
Name: Bryan Petty

Re: [BETA] Topic Solved

Post by bpetty »

Geronimoz wrote:Maybe it's cause of the style I use, because it has an effect to hide buttons and make them appears only when mouse a.hover the post.
It's because of PBTech, but not because of that mouse hover effect.

PBTech does actually make some very significant changes to the post buttons in order to switch them to use FontAwesome icons rather than the background image icons that prosilver uses. It does have the appropriate template events for almost everything. The buttons are actually there (you can see them in view source), and the CSS styles are being added correctly. PBTech is overwriting those CSS styles though in their custom styles. Just to get them to show again (and they still look out of place), I had to change buttons.css to use this code instead:

Code: Select all

.button.topicsolved-icon.icon-button:before,
.button.topicsolved-icon.dropdown-select:after {
	content: '';
	background: url("images/topicsolved_icons_button.png");
	height: 12px;
	width: 12px;
}
.button.topicsolved-icon.icon-button {
	box-sizing: content-box;
	padding: 0 5px;
	width: 12px;
	height: 18px;
}

.button.solve-icon:before          { background-position: -0px 0; }
.button.solve-icon:hover:before    { background-position: -0px -12px; }
.button.unsolve-icon:before        { background-position: -12px 0; }
.button.unsolve-icon:hover:before  { background-position: -12px -12px; }
Besides that though, PBTech does not output POST_SUBJECT content in threads, which Topic Solved relies on in order to append the solved indicator on the post that has been marked as the "solution". So while the topic correctly shows the solved indicator in the viewtopic and viewforum pages, and they link to the solution post in the thread, the post itself can't visibly be marked as the solution.

I'm really not sure how I can make the extension compatible with this style, sorry.
BF79
Registered User
Posts: 416
Joined: Fri Feb 13, 2015 1:28 pm
Name: Fouad B

Re: [BETA] Topic Solved

Post by BF79 »

bpetty wrote:
BF79 wrote:The extension is corectly installed as all other .. in ext...
but it's not show in extension list to be enabled !!!
Do you have it copied into the "phpBB/ext/tierra/topicsolved" folder? This is where the extension files should be.
no !! what is tierra ?

my is

public_html/ext/topicsolved-master
User avatar
Geronimoz
Registered User
Posts: 27
Joined: Wed Jan 28, 2015 5:57 pm
Location: Toulouse (France)
Contact:

Re: [BETA] Topic Solved

Post by Geronimoz »

Hi there

Thank you so much for your answer bpetty, I understand and so I think I'll wait & see if maybe an ext' like yours which could be compatible with PBtech would be released ^^
That's not a very big trouble, don't worry. ;)

Thanks for your job,
Have fun,

Geronimo(z)
"Nothing is not inside nothing"
SCS MODS FR
User avatar
bpetty
Registered User
Posts: 124
Joined: Thu Jan 08, 2015 5:35 am
Name: Bryan Petty

Re: [BETA] Topic Solved

Post by bpetty »

BF79 wrote:no !! what is tierra ?

my is public_html/ext/topicsolved-master
Please follow the directions for installing the extension:
https://github.com/tierra/topicsolved#quick-install

phpBB is very specific about where extensions need to be installed. Just rename the "topicsolved-master" folder to "topicsolved", and move it into an empty directory called "tierra".
User avatar
bpetty
Registered User
Posts: 124
Joined: Thu Jan 08, 2015 5:35 am
Name: Bryan Petty

Re: [BETA] Topic Solved

Post by bpetty »

Geronimoz wrote:Thank you so much for your answer bpetty, I understand and so I think I'll wait & see if maybe an ext' like yours which could be compatible with PBtech would be released ^^
The PBTech guys might have some good ideas for how to make this extension compatible without changing code for other prosilver-based styles. It sounds like they've validated lots of other extensions. I'm still new to extension development. So not all hope is lost, I'll keep an eye out for how to handle PBTech styles.
Locked

Return to “Extensions in Development”