[CDB] Navbar Search

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

Re: [RC] Navbar Search

Post by javiexin » Sat Mar 28, 2015 2:24 am

javiexin wrote:One behaviour that I do not like is the one of the breadcrumbs when both extensions are used at the same time and the window is narrow (but not as much as to make responsive take over). There is something, probably in some JS file, that is not interacting correctly with these extensions...
Image
Arty has found that this odd behaviour is caused by a bug in the core of phpbb. Thanks!!
Arty wrote:Its a bug in forum_fn.js. Code checks all links, including hidden links.

Find

Code: Select all

			$right.each(function() {
				width += $(this).outerWidth(true);
			});
replace with

Code: Select all

			$right.each(function() {
				if ($(this).is(':visible')) {
					width += $(this).outerWidth(true);
				}
			});

User avatar
Mick
Support Team Member
Support Team Member
Posts: 21577
Joined: Fri Aug 29, 2008 9:49 am
Location: Caerdydd

Re: [RC] Navbar Search

Post by Mick » Sat Mar 28, 2015 4:41 pm

javiexin wrote:Arty has found that this odd behaviour is caused by a bug in the core of phpbb
Care to share?
"The more connected we get the more alone we become" - Kyle Broflovski

User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

Re: [RC] Navbar Search

Post by javiexin » Sat Mar 28, 2015 4:59 pm

Mick wrote:
javiexin wrote:Arty has found that this odd behaviour is caused by a bug in the core of phpbb
Care to share?
Please, do read my post... The complete quote of Arty's message is included, with the fix as well.

Anyhow, after I posted this, Arty has made a better fix, and is now on GitHub:
https://github.com/phpbb/phpbb/commit/9 ... e3d7feaf0e

And after that, we found another bug, that again, Arty fixed.
viewtopic.php?p=14019216#p14019216

If you want to see the full thread with the discussions, you may find it here:
viewtopic.php?f=481&t=2306956

Regards,
-javiexin

User avatar
Raul [ThE KuKa]
Style Customisations
Style Customisations
Posts: 6525
Joined: Mon Dec 08, 2003 9:24 pm
Location: Spain
Name: Raul Arroyo
Contact:

Re: [RC] Navbar Search

Post by Raul [ThE KuKa] » Sat Mar 28, 2015 5:01 pm

All unsolicited PMs will be ignored.
:warning: Knowledge Base | Documentation | Board rules | phpBB Styles Rules & Policies :warning:


If you like my styles, translations, etc. and want to show some appreciation, then feel free to Donate with Image
:flag_es: phpBB Spain - Online Since 2003 :heart:



User avatar
Mick
Support Team Member
Support Team Member
Posts: 21577
Joined: Fri Aug 29, 2008 9:49 am
Location: Caerdydd

Re: [RC] Navbar Search

Post by Mick » Sat Mar 28, 2015 5:12 pm

Thank you, forgive my myopia.
"The more connected we get the more alone we become" - Kyle Broflovski

User avatar
Dragosvr92
Registered User
Posts: 1450
Joined: Sat Sep 12, 2009 7:27 am
Location: Romania
Name: Dragos Valentin Rădulescu
Contact:

Re: [RC] Navbar Search

Post by Dragosvr92 » Mon Apr 06, 2015 10:10 am

Line 188, Column 18: Element “div” not allowed as child of element “ul” in this context. (Suppressing further errors from this subtree.)
Changing the div into a li and adding float:right; appears to fix the error. ;)

Code: Select all

<li id="search-box" class="search-box search-header" style="float:right;margin-top:5px;box-shadow:none"> 
Formerly known as TheKiller
3.0| Avatar on Memberlist 1.0.3

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 4016
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [CDB] Navbar Search

Post by HiFiKabin » Wed Apr 15, 2015 8:37 am

To celebrate my Extension being validated I'll have a little dance.

Image

CDB Topic

Locked

Return to “Extensions in Development”