[CDB][Official Extension] Collapsible Forum Categories

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by Volksdevil » Fri Apr 24, 2015 8:43 pm

Ah, yes I hardcoded them which you said was fine to do here viewtopic.php?f=461&t=2302531 because I use cloudflare...

No worries, it seems I'll just have to do without the extension.
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 4882
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by VSE » Fri Apr 24, 2015 8:48 pm

Volksdevil wrote:Ah, yes I hardcoded them which you said was fine to do here viewtopic.php?f=461&t=2302531 because I use cloudflare...

No worries, it seems I'll just have to do without the extension.
You should fix your template. You are missing vital template events, and code is being added incorrectly. You will simply continue to have issues with extensions.
Dictated but not read.
Official phpBB Extensions My Extensions & MODs
Please do not PM me for support.

User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by Volksdevil » Fri Apr 24, 2015 8:55 pm

I haven't removed any template events iirc, I've been very careful to make sure I haven't moved or removed any. All other extensions work perfectly fine...

Edit: Yep, my overall_footer.html has everything there, all in the same order as the github link you posted.
VSE wrote: These lines are critical: https://github.com/phpbb/phpbb/blob/3.1 ... ml#L40-L49
Maybe it's a clash with another extension?
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 4882
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by VSE » Fri Apr 24, 2015 9:37 pm

Volksdevil wrote:I haven't removed any template events iirc, I've been very careful to make sure I haven't moved or removed any. All other extensions work perfectly fine...

Edit: Yep, my overall_footer.html has everything there, all in the same order as the github link you posted.
VSE wrote: These lines are critical: https://github.com/phpbb/phpbb/blob/3.1 ... ml#L40-L49
Maybe it's a clash with another extension?
No, your template is very much incorrect: http://pastebin.com/z1Cz1Fag

Missing 6 template events, missing all template logic conditionals and of course incorrectly hardcoding in javascript assets.
Dictated but not read.
Official phpBB Extensions My Extensions & MODs
Please do not PM me for support.

User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by Volksdevil » Fri Apr 24, 2015 10:03 pm

I'm not sure how you are seeing that Matt, but that's not what I have on the server...As you can see, all template events are there (6) total, and they are working pulling in HTML etc before and after them.

This is my actual overall_footer.html

Code: Select all

		<!-- EVENT overall_footer_content_after -->
	</div>

<!-- EVENT overall_footer_page_body_after -->

<div id="page-footer">
	<!-- INCLUDE navbar_footer.html -->

	<div class="copyright">
		<!-- EVENT overall_footer_copyright_prepend -->
		<!-- IF TRANSLATION_INFO --><br />{TRANSLATION_INFO}<!-- ENDIF -->
		<!-- EVENT overall_footer_copyright_append -->
		<!-- IF DEBUG_OUTPUT --><br />{DEBUG_OUTPUT}<!-- ENDIF -->
<!-- IF SCRIPT_NAME eq 'index' --><p><strong>Volkswagen Corrado G60 Forum</strong>. Community of the G60 Supercharged variant <strong>Vw Corrado</strong>. Corrado VR6, 8V, 16V Owners Welcome. Advice, Buyers Guide, Classifieds, Gallery, History, Owners Register and Reviews.</p>

<p>Our <strong>Corrado G60 History</strong> page details the birth of the Vw G60 powered coupe from Germany, along with specification, BHP performance figures and factory <strong>Corrado G60 Wheels</strong>. Furthermore we have details on the rare <strong>Volkswagen Motorsport Corrado 16v g60</strong> and the <strong>Corrado G60 Jet</strong>, a model only sold in Germany. You can find Corrado G60 cars and parts for sale in the <strong>Classifieds</strong> and to help keep your Corrado in good mechanical condition the <strong>Guides</strong> and <strong>Technical Help</strong> forums will be of interest.<!-- <br />Featured at <a href="http://www.ukmotoringdirectory.co.uk/car-clubs?id=344" target="_blank">Clubs & Forums Interactive UK Motoring Directory</a> --></p>

<p class="no-margin-bottom">Not affiliated with or endorsed by Volkswagen AG, Volkswagen UK, Volkswagen of America, Inc<br /><strong>Volkswagen Corrado G60 Forum</strong> &copy; to and owned by Neil Riley | <a href="http://www.corradog60.com/sitemap.xml">Sitemap</a></p><!-- ENDIF --><!-- IF SCRIPT_NAME eq 'viewforum' --><!-- <p class="no-margin-bottom"><strong><h3><a href="{U_CANONICAL}" title="{FORUM_NAME}">{FORUM_DESC}</a></h3></strong></p> --><!-- ENDIF -->

<!-- IF U_ACP --><br /><strong><a href="{U_ACP}">{L_ACP}</a></strong> | <a rel="nofollow" href="http://www.phpbb.com/community" target="_blank">PHPBB</a> | <a rel="nofollow" href="http://www.corradog60.com/viewtopic.php?f=33&t=314" target="_blank">ZBBLOCK</a><br /><!-- ENDIF -->
</div>

<div id="darkenwrapper" data-ajax-error-title="{L_AJAX_ERROR_TITLE}" data-ajax-error-text="{L_AJAX_ERROR_TEXT}" data-ajax-error-text-abort="{L_AJAX_ERROR_TEXT_ABORT}" data-ajax-error-text-timeout="{L_AJAX_ERROR_TEXT_TIMEOUT}" data-ajax-error-text-parsererror="{L_AJAX_ERROR_TEXT_PARSERERROR}">
<div id="darken">&nbsp;</div>
</div>
<div id="loading_indicator"></div>

<div id="phpbb_alert" class="phpbb_alert" data-l-err="{L_ERROR}" data-l-timeout-processing-req="{L_TIMEOUT_PROCESSING_REQ}">
<a href="#" class="alert_close"></a>
<h3 class="alert_title">&nbsp;</h3><p class="alert_text"></p>
</div>
<div id="phpbb_confirm" class="phpbb_alert">
<a href="#" class="alert_close"></a>
<div class="alert_text"></div>
</div>
</div>
</div>
<!-- IF SCRIPT_NAME eq 'index' --><p>&nbsp;</p><span class="mobile-codeshare"><style type ="text/css">.kualo{text-align:center;color:#FFF}</style><p class="kualo">
UK Links: <a href="https://www.gov.uk/vehicle-tax" title="Car Tax Online" target="_blank" rel="nofollow">Car Tax Online</a> | <a href="https://www.gov.uk/vehicle-tax-refund" title="Car Tax Refund" target="_blank" rel="nofollow">Car Tax Refund</a> | <a href="https://www.gov.uk/make-a-sorn" title="Declare SORN Online" target="_blank" rel="nofollow">Declare SORN Online</a> | <a href="https://www.gov.uk/check-mot-status" title="Check MOT Status" target="_blank" rel="nofollow">Check MOT Status</a> | <a href="https://www.gov.uk/check-mot-history-vehicle" title="Check MOT History" target="_blank" rel="nofollow">Check MOT History</a> | <a href="https://www.vehicleenquiry.service.gov.uk/" title="Vehicle Enquiry" target="_blank" rel="nofollow">Vehicle Enquiry</a> | <a href="https://www.howmanyleft.co.uk/vehicle/volkswagen_corrado_g60" title="How Many Left" target="_blank" rel="nofollow">How Many Left</a></p>
<p class="kualo">Gladly hosted with <a href="http://my.kualo.com/uk/go/00657/webhosting" title="Kualo Web Hosting" target="_blank" rel="nofollow">Kualo Web Hosting</a></p></span><!-- ENDIF --><p class="no-margin-bottom">&nbsp;</p>

<!-- IF not S_IS_BOT --><!-- <span style="color:#FFF;/*text-align:center;background:#000;padding:3px;border-radius: 5px;border:1px solid #f00;*/">The Corrado G60 Forum is gladly hosted with <a rel="nofollow" target="_blank" href="http://my.kualo.com/uk/go/00657/webhosting">Kualo</a></span> --><!-- ENDIF -->

<div>
<a id="bottom" class="anchor" accesskey="z"></a>
<!-- IF not S_IS_BOT -->{RUN_CRON_TASK}<!-- ENDIF -->
</div>
<!-- IF SCRIPT_NAME eq 'index' or SCRIPT_NAME eq 'viewtopic' or $CURRENT_PAGE == 'buyguide' or $CURRENT_PAGE == 'history' or $CURRENT_PAGE == 'history-16vg60' or $CURRENT_PAGE == 'history-jet' or $CURRENT_PAGE == 'history-wheels' or $CURRENT_PAGE == 'register' or $CURRENT_PAGE == 'calc' or $CURRENT_PAGE == 'classifieds' or $CURRENT_PAGE == 'instagram' or $CURRENT_PAGE == 'discussion' or $CURRENT_PAGE == 'technical' or $CURRENT_PAGE == 'downloads' or $CURRENT_PAGE == 'wiki' --><span class="showSocialButtons"><i class="fa fa fa-share"></i> ShareThis</span><span class="socialShare"></span><!-- ENDIF -->

<script type="text/javascript" src="{T_JQUERY_LINK}"></script><!-- IF S_ALLOW_CDN --><script type="text/javascript">window.jQuery || document.write(unescape('%3Cscript src="{T_ASSETS_PATH}/javascript/jquery.min.js" type="text/javascript"%3E%3C/script%3E'));</script><!-- ENDIF --><script type="text/javascript" src="{T_ASSETS_PATH}/javascript/core.js"></script><script type="text/javascript" src="http://www.corradog60.com/styles/prosilver/template/forum_fn.js"></script>
<script type="text/javascript" src="http://www.corradog60.com/styles/prosilver/template/ajax.js"></script><!-- WASINCLUDEJS forum_fn.js --><!-- WASINCLUDEJS ajax.js --><!-- ?assets_version={T_ASSETS_VERSION} for jquerymin core fn ajax -->

<!-- EVENT overall_footer_after -->

<!-- IF S_PLUPLOAD --><!-- INCLUDE plupload.html --><!-- ENDIF -->
{$SCRIPTS}
<!-- EVENT overall_footer_body_after -->

<!-- INCLUDE overall_footer_scripts.html -->
</body>
</html>
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 4882
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by VSE » Fri Apr 24, 2015 10:09 pm

Volksdevil wrote:I'm not sure how you are seeing that Matt, but that's not what I have on the server...As you can see, all template events are there.

This is my actual overall_footer.html
The code I posted is the raw page source of your overall_footer.html template file. And I even modified your page source to use the corrected template structure as a test and your issue with this extension went from not working, to working.

What I posted is what is being served by your site and the reason why this extension is being broken for you.

Here it is again, shown by an online tool: http://www.iwebtool.com/code_viewer?dom ... ooter.html

You can also use this tool to view it: http://www.generateit.net/seo-tools/source-viewer/
Dictated but not read.
Official phpBB Extensions My Extensions & MODs
Please do not PM me for support.

User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by Volksdevil » Fri Apr 24, 2015 10:31 pm

Weird. :? I just noticed that here at phpbb.com, viewing the raw source shows all the comments/conditionals...Whereas my site doesn't.

It's strange because they are definitely being parsed, as if you view the source of my site (Not raw but printed) then everything is there via the events and conditionals etc. And of course my template file does have them all, and in the correct order.

Edit: Found the cause...The cloudflare minification just removes comments from raw source, but it does still allow them to work/print.

Edit2: OK, the comments etc are now showing in my raw source, ext still isn't working though...
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 4882
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by VSE » Fri Apr 24, 2015 10:39 pm

Volksdevil wrote:It's strange because they are definitely being parsed, as if you view the source of my site (Not raw but printed) then everything is there via the events and conditionals etc. And of course my template file does have them all, and in the correct order.
That doesn't tell you anything. Viewing the source of a web page will show you the HTML after it has been rendered by PHP. We have been viewing the source of the raw (un-rendered) template file. As I've shown you your template files do not have much of the needed syntax so it is not being parsed by phpBB correctly. You have some variables in there which are, but the rest is just hardcoded stuff in your template file being passed straight through.

It's nothing weird, it's just the template file pushed out by your site is not what you think it is, for some reason.

So from this point, since your issue has nothing to do with this extension, if you need more support with fixing your style, please use the style support forums.
Dictated but not read.
Official phpBB Extensions My Extensions & MODs
Please do not PM me for support.

User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by Volksdevil » Fri Apr 24, 2015 10:46 pm

But as you can see by my edits above, my raw source does now show everything, and the extension still does not work.

Example: my raw source now shows the events etc http://www.iwebtool.com/code_viewer?dom ... ooter.html

Code: Select all

SNIP.....
<!-- EVENT overall_footer_after -->

<!-- IF S_PLUPLOAD --><!-- INCLUDE plupload.html --><!-- ENDIF -->
{$SCRIPTS}
<!-- EVENT overall_footer_body_after -->

<!-- INCLUDE overall_footer_scripts.html -->
</body>
</html>
I don't understand it, so like I said earlier I'll just leave it 'as is' with everything working just fine minus this extension.
Last edited by Volksdevil on Fri Apr 24, 2015 10:51 pm, edited 1 time in total.
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 4882
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by VSE » Fri Apr 24, 2015 10:48 pm

Volksdevil wrote:Edit2: OK, the comments etc are now showing in my raw source, ext still isn't working though...
As mentioned, the main problem you have with your style is you hardcoded the javascript assets, which are supposed to be included.

https://github.com/phpbb/phpbb/blob/3.1 ... ml#L43-L44
Dictated but not read.
Official phpBB Extensions My Extensions & MODs
Please do not PM me for support.

User avatar
Stoker 4.0
Registered User
Posts: 1483
Joined: Sun Feb 13, 2011 1:33 pm
Location: Funen, Denmark
Name: Ulrik Christensen
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by Stoker 4.0 » Sat Apr 25, 2015 4:25 am

Nice to see this using cookies :)
Will there be a guide how to include this on other stuff on index like welcome messages, chat etc.

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 4882
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by VSE » Sat Apr 25, 2015 6:15 am

Stoker 4.0 wrote:Will there be a guide how to include this on other stuff on index like welcome messages, chat etc.
Most likely, where it's possible, since this is based on forum categories, which have very specific template and core events and a specific structure relied upon by the Javascript magic. It'll work with your welcome ext, for example. But no info will be made available until this is released as there are still significant changes to be made to the way this extension is currently written.

We're targeting phpBB 3.1.5 for a release of this extension.
Dictated but not read.
Official phpBB Extensions My Extensions & MODs
Please do not PM me for support.

Korkel
Registered User
Posts: 391
Joined: Mon Jun 02, 2014 7:09 am
Location: ~/home/Liz/Desktop
Name: Liz Aalderink
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by Korkel » Sat Apr 25, 2015 8:21 am

VSE wrote:We're targeting phpBB 3.1.5 for a release of this extension.
That will take a long time I think.

What means ALPHA?
"If you lose your left arm, your right arm will be left."
“The most important property of a program is whether it accomplishes the intention of its user.”
Image

Holger
Registered User
Posts: 1748
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [ALPHA] Collapsible Forum Categories

Post by Holger » Sat Apr 25, 2015 10:02 am

Very nice! When logged in it does use the DB?! What happens if several members keep clicking the +/-? Is there some kind of delay or does it manipulate the DB immideately? Can it cause problems when I have 500 users online clicking the +/- at nearly the same time?

rxu
Extensions Development Team
Posts: 2945
Joined: Wed Oct 25, 2006 12:46 pm
Location: Siberia, Russian Federation
Name: Ruslan
Contact:

Re: [ALPHA] Collapsible Forum Categories

Post by rxu » Sat Apr 25, 2015 10:19 am

Korkel wrote:What means ALPHA?
http://en.wikipedia.org/wiki/Software_r ... ycle#Alpha
Holger wrote:When logged in it does use the DB?!
Yes.
Holger wrote:What happens if several members keep clicking the +/-?
Updating DB and cookies.
Holger wrote:Is there some kind of delay or does it manipulate the DB immideately?
The latter one.
Holger wrote:Can it cause problems when I have 500 users online clicking the +/- at nearly the same time?
That is highly depending on the particular server configuration, but actually same 500 users keep clicking everything else (viewforum, viewtopic, etc) which causes DB updating, and as far as your board is ok with that I doubt this ext will cause problems regarding the server load.

Locked

Return to “Extensions in Development”