Page 3 of 6

Re: [ALPHA] Collapsible Forum Categories

Posted: Sat Apr 25, 2015 10:22 am
by Holger
Yes, I think you are right! Thanks!

Re: [ALPHA] Collapsible Forum Categories

Posted: Sun Apr 26, 2015 5:11 am
by MattF
Korkel wrote:
VSE wrote:We're targeting phpBB 3.1.5 for a release of this extension.
That will take a long time I think.
No. We need time to test this anyways. And we have plans to improve how it works and its compatibility.
Holger wrote:What happens if several members keep clicking the +/-?
They get to keep seeing the magic of the category expanding and collapsing.
Holger wrote:Can it cause problems when I have 500 users online clicking the +/- at nearly the same time?
That would be an amazing feat of timing, precision and choreography!

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Mon Apr 27, 2015 7:17 am
by Holger
:D

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Mon Apr 27, 2015 12:23 pm
by mrgtb
Nice job, testing it now and looks good

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Tue Apr 28, 2015 5:18 am
by Allen142
Excellent job on this ALPHA release, Matt! I may try this on my live board as the development is finished. :D

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Tue Apr 28, 2015 10:08 pm
by Dragosvr92
Nice. But where are the images stored?
I would like to replace them. They are too large and they are designed to fit prosilver. They arent very style universal...

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Tue Apr 28, 2015 10:11 pm
by Wolfsblvt
Dragosvr92 wrote:Nice. But where are the images stored?
I would like to replace them. They are too large and they are designed to fit prosilver. They arent very style universal...
Those aren't images, they are CSS styled "buttons".
For the css code, you have to look in the theme folder: https://github.com/phpbb-extensions/col ... css#L4-L28

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Tue Apr 28, 2015 10:17 pm
by MattF
Dragosvr92 wrote:They arent very style universal...
Extensions are only required to be designed for Prosilver.

We will be adding additional style versions for validated/released styles per request in the future once released.

Re: [ALPHA] Collapsible Forum Categories

Posted: Wed Apr 29, 2015 5:26 am
by MattF
Korkel wrote:What means ALPHA?
http://bit.ly/1P4WCuh

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Wed Apr 29, 2015 9:52 am
by Dragosvr92
VSE wrote:
Dragosvr92 wrote:They arent very style universal...
Extensions are only required to be designed for Prosilver.

We will be adding additional style versions for validated/released styles per request in the future once released.
It would only need a theme for dark based styles. Just to fit any Dark styles in general.
You already did this for your TopicPreview extension, VSE. :)

Btw, i see the extension saves its settings inside a row, in the phpbb_users table.
I think it is preferable if it would just create a new table like... phpbb_collapseforumcat
And inside it, have two rows, user_id and collapsible_categories.

That way its not altering the users table / core content.
Doesnt create an empty row for each user, and may save a few bytes.
Thoughts?

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Wed Apr 29, 2015 10:51 am
by Holger
Any chance that you add a filter to searchresults? Collapsed categories not to deliver search-results.

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Wed Apr 29, 2015 11:27 am
by rxu
Using users_table saves SQL query as it makes the data available via the $user->data array without any additional actions.

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Wed Apr 29, 2015 4:55 pm
by MattF
Holger wrote:Any chance that you add a filter to searchresults? Collapsed categories not to deliver search-results.
What????

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Wed Apr 29, 2015 4:59 pm
by MattF
Dragosvr92 wrote:It would only need a theme for dark based styles. Just to fit any Dark styles in general.
You already did this for your TopicPreview extension, VSE. :)
No it doesn't. We will add theme specific styles because the colors are based exactly on the colors used by the style for a perfect fit. Besides, anyone who can open a file can open the css file and tweak the color codes to match their own styles if they want to support styles we do not support out of the box.

Re: [ALPHA][Official Extension] Collapsible Forum Categories

Posted: Thu Apr 30, 2015 5:15 am
by Dragosvr92
VSE wrote:
Dragosvr92 wrote:It would only need a theme for dark based styles. Just to fit any Dark styles in general.
You already did this for your TopicPreview extension, VSE. :)
No it doesn't. We will add theme specific styles because the colors are based exactly on the colors used by the style for a perfect fit. Besides, anyone who can open a file can open the css file and tweak the color codes to match their own styles if they want to support styles we do not support out of the box.
In your topicview Extension you have four themes. Light theme, Windows theme, Marcos theme and Dark theme. I dont think the Light, windows and Dark themes are based on any specific styles. They are just general themes that better fit Light or Dark themed styles. So, i dont see whats wrong if you would support these, out of the box. Add any other styles later :P