[3.2][BETA] [3.1] gn36 - Hookup

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
gn#36
Translator
Posts: 179
Joined: Fri Oct 13, 2006 1:16 pm
Contact:

Re: [DEV] gn36 - Hookup

Post by gn#36 » Thu Jan 14, 2016 10:15 pm

A bridge is now available, linking hjws calendar extension with the hookup. When an active date is set on hookup, this date is automatically entered into the calendar. When it is reset, the appointment is again removed from the calendar.

Download of current development version for testing: https://github.com/gn36/phpbb-ext-hjw-b ... master.zip
Github: https://github.com/gn36/phpbb-ext-hjw-bridge
Issues: https://github.com/gn36/phpbb-ext-hjw-bridge/issues

I don't expect any further changes to this ext.
German Support Team Member • http://www.phpbb.deMy Extensions in the CDBMy Extensions on Github • Contact with caos is inavoidable but no catastrophy if you keep an overview.

Miri4ever
Registered User
Posts: 392
Joined: Sat Mar 07, 2015 11:18 am

Re: [DEV] gn36 - Hookup

Post by Miri4ever » Sat Jan 16, 2016 7:29 pm

Getting this error if I try to enable this extension. Looks like it does not setup the correct table prefix for database. My table is not called phpbb_

Code: Select all

Allgemeiner Fehler
SQL ERROR [ mysql4 ]

Table 'xxxx.phpbb_users' doesn't exist [1146]

SQL

INSERT INTO PHP3_user_notifications (item_type, item_id, method, notify, user_id) SELECT 'gn36.hookup.notification.type.active_date_set', 0, 'notification.method.email', 1, user_id FROM phpbb_users WHERE user_type IN (0,3);

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 855
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysql.php
LINE: 181
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysql->sql_query()

FILE: [ROOT]/ext/gn36/hookup/migrations/v_1_0_0.php
LINE: 49
CALL: phpbb\db\driver\factory->sql_query()

FILE: (not given by php)
LINE: (not given by php)
CALL: gn36\hookup\migrations\v_1_0_0->notification_mails()

FILE: [ROOT]/phpbb/db/migrator.php
LINE: 550
CALL: call_user_func_array()

FILE: [ROOT]/phpbb/db/migrator.php
LINE: 496
CALL: phpbb\db\migrator->run_step()

FILE: [ROOT]/phpbb/db/migrator.php
LINE: 322
CALL: phpbb\db\migrator->process_data_step()

FILE: [ROOT]/phpbb/db/migrator.php
LINE: 202
CALL: phpbb\db\migrator->try_apply()

FILE: [ROOT]/phpbb/db/migrator.php
LINE: 185
CALL: phpbb\db\migrator->update_do()

FILE: [ROOT]/phpbb/extension/base.php
LINE: 80
CALL: phpbb\db\migrator->update()

FILE: [ROOT]/ext/gn36/hookup/ext.php
LINE: 153
CALL: phpbb\extension\base->enable_step()

FILE: [ROOT]/phpbb/extension/manager.php
LINE: 187
CALL: gn36\hookup\ext->enable_step()

FILE: [ROOT]/includes/acp/acp_extensions.php
LINE: 177
CALL: phpbb\extension\manager->enable_step()

FILE: [ROOT]/includes/functions_module.php
LINE: 674
CALL: acp_extensions->main()

FILE: [ROOT]/adm/index.php
LINE: 81
CALL: p_master->load_active()
Homepage: Terra Oceanica

User avatar
gn#36
Translator
Posts: 179
Joined: Fri Oct 13, 2006 1:16 pm
Contact:

Re: [DEV] gn36 - Hookup

Post by gn#36 » Sun Jan 17, 2016 8:17 pm

That is weird. Thank you for spotting.

I didn't think I used any hardcoded table names anywhere. As you can see in the error message, I used the table prefix for the insert part of the command (as that uses a different table prefix), but apparently I forgot replacing the second table in the query.

Should be fixed now, if you wish to try again.
German Support Team Member • http://www.phpbb.deMy Extensions in the CDBMy Extensions on Github • Contact with caos is inavoidable but no catastrophy if you keep an overview.

Miri4ever
Registered User
Posts: 392
Joined: Sat Mar 07, 2015 11:18 am

Re: [DEV] gn36 - Hookup

Post by Miri4ever » Mon Jan 18, 2016 10:29 pm

Looks good so far. Activation now works fine and purge data also fine.
Homepage: Terra Oceanica

User avatar
gn#36
Translator
Posts: 179
Joined: Fri Oct 13, 2006 1:16 pm
Contact:

Re: [ALPHA] gn36 - Hookup

Post by gn#36 » Mon Feb 01, 2016 11:54 pm

I just bumped up the version to the first alpha. There should not be any major errors left, but there are still a few things missing.
German Support Team Member • http://www.phpbb.deMy Extensions in the CDBMy Extensions on Github • Contact with caos is inavoidable but no catastrophy if you keep an overview.

KlausiMaus
Registered User
Posts: 65
Joined: Sat Nov 15, 2014 4:55 pm

Re: [ALPHA] gn36 - Hookup

Post by KlausiMaus » Sun Feb 07, 2016 2:52 pm

Is it possible to enable email notifications by default?

User avatar
gn#36
Translator
Posts: 179
Joined: Fri Oct 13, 2006 1:16 pm
Contact:

Re: [ALPHA] gn36 - Hookup

Post by gn#36 » Sun Feb 07, 2016 3:21 pm

Should already be the case.

I am not sure if my upgrade on this was entirely backwards compatible, so potentially you didn't get the upgrade because of that.

If you have users who manually activated it, then the safest way to enable it for all existing users is to run the queries here manually after deleting all entries using this query first. Obviously, you have to replace constants by your actual table names and take care of string markers to run this query e.g. in phpmyadmin.
German Support Team Member • http://www.phpbb.deMy Extensions in the CDBMy Extensions on Github • Contact with caos is inavoidable but no catastrophy if you keep an overview.

Nephilim
Registered User
Posts: 37
Joined: Tue Oct 26, 2010 8:46 pm

Re: [ALPHA] gn36 - Hookup

Post by Nephilim » Thu Jan 26, 2017 2:59 pm

Will you update this great ext to work completely with phpBB 3.2?

User avatar
gn#36
Translator
Posts: 179
Joined: Fri Oct 13, 2006 1:16 pm
Contact:

Re: [ALPHA] gn36 - Hookup

Post by gn#36 » Fri Jan 27, 2017 9:42 pm

Yes. It will take a while though. I am first finalizing the changes requested from the Extensions Team here to get it into the db for 3.1, then I will make the necessary changes for 3.2.

I will have to rework the notifications to make them compatible with 3.2. Everything else should work, but even with a disabled extension in 3.2 you will probably run into trouble because of the notifications.
German Support Team Member • http://www.phpbb.deMy Extensions in the CDBMy Extensions on Github • Contact with caos is inavoidable but no catastrophy if you keep an overview.

The_Capulet
Registered User
Posts: 2
Joined: Sat Mar 04, 2017 10:07 am

Re: [ALPHA] gn36 - Hookup

Post by The_Capulet » Sat Mar 04, 2017 10:09 am

Getting this error when I try to install:

"Dependencies of this extension are missing. Please use composer to install the missing dependencies or use a complete installation package."

User avatar
gn#36
Translator
Posts: 179
Joined: Fri Oct 13, 2006 1:16 pm
Contact:

Re: [RC] gn36 - Hookup

Post by gn#36 » Sat Mar 04, 2017 4:34 pm

Please use the complete package from here: https://github.com/gn36/phpbb-ext-hookup/releases

The zip file (gn36-hookup-1.0.2.zip) contains the missing dependencies, the "source code (zip)" does not.

Alternatively, you can install the dependencies yourself by running composer install.
German Support Team Member • http://www.phpbb.deMy Extensions in the CDBMy Extensions on Github • Contact with caos is inavoidable but no catastrophy if you keep an overview.

The_Capulet
Registered User
Posts: 2
Joined: Sat Mar 04, 2017 10:07 am

Re: [RC] gn36 - Hookup

Post by The_Capulet » Sun Mar 05, 2017 2:04 pm

Found that, Thanks.

Now I'm getting this error:

Code: Select all

General Error
SQL ERROR [ mysql4 ]

Unknown column 'user_id' in 'field list' [1054]

SQL

SELECT user_id, notify_status, comment FROM phpbb_hookup_members WHERE topic_id=2749

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 855
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysql.php
LINE: 181
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysql->sql_query()

FILE: [ROOT]/ext/gn36/hookup/functions/hookup.php
LINE: 84
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/ext/gn36/hookup/event/viewtopic.php
LINE: 109
CALL: gn36\hookup\functions\hookup->load_hookup()

FILE: (not given by php)
LINE: (not given by php)
CALL: gn36\hookup\event\viewtopic->show_hookup_viewtopic()

FILE: [ROOT]/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatcher.php
LINE: 161
CALL: call_user_func()

FILE: [ROOT]/vendor/symfony/event-dispatcher/Symfony/Component/EventDispatcher/EventDispatcher.php
LINE: 46
CALL: Symfony\Component\EventDispatcher\EventDispatcher->doDispatch()

FILE: [ROOT]/phpbb/event/dispatcher.php
LINE: 60
CALL: Symfony\Component\EventDispatcher\EventDispatcher->dispatch()

FILE: [ROOT]/phpbb/event/dispatcher.php
LINE: 46
CALL: phpbb\event\dispatcher->dispatch()

FILE: [ROOT]/viewtopic.php
LINE: 695
CALL: phpbb\event\dispatcher->trigger_event()
Looking forward to getting this to work. Used it before and it was dead useful.

User avatar
gn#36
Translator
Posts: 179
Joined: Fri Oct 13, 2006 1:16 pm
Contact:

Re: [RC] gn36 - Hookup

Post by gn#36 » Sun Mar 05, 2017 3:21 pm

Did you get errors during installation? This error sounds like the installation was incomplete.

Did you do an upgrade from 3.0 with an existing hookup inside the forum? If so, what kind of database cleanup did you run before or after upgrading to 3.1?

The table this error reports is identical between the 3.0 mod and this extension. So maybe during your cleanup the table was removed or changed, but you did not remove the whole hookup mod (especially not the entries in the config table, which are used to have an easy check whether the mod is installed or not) so the installation detected an existing installation and skipped installing most of the database stuff.

If this is the case, you will likely also not be able to uninstall (purge the data) of this extension, because during uninstall it will not be able to find the table either.

To really find out what is going on, you will have to take a look into your database. Hookup requires 3 tables: phpbb_hookup_members, phpbb_hookup_dates and phpbb_hookup_available. Please check if these are there and if they contain the following columns:

phpbb_hookup_available:
  • date_id
  • topic_id
  • user_id
  • available
phpbb_hookup_dates:
  • date_id
  • topic_id
  • date_time
  • text (this one might be missing for an incomplete update from 3.0, it did not exist back then)
phpbb_hookup_members:
  • topic_id
  • user_id (we already know here is something fishy going on)
  • notify_status
  • comment
In addition, the phpbb_topics table was adjusted to contain additional columns:
  • hookup_enabled
  • hookup_active_date
  • hookup_self_invite
  • hookup_autoreset
So let's see in what state your database is to see how we can repair it.
German Support Team Member • http://www.phpbb.deMy Extensions in the CDBMy Extensions on Github • Contact with caos is inavoidable but no catastrophy if you keep an overview.

Mohammed AlSarsawi
Registered User
Posts: 41
Joined: Fri Mar 03, 2017 1:35 pm

Re: [RC] gn36 - Hookup

Post by Mohammed AlSarsawi » Fri Mar 10, 2017 2:04 am

Hello

thank you for this great extension
really good work

this is my issue
https://github.com/gn36/phpbb-ext-hookup/issues/60

also if i apply the Arabic translation
the numbers change to diffrent character which give me invalid date message
it should not be changed

Image


Thank you

User avatar
gn#36
Translator
Posts: 179
Joined: Fri Oct 13, 2006 1:16 pm
Contact:

Re: [RC] gn36 - Hookup

Post by gn#36 » Mon Mar 13, 2017 8:55 pm

Ah very interesting. I never tried using the hookup with an RTL language. I guess the "dumb" old JS calendar was better for this case.

I don't have an Arabic translation for this extension. Can you provide the translation of the extension you used so I can actually reproduce what happens? Are the texts valid text representations of the date picked? Or is it complete garbage?
German Support Team Member • http://www.phpbb.deMy Extensions in the CDBMy Extensions on Github • Contact with caos is inavoidable but no catastrophy if you keep an overview.

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: Yandex [Bot] and 22 guests

cron