Page 4 of 4

Topic Age Warning; gettin new error

Posted: Sun Apr 21, 2019 4:22 am
by John Robi
Hello,

Details:
Running phpBB 3.2.5 with Enabled Extensions: Auto Groups, Board Announcements, Board Rules, External link in new window, Header banner, Quick Reply on last page only, Quick Reply reloaded, Topic age warning & VigLink.
PHP 7.1.14, MySQL 5.1.3, Apache 2.2.24, local : Firefox 65.0.2, Windows 10

I have been testing out Topic age warning. It seemed to be working well, I unlocked several topics to see the interaction and I received a warning message at the top of the window. See image below.

I disabled the extension and the message want away. I deleted the data and uninstalled the extension. Still no error message. I reinstalled from new and enabled the extension. Same error message displays. I did disable extension Quick Reply on last page as well because it was the last extension installed and right after Topic age warning.

David, you out there?

Image

Re: [3.2][RC] Topic Age Warning

Posted: Sun Apr 21, 2019 7:21 am
by david63
John Robi wrote:
Sun Apr 21, 2019 4:22 am
David, you out there?
Yes I am

Can you post the error so that I can read it - that is way too small.

Re: [3.2][RC] Topic Age Warning

Posted: Sun Apr 21, 2019 4:13 pm
by John Robi
Hello,

David, so glad your there. I captured the image in sections to get it bigger.

Image
Image
Image

Also, do note the error only displays when I click on a topic that exceeds the age threshold.

Re: [3.2][RC] Topic Age Warning

Posted: Sun Apr 21, 2019 5:26 pm
by </Solidjeuh>
Why not just copy/paste the error message? It's easier and faster... :D

Re: [3.2][RC] Topic Age Warning

Posted: Sun Apr 21, 2019 5:38 pm
by John Robi
Hello,

Well, I got used to the snipping tool where I may keep a .jpg log of all images sent. Copy/paste and I would have to have a second folder to log the information sent.

That said here is copy/paste:

[phpBB Debug] PHP Warning: in file [ROOT]/ext/david63/topicagewarning/event/listener.php on line 105: in_array() expects parameter 2 to be array, null given
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4564: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3314)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4564: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3314)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4564: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3314)

Thanks for your observation. I guess I need to get out of my log all mode from time to time.


**************** update ********************** update

I have thought about installing a backup of the DB to see if that effects the error. I am already using the backup of phpBB prior to the extensions first install.

Thoughts?

Re: [3.2][RC] Topic Age Warning

Posted: Sun Apr 21, 2019 5:50 pm
by david63
I cannot reproduce that error - can you post a copy of the settings page

Re: [3.2][RC] Topic Age Warning

Posted: Sun Apr 21, 2019 6:38 pm
by John Robi
Hello,

Here are snippet jpg's.

Do note, the last action I performed was to unlock a locked topic in order to view the warning when my browser crashed. I relaunched the browser (Firefox) and all tabs were automatically restored. The errors now appeared. I then disabled the extension, re-enabled, then disabled & deleted the data, re-enabled, then disabled & deleted data and uninstalled the extension. Then, reinstalled & enabled, then, uninstalled all again and loaded from new, then uninstalled again and loaded my phpBB backup made prior to the first install of the extension & installed the extension from new. Only the DB has not been reloaded from backup.

Image
Image
Image


****************** UP DATE ************************* UP DATE **************************

I loaded a backup of the data base made prior to the extension installation. The board crashed, fatal error. To top that, the backup of the DB I made 10 minutes earlier wont load. 12 hours spent reconstructing the DB. Installed even older backup of phpbb. Board up and running again. This has me bugged.

The only next step I can see is to install phpbb new & create a new data base, install the extension and build from there. Not really sure I want to take on all that work.

David, any thoughts?

Anyone, any thoughts?

Re: [3.2][RC] Topic Age Warning

Posted: Fri May 17, 2019 9:47 am
by mrix2000
david63 wrote:
Thu Apr 04, 2019 12:55 pm
Yes I am
Hello David, this mod of yours looks perfect for my requirements, unfortunately the mod download links no longer work ? has it been discontinued ?

Hopefully not
Thanks

Re: [3.2][RC] Topic Age Warning

Posted: Fri May 17, 2019 9:52 am
by david63
mrix2000 wrote:
Fri May 17, 2019 9:47 am
has it been discontinued ?
No - I am in the middle of some re-organisation and it should be back in a couple of days

Re: [3.2][RC] Topic Age Warning

Posted: Fri May 17, 2019 4:06 pm
by mrix2000
david63 wrote:
Fri May 17, 2019 9:52 am
mrix2000 wrote:
Fri May 17, 2019 9:47 am
has it been discontinued ?
No - I am in the middle of some re-organisation and it should be back in a couple of days
That`s fantastic News 8-)

Just an couple of questions, I have been having a discussion with my moderators and they like the idea of having the warning on the old threads, but there are some that are healthy to be reactivated and many others that are not etc, having a warning to make New members aware these type of threads are old is ideal but is there anyway from stopping the topic being lock on old threads so it makes the op aware to post or not ?

Thanks

Re: [3.2][RC] Topic Age Warning

Posted: Wed May 22, 2019 2:22 pm
by imkingdavid
mrix2000 wrote:
Fri May 17, 2019 4:06 pm
Just an couple of questions, I have been having a discussion with my moderators and they like the idea of having the warning on the old threads, but there are some that are healthy to be reactivated and many others that are not etc, having a warning to make New members aware these type of threads are old is ideal but is there anyway from stopping the topic being lock on old threads so it makes the op aware to post or not ?
One of the settings (visible in the screenshot of the settings above by John Robi, is "Lock old topic: Yes | No". If set to no, it would show a warning that the topic is old without locking it automatically.

EDIT: I took a brief look into the error John Robi reported. The error message indicates an issue with this line in the listener.php code:

Code: Select all

if (($this->config['taw_all_forums'] || in_array($topic_data['forum_id'], $taw_forums)) && $topic_data['topic_status'] != ITEM_LOCKED && $this->config['taw_interval'] > 0)
Particularly, in_array[$topic_data['forum_id'], $taw_forums) is where the error is thrown. It is saying that $taw_forums is null but an array is expected. Just from looking at the screenshot you posted, the "Select Forums" setting doesn't appear to have any forums selected, so that is likely what is causing $taw_forums to contain a null value. If you select at least one forum it may resolve that error.

Re: [3.2][RC] Topic Age Warning

Posted: Fri May 24, 2019 6:23 pm
by thetgc
Any news on when the download will be available again? Seems like just the sort of extension I could do with on my forum :)

Re: [3.2][RC] Topic Age Warning

Posted: Sat May 25, 2019 3:14 pm
by david63
thetgc wrote:
Fri May 24, 2019 6:23 pm
Any news on when the download will be available again? Seems like just the sort of extension I could do with on my forum :)
Links updated in OP

Re: [3.2][RC] Topic Age Warning

Posted: Sat May 25, 2019 3:16 pm
by thetgc
Thanks David. Very much appreciated :)