[3.1][BETA] Advanced Polls 1.2

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

[3.1][BETA] Advanced Polls 1.2

Post by javiexin » Sun Jul 12, 2015 1:34 pm

Image

Extension Name: Advanced Polls
Authors: Extension Description: Advances the core poll system of phpBB with new features like hiding votes till end, showing poll voters, scoring polls, limiting the votes and more.
Extension Version: 1.2.0-b1

Version Highlights:
This version brings a lot of new functionality to this Advanced Polls extension. All functionality may be enabled or disabled at the board level.
  • Scoring Polls
    These are polls that allow to assign multiple votes to a single option. This allows to create "voting" polls, with points being assigned differently to the best, second, third options... Also, it allows to make a kind of "ordering list" where someone could ask for multiple copies of the same item. And may more!
  • Incremental voting
    If enabled, a voter may issue a partial vote (assign only part of the allowed votes), and then complete the voting later, even if changes are NOT allowed. Of course, this is only useful in polls where multiple votes may be assigned (both for scoring polls, and for normal polls)
  • Voting on closed topics
    This allows to issue votes in topics that are locked/closed and do not accept comments. Therefore, this separates the closing of a topic from the closing of the accompanying poll. This is useful for polls were voting is secret (at least while the voting is open), and no comments on the voting/poll are allowed
  • Notification on finished polls
    If you voted on a hidden poll (a poll that does not allow to see results until voting period ends), you will receive a notification when these results are available
  • Scoring poll voters
    On scoring polls that allow seeing poll voters, you will be able to see also how many votes were given for each option
  • Ordered poll results
    If selected, when you see the results of a poll, the options will be reordered by decreasing number of votes received
  • Poll end specification
    The end of a poll may be specified as always, as a number of days since the poll started, or as an specific date and time when the poll finishes. Useful to specify, for example, the end of a poll on "Midnight next Sunday", or something similar.
  • Poll moderators
    New permission that allows specific moderators to see poll voters regardless of the configuration of the poll. The option may be enabled or disabled at board level.
  • And much more...
Requirements:
  • PHP: >= 5.3.3
  • phpbb: >= 3.1.5
Features:
Current Features
****************
  • Ability to hide poll votes till end of poll
  • Ability to show poll voters in poll
  • Ability to mark a poll as "I don't want to vote" so you can directly see the results
  • Choose default options for poll creation
  • Permission to see poll voters
  • Moderator permission to see poll voters even if poll is not public
  • Limit voting to people posted in thread
  • Works with all the ajax calls
  • Notification if hidden poll you voted in has ended
  • Ability to assign multiple votes to a single option
  • Ability to vote incrementally
  • Ability to vote on closed topics
  • Can specify poll end by date and time, as well as duration
  • Results of a poll may be ordered
Planned Features
****************
  • Full subsilver2 support
  • Refactoring code
  • Restructuring and completing visibility options
  • Restructuring and completing vote change options
  • Clean up code by introducing additional events in templates
Screenshots (from version 1.1):
Image

Image

Image

Image


Extension Download: wolfsblvt.advancedpolls.zip
(Temporarily using GitHub for extension download)

Installation: Copy the contents of the downloaded file to the ext/wolfsblvt/advancedpolls folder. Make sure that the file named "composer.json" is placed exactly in the mentioned folder.

GitHub Repository: http://github.com/Wolfsblvt/advancedpolls/
(For viewing purposes)

More Information:
There are multiple features missing in the core poll system of phpBB, and that improving those would be useful for many people, so we decided to combine several use cases from each of us into a single more complete extension that would advance the phpbb poll system. Here is it now!
Of course, things may be improved always, so if you have suggestions, we want to hear them.

If you don't like the styling of the poll voters list, it can be easily modified in css, even with limiting the usernames displayed, etc.

In this version, subsilver2 support is NOT provided. We are planning to include it at a later time, but for now, subsilver2 is NOT supported with this version for all the functionality. If someone wants to make it work in subsilver2, we would gladly accept a PR with those changes, to be incorporated into a future version.

This extension is fully compatible with the new ajax calls where the site isn't reloaded when you vote.

As for language packs, the ONLY languages that are supported for this version are:
  • English
  • Spanish
  • Italian
  • Russian
  • Dutch
  • French
The other language packs have NOT been updated to this version, so until then, you will not have the complete language. Translators, please, complete translations, and send PRs or language translations to be included.

If you have further suggestions for new functionality, please, mention them here, and we will evaluate them, and potentially include them (no commitments!).

Bug reports for this extension in this thread please, or on GitHub.
Last edited by javiexin on Sat Dec 03, 2016 8:28 pm, edited 2 times in total.

User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

Re: [BETA] Advanced Polls 1.2

Post by javiexin » Sun Jul 12, 2015 1:34 pm

Changes in 1.2.1
===============
  • NEW: Implemented "Poll duration in hours" - allows to specify the duration of a poll in multiple units (days or hours)
  • Bug fix: Remove old permission
  • Bug fix: Check compatibility of options (max votes, total votes, max options)
  • Improvement: Improve language describing poll end behavior (defaults)
  • Workaround: Language file incorrectly loaded from board language rather than user language (core bug)
  • Bug fix: Take into consideration user timezone when setting the poll end date
Last edited by javiexin on Tue Jul 21, 2015 7:52 pm, edited 2 times in total.

FomenkoAndrey
Registered User
Posts: 363
Joined: Thu Aug 19, 2010 10:44 am

Re: [BETA] Advanced Polls 1.2

Post by FomenkoAndrey » Sun Jul 12, 2015 3:04 pm

find ("',)

Code: Select all

	'AP_DEFAULT_VOTERS_LIMIT'		=> 'По умолчанию выбрано значение ограничения проголосовавших"',
replace (',)

Code: Select all

	'AP_DEFAULT_VOTERS_LIMIT'		=> 'По умолчанию выбрано значение ограничения проголосовавших',

User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

Re: [BETA] Advanced Polls 1.2

Post by javiexin » Sun Jul 12, 2015 3:22 pm

Fixed, thanks.

Holger
Registered User
Posts: 1580
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [BETA] Advanced Polls 1.2

Post by Holger » Mon Jul 13, 2015 6:55 am

I am a little bit lost, I cannot find changed or added lang-variables. I want to update the Swedish translation via GitHub.
Are you looking for a phpBB Expert? Find a phpBB Expert!
Are you a phpBB Expert? Post your resume!
http://www.phpbbexperts.com

User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

Re: [BETA] Advanced Polls 1.2

Post by javiexin » Mon Jul 13, 2015 7:24 am

Simply compare the EN language files with the SE language files, and you will see the differences.

Holger
Registered User
Posts: 1580
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [BETA] Advanced Polls 1.2

Post by Holger » Mon Jul 13, 2015 7:30 am

There is no function on github for this?
Are you looking for a phpBB Expert? Find a phpBB Expert!
Are you a phpBB Expert? Post your resume!
http://www.phpbbexperts.com

User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

Re: [BETA] Advanced Polls 1.2

Post by javiexin » Mon Jul 13, 2015 7:53 am

Not that I know of, but my knowledge of GitHub is very limited.

Holger
Registered User
Posts: 1580
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: [BETA] Advanced Polls 1.2

Post by Holger » Mon Jul 13, 2015 7:55 am

Ok! I will look around a little bit!
Are you looking for a phpBB Expert? Find a phpBB Expert!
Are you a phpBB Expert? Post your resume!
http://www.phpbbexperts.com

User avatar
draky
Registered User
Posts: 245
Joined: Tue Dec 10, 2002 2:04 pm
Location: France
Name: Gilles W.
Contact:

Re: [BETA] Advanced Polls 1.2

Post by draky » Mon Jul 13, 2015 9:05 am

So your "old" version is abandonned ?
Need to delete all settings then upload new version ?

User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

Re: [BETA] Advanced Polls 1.2

Post by javiexin » Mon Jul 13, 2015 10:19 am

draky wrote:So your "old" version is abandonned ?
Need to delete all settings then upload new version ?
The "old" version is not abandoned, it is "old" :lol: :lol: :lol:

This version supersedes the other one, with the same existing functionality and much more.

To install over the old one, I would recommend that you:
1) Disable OLD version
2) Delete data from OLD version
3) Remove from filesystem
4) Copy new version in place
5) Enable NEW version
Just like with any other extension you upgrade...

Poll data will not be lost. Only thing you will loose are the permissions that you might have granted, that you need to grant again anyhow (permission has changed).

Once you upgrade, same as if you do a fresh install, you will need to, at least, do the following:
1) Configure global extension settings in the "Extensions" tab of the ACP
2) Configure permissions, both for users to be able to See Poll Voters (changed permission from old version), and for Moderator to see Poll Voters either globally or per forum (new permission in this version).

That should do it...
Regards,
-javiexin

leschek
Registered User
Posts: 755
Joined: Tue Jul 18, 2006 12:49 pm
Contact:

Re: [BETA] Advanced Polls 1.2

Post by leschek » Mon Jul 13, 2015 11:45 am

Thank you. Here is some feedback:
  1. It seems that language variables are not loaded (in poll and in poll settings) from language files if they are from different language than the default language of board. For example if I set board language to English, but in UCP I change language to Czech (extension's files are translated) in poll are shown English lines and not Czech as it should. I think it is similar problem as I reported couple of months ago to author of phpBB Gallery extension.
  2. plural in - You may give up to [b]1 votes[/b] to 1 option - there should be 1 vote instead of 1 votes.
  3. Total votes - This is the total number of votes that might be given to all options. - is 1 default number for any amount of votes? I'm asking, because I set it to 1 and I was able to vote with 3 testing users - so users gave 3 total votes.
  4. It shouldn't be allowed to set more "Maximum votes" than "Total votes". Now I'm able to set:
    "Maximum votes" - 2 and "Total votes" - 1
    and to user it shows he/she can give 2 votes to one option even in fact he can't and if he try to give 2 votes it shows error message "You have tried to assign too many votes." - It's kind of confusing for users.

User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

Re: [BETA] Advanced Polls 1.2

Post by javiexin » Mon Jul 13, 2015 12:36 pm

leschek wrote:Thank you. Here is some feedback:
Responses in order:
  1. LanguageSee above, CZ is not a supported language at this point, as noone has translated the extension at all (not even the previous version). I will be happy to incorporate your translation :). If the problem happens with some of the supported languages as per viewtopic.php?p=14139936#p14139936, please report it (try to be VERY specific, what string, where, etc.).
  2. Plural, it is not possible (that I know of) to do double language conditional, that language entry is singular/plural based on number of options, so number of votes is fixed to plural.
  3. Total votes This is the total of votes given BY A SINGLE USER. Of course, multiple users may give more votes. If you think language is misleading, propose different wording, and I will check it.
  4. MaximumI will check what you comment, and if so, I will make sure to give a warning when configuring such combination, that should not happen as you said. This may be a bug in the code.
Thanks a lot for the feedback, very helpful.
-javiexin

User avatar
javiexin
Code Contributor
Posts: 1157
Joined: Wed Oct 12, 2011 11:46 pm
Location: Madrid, Spain
Name: Javier
Contact:

Re: [BETA] Advanced Polls 1.2

Post by javiexin » Mon Jul 13, 2015 1:01 pm

Regarding the language issue, please test the following:

Disable all extensions except Advanced Polls, and try again. If language works fine this way, the problem is probably in some other extension missing a language file, and forcing the whole board to default to English. If that is the case, then make sure you have language files for all of your extensions... And I guess you should open a new ticket, as this should not happen (a problem in one extension should not affect the behavior of another).

Thanks for reporting this,
-javiexin

leschek
Registered User
Posts: 755
Joined: Tue Jul 18, 2006 12:49 pm
Contact:

Re: [BETA] Advanced Polls 1.2

Post by leschek » Mon Jul 13, 2015 1:29 pm

Thank you for the reply.
  1. Well, I'm translating it for my own Czech translation of phpBB (called cs_alt). If you want to see the problem I was writing about, change default board language to English and in UCP change your language to any other installed language. Then just go to poll setting or just poll.
    I disabled all the extensions except Advanced Polls and I still can see the problem. Of course there can be some problem with my files... But this is already third extension with the same problem.
  2. In core phpBB is for example "There is 1 registered user and 0 hidden users online". You can find how it is done in commom.php language file from core phpBB:
    Around line 614

    Code: Select all

    // "... and 2 hidden users online"
    	'REG_USERS_ONLINE'			=> array(
    		1	=> 'There is %1$d registered user and %2$s online',
    		2	=> 'There are %1$d registered users and %2$s online',
    	),
    and around line 313:

    Code: Select all

    'HIDDEN_USERS_ONLINE'		=> array(
    		1	=> '%d hidden user',
    		2	=> '%d hidden users',
    	),
  3. OK. I see. What about something like this: This is the total number of votes that might be given to all options by single user if user can vote for more options.

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: nou nou, panhead, RomaamoR, zorni and 30 guests