[CDB] Smartfeed 3.0.4

pantherfan · Post by **pantherfan** » Sun Dec 06, 2015 7:03 pm

I can access the forums on the index, if there are separate permissions for Smartfeed, I'm not sure where they are.

MarkDHamill · Post by **MarkDHamill** » Mon Dec 07, 2015 2:27 am

The Git repository has been moved to this link and contains 3.0.2 as the master. The first post has been updated with the correct link.

https://github.com/MarkDHamill/smartfeed

MarkDHamill · Post by **MarkDHamill** » Mon Dec 07, 2015 2:33 am

pantherfan wrote:I can access the forums on the index, if there are separate permissions for Smartfeed, I'm not sure where they are.

I can assure you that there are no permissions built in for Smartfeed that must be enabled. It looks for READ and LIST permissions on forums to determine if you have the privileges.

It certainly is possible that no permissions have been defined for a forum or forums for the administrator group. That's likely the problem here. If you click on a forum list can you see posts in the forum?

You can set forum permissions for administrators as follows:

ACP > Users and Groups > Group forum permissions the select Administrators.

It's also possible that your username permissions override the group permissions.

ACP > Users and Groups > User forum permissions the select your username.

pantherfan · Post by **pantherfan** » Mon Dec 07, 2015 2:09 pm

Yes, I can read everything in the forum.

MarkDHamill · Post by **MarkDHamill** » Mon Dec 07, 2015 11:59 pm

I'm afraid without permissions to your forum I could not troubleshoot this. If you are willing to give me such, send me a PM with the authorization information.

leschek · Post by **leschek** » Tue Dec 08, 2015 2:06 pm

Thank you for converting your MOD to extension. When I tried to update my MOD's translation I found in language files some small issues:

in language\en\common.php

'SMARTFEED_LIMIT_SET_EXPLAIN' => 'Irrespective of the time periods shown, this board has a set limit of %d days beyond which no posts can be retrieved... - I think there should be plural array( for days.

'SMARTFEED_NO_ACCESSIBLE_FORUMS' => 'You have no permission to access any forums on this site. If you are registered on this site, you may need the administrator to give you privileges to read forums orreinstate you as an active member - look on word orreinstate

2 x the same line 'SMARTFEED_NO_MCRYPT_SUPPORT'

in language\en is also file ._info_acp_common.php - probably some kind of mac file?

MarkDHamill · Post by **MarkDHamill** » Tue Dec 08, 2015 9:20 pm

On the first item, I believe days is plural. The language string reads:

Code: Select all

	'SMARTFEED_LIMIT_SET_EXPLAIN'						=> 'Irrespective of the time periods shown, this board has a set limit of %d days beyond which no posts can be retrieved. This is necessary to ensure that fetching feeds does not slow down overall access to this forum.',

On the second item, thanks for finding the typo. It will be corrected in the next release.

I removed the second mcrypt language string as well.

leschek · Post by **leschek** » Tue Dec 08, 2015 9:49 pm

Thank you for reply.

MarkDHamill wrote:On the first item, I believe days is plural. The language string reads: ...

Yes, days is plural, but some languages have more forms of plural. It's explained here.

david63 · Post by **david63** » Tue Dec 08, 2015 9:49 pm

MarkDHamill wrote:On the first item, I believe days is plural.

If it is possible that it could be one day then you need to apply the Plural Rules

MarkDHamill · Post by **MarkDHamill** » Wed Dec 09, 2015 1:22 am

Apparently I wasn't aware of the plural rules. I'll have to go through all the language strings before I release and fix these, quite a challenge as I have a lot of language strings.

MarkDHamill · Post by **MarkDHamill** » Wed Dec 09, 2015 1:24 am

leschek wrote:in language\en is also file ._info_acp_common.php - probably some kind of mac file?

Yes, I must have missed this one. I normally run a dot_clean command to remove these files before publishing. It's an annoying feature of MacOS I wish I could selectively turn off.

david63 · Post by **david63** » Wed Dec 09, 2015 7:43 am

MarkDHamill wrote:Apparently I wasn't aware of the plural rules.

Not many of us were until somebody else pointed them out to us

Praggle · Post by **Praggle** » Thu Dec 10, 2015 9:18 pm

In subsilver2-template smartfeed_body.html, Line 216 is

Code: Select all

<td class="row2" style="padding: 5px; width: 30%;"><span class="gen"><input type="button" name="runit" id="runit" value="{L_SMARTFEED_TEST}" class="btnmain" onclick="run_it();"/></span><br />

Onclick-Value should be: test_feed();

Code: Select all

<td class="row2" style="padding: 5px; width: 30%;"><span class="gen"><input type="button" name="runit" id="runit" value="{L_SMARTFEED_TEST}" class="btnmain" onclick="test_feed();"/></span><br />

Praggle · Post by **Praggle** » Thu Dec 10, 2015 10:39 pm

On my server I have no mcrypt installed and I don't have access to the php-configuration of this server. My board has almost no public accessable forums.
Is there no chance, to use smartfeed with those private areas?

MarkDHamill · Post by **MarkDHamill** » Sat Dec 12, 2015 12:19 am

Praggle wrote:In subsilver2-template smartfeed_body.html, Line 216 is

Code: Select all

<td class="row2" style="padding: 5px; width: 30%;"><span class="gen"><input type="button" name="runit" id="runit" value="{L_SMARTFEED_TEST}" class="btnmain" onclick="run_it();"/></span><br />

Onclick-Value should be: test_feed();

Code: Select all

<td class="row2" style="padding: 5px; width: 30%;"><span class="gen"><input type="button" name="runit" id="runit" value="{L_SMARTFEED_TEST}" class="btnmain" onclick="test_feed();"/></span><br />

Good catch and thanks. I wasn't sure if anyone would use it with subsilver2 for 3.1 but I converted it anyhow. Missed this one.