[CDB] Smartfeed 3.0.4

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Locked
User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC2] Smartfeed 3.0.3

Post by MarkDHamill » Fri Apr 22, 2016 4:51 pm

Try changing the line to the following and let me know if the error goes away:

Code: Select all

						generate_board_url() . '/styles/' . $this->template->get_user_style() . '/theme/images/icon_topic_attach.gif') .
Thank you for your testing. It's invaluable!
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

michael.s
Registered User
Posts: 13
Joined: Sun Jan 24, 2016 9:40 am

Re: [RC2] Smartfeed 3.0.3

Post by michael.s » Sat Apr 23, 2016 7:08 am

You are very welcome. I really appreciate your quick replies and efforts to provide the Smartfeed extension to the community.

With the code change I get no error but the attachment icon (the paper clip) is not shown in the feed next to the attachment. The resulting path in the source of the feed is now:

/phpBB3/styles/Array/theme/images/icon_topic_attach.gif

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC2] Smartfeed 3.0.3

Post by MarkDHamill » Sat Apr 23, 2016 12:55 pm

Please change lines 1455-1458 to:

Code: Select all

				$my_styles = $this->template->get_user_style();
				$attachment_markup .= ($row['attach_comment'] == '') ? '' : '<em>' . $row['attach_comment'] . '</em><br />';
				$attachment_markup .= 
					sprintf("<img src=\"%s\" title=\"\" alt=\"\" /> ", 
						generate_board_url() . '/styles/' . $my_styles[0] . '/theme/images/icon_topic_attach.gif') .
Smilies won't show either. They used to so I'm not sure why it's happening now. Line 1041-1042 should be:

Code: Select all

							$message = str_replace('<img src="./../../', '<img src="' . $board_url, $message); 
							$message = str_replace('<img class="smilies" src="./../../', '<img class="smilies" src="' . $board_url, $message);
and lines 1285-1286 should be:

Code: Select all

								$post_text = str_replace('<img src="./../../', '<img src="' . $board_url, $post_text); 
								$post_text = str_replace('<img class="smilies" src="./../../', '<img class="smilies" src="' . $board_url, $post_text);
These changes have been pushed up to my GitHub.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

michael.s
Registered User
Posts: 13
Joined: Sun Jan 24, 2016 9:40 am

Re: [RC2] Smartfeed 3.0.3

Post by michael.s » Sat May 14, 2016 9:37 am

Sorry, other projects have eaten my time. I now took the complete package from github to test it. The result is:

- smilies are shown
- the attachment icon is not shown

The path to the attachment icon in the source of the feed is still

/phpBB3/styles/<mysubstyle>/theme/images/icon_topic_attach.gif

where it should be

/phpBB3/styles/<parentstyle>/theme/images/icon_topic_attach.gif

where <parentstyle> is still prosilver in my case. However, it is only a detail. Possibly, phpBB 3.1 lacks the possibility to get the path to icons only present in the parent style?

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC2] Smartfeed 3.0.3

Post by MarkDHamill » Sat May 14, 2016 3:38 pm

This is a minor bug but a good catch. prosilver of course does not have a parent style. Most styles inherit from prosilver. In your case I suspect if you changed line 1459 in /phpbbservices/smartfeed/controller/feed.php from:

Code: Select all

						generate_board_url() . '/styles/' . $my_styles[0] . '/theme/images/icon_topic_attach.gif') .
to

Code: Select all

						generate_board_url() . '/styles/' . $my_styles[1] . '/theme/images/icon_topic_attach.gif') .
it would work.

I need to look at the create_attachment_markup function and tweak it.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC2] Smartfeed 3.0.3

Post by MarkDHamill » Sun May 15, 2016 3:12 pm

I fixed this issue. You can see the code changes here:

https://github.com/MarkDHamill/smartfee ... fdf2774234
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

michael.s
Registered User
Posts: 13
Joined: Sun Jan 24, 2016 9:40 am

Re: [RC2] Smartfeed 3.0.3

Post by michael.s » Wed May 18, 2016 1:32 pm

Now the icon is shown with my installation as well. Thank you for your effort - even with this minor bug.

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC2] Smartfeed 3.0.3

Post by MarkDHamill » Wed May 18, 2016 2:18 pm

Not a problem as it needed to be fixed.

I realized another issue I have to look into. phpBB 3.1 allows for OAuth authentication. I need to see if Smartfeed can support it. My suspicion is not for customized newsfeeds.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

Thunder_one
Registered User
Posts: 119
Joined: Sat May 09, 2015 11:00 pm

Re: [RC2] Smartfeed 3.0.3

Post by Thunder_one » Thu May 19, 2016 4:31 pm

hi guys
go now rss feeds where post in the forum?

User avatar
MarkDHamill
Registered User
Posts: 3855
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC3] Smartfeed 3.0.4

Post by MarkDHamill » Thu Jun 23, 2016 1:58 pm

Smartfeed 3.0.4 is now an approved extension. You can get it here. Please ask support questions there as well.

My hearty thanks to all that contributed toward the testing and feature suggestions.
Get the latest versions of my Digests and Smartfeed extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

Locked

Return to “Extensions in Development”

cron