[DEV] Animated PM Notification

[Sniper_E]

Extension Name: Animated PM Notification
Extension Version: 1.0.5

Author: Sniper_E

Extension Description:
Shows new animated PMs and new Post Notifications below the header navbar. With display option in ucp.

phpBB 3.2.x/3.3.x


Extension download: anipmnotify_1.0.5.zip

Installation:

1. Download the latest release and unzip content.
2. Copy the contents to ` ext/sniper/anipmnotify/ `
3. Enable Extension in the ACP

Updating:

1. Download the latest release and unzip content.
2. Disable extension, delete data and delete old files from your server.`
3. Copy the new unzipped contents to ` ext/sniper/anipmnotify/ `
4. Enable Extension in the ACP

[david63]

Can I just point out that you should be using Plural rules in your language file

[Sniper_E]

Sure you can David. Thanks, I was not aware of the Plural rules thing.

Something like this?

Code: Select all

	'PM_MESSAGES'			=> array(
		1	=> 'Message',
		2	=> 'Messages',
	),

I know there's more to it than just that.
I looked at that link you posted and others it lead to. I don't understand all of that.

I didn't look before but the ./language/en/common.php has these in it.

Code: Select all

	'MESSAGE' 			=> 'Message',
	'MESSAGES'			=> 'Messages',

I didn't even have to make a language entry for those. I could have simply use the existing ones.

Would I have to use Plural rules in my language file for this extension for it to pass your validation?
Do I need to dig into the Plural rules setup and figure out how to incorporate it into this? If I have to I will.

[david63]

Would I have to use Plural rules in my language file for this extension for it to pass your validation?

Cannot say definitely (depends on whether Paul is in a good mood or not ) but some extensions have been denied for not using it.

I didn't even have to make a language entry for those. I could have simply use the existing ones.

But you would still need to handle them in your listener files (which you are currently not doing - you are doing it in the template event)

[Sniper_E]

Aight... I'll check into my man. Thanks for the info! I'll go "edjucate" myself on that Plural rules stuff.

[3Di]

Aight... I'll check into my man. Thanks for the info! I'll go "edjucate" myself on that Plural rules stuff.

you language file should look like this

Code: Select all

$lang = array_merge(
    $lang, array(
        'PM_READ'            => 'Read Your',
        'PM_YOU_HAVE'        => 'You Have',
        'PM_NEW'            => 'New',
        'PM_UNREAD'            => 'Unread',
        'PM_MESSAGE'    => array(
            1    => '%d Message',
            2    => '%d Messages',
    )
));
 

now you should subscribe the event into your listener within static public function getSubscribedEvents(), create a function that reads the values like public function display_anipmnotify($event) and assign them to the template, like

Code: Select all

        $this->template->assign_vars(array(
        'L_PM_MESSAGE'                => $pm_msg_value, // this contains the (int)
        ));

.

not tested, wrote in the fly.

edit: typos

[Sniper_E]

Thanks, I'll look into it...

[Sniper_E]

Actually all that Plural rule stuff looked like more trouble than it's worth. I'm side stepping that.

I just followed phpBB's lead, "Private messages [1]" in the header and just made mine "Messages [1]"

Animated PM Notification version 1.0.1
Fist post and GitHub is updated.

[3Di]

Actually all that Plural rule stuff looked like more trouble than it's worth. I'm side stepping that.

I just followed phpBB's lead, "Private messages [1]" in the header and just made mine "Messages [1]"

Animated PM Notification version 1.0.1
Fist post and GitHub is updated.

NEVER is the only Option when it comes to Giving Up!

[Sniper_E]

NEVER is the only Option when it comes to Giving Up!

But I only looked at what it would take. I NEVER started anything so I actually didn't Give Up!

[John45]

NEVER is the only Option when it comes to Giving Up!

But I only looked at what it would take. I NEVER started anything so I actually didn't Give Up!

Would love to see an RC release, so keep trying. You'll get there.

I saw it too and it confused the poop out of me.

[Nully]

On my board, PM notification animated works ok

[3Di]

On my board, PM notification animated works ok

Yes, we are not discussing that. We are discussing about the use of some code instead of another.

[Nully]

Yes, we are not discussing that. We are discussing about the use of some code instead of another.

Because of my very bad english, I misunderstood the discussion.
Sorry

[3Di]

Yes, we are not discussing that. We are discussing about the use of some code instead of another.

Because of my very bad english, I misunderstood the discussion.
Sorry

No need to apologise. In fact we should discuss about coding elsewhere.