[CDB] Digests 3.2.11

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
colinshead
Registered User
Posts: 104
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead »

Hi Frank

I had only pasted a snippet from the link, the actual failing link is:

<a
href="https://www.forum.leisureowners.org.uk/ ... 2642"><img
src="https://www.forum.leisureowners.org.uk/ ... d=2642&t=1"
alt="" title="" /></a>

and this renders in Thunderbird and Gmail as:

see this link https://www.forum.leisureowners.org.uk/email.jpg

Changing the link to https://www.forum.leisureowners.org.uk/ ... d/test.jpg within the same <a> and all is well.

Why can't we post attachments in this forum ?

All the best

Colin
User avatar
canonknipser
Registered User
Posts: 2096
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: [RC] Digests 3.2.10

Post by canonknipser »

colinshead wrote: Mon Dec 10, 2018 11:32 am I had only pasted a snippet from the link, the actual failing link is:

<a href="https://www.forum.leisureowners.org.uk/ ... 2642"><img src="https://www.forum.leisureowners.org.uk/ ... 2&t=1"alt="" title="" /></a>
OK, that should be a proper syntax. Did you check the permissions for that specific forum? You need to have enabled guest access to attachments ("can download..."), because I don't expect Thunderbird passing the user's credentials to the board to identify the user.
The direct link to the image file bypasses the permissions system of phpBB, so maybe that's the reason for the image being presented.
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB
colinshead
Registered User
Posts: 104
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead »

Hi Frank

You are correct, allowing guest access to download files sorts the problem.

Only issue now is "can I permit access on security grounds" !!, but that's definitely my problem as forum administrator !

All the best

Colin
User avatar
MarkDHamill
Registered User
Posts: 4885
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill »

I'm wondering if there is some sort of redirection trick that would solve the problem. I'd definitely put on note on the Thunderbird forums to see if anyone has a workaround.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
colinshead
Registered User
Posts: 104
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead »

Hi Mark

Opening up 'guest' access (see Frank's posts) certainly does the trick, and as in our case only paid up forum members can get Digest e-mails, then the security issue is not overly difficult, as unless the Digest e-mails are shared with others, then the URL's will remain private to the forum user group. In any event in our case there is nothing sensitive on our forum which needs much protection.

In the wider context I think you need to warn other Digest users of the issue in the installation instructions. Unfortunately I don't see how phpBB could actually 'empower' remote email clients with the authority to access protected files. The only (and nigh on impossible) scheme I can think of is for the Digests extension to grab the files, and create plain old .jpg's or similar from them, store them somewhere and link them into the Digest e-mails !!

Thank you again for your help and guidance.

All the best

Colin
User avatar
MarkDHamill
Registered User
Posts: 4885
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill »

There may be ways to encapsulate photos inside the digest. I haven't looked into this and given that a digest can be very large I'm not sure that would make sense. But presumably encapsulated images would address the issue.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
User avatar
canonknipser
Registered User
Posts: 2096
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: [RC] Digests 3.2.10

Post by canonknipser »

colinshead wrote: Mon Dec 10, 2018 1:22 pm the Digests extension to grab the files, and create plain old .jpg's or similar from them, store them somewhere and link them into the Digest e-mails !!
No need to create any "Plain old .jpg's or similar", because the files are already there. phpBB just stores them under a unique random file name in the files-folder. You can grab the storage systems filename from the attachment table (the attachment-id is in the file.php-parameter id, the file name on the storage system is in physical_filename). If there is a thumbnail-file for images (thumbnail = 1), you can use the physical filename prepended by a string thumb_ to link the smaller image. The mime-type for the file you can grab from column mimetype to determine if you have a image (img-link) or a different sort of file (standard-a-link). The path for linking attachments directly is http://example.org/files (example.org is your boards address)
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB
LCSF082
Registered User
Posts: 9
Joined: Sat Dec 08, 2018 12:51 pm

Re: [RC] Digests 3.2.10

Post by LCSF082 »

I'm having trouble installing this extension. I am new to phpbb as well as this forum. I've never installed an extension before, so please bear with my question.

I downloaded the zip file from the first post on this thread and extracted it into a new digest folder under /ext/phpbbservices/digest. (presently in a local host environment, so the complete folder path is: C:\Website Development\apache2\htdocs\forum\ext\phpbbservices\digest). It created a sub-folder named digests-master.

When I go to ACP, I do not see the extension to enable it, nor do I see a heading for "Disabled Extensions" as described in the phpbb instrucitons (https://www.phpbb.com/extensions/installing/)

Any help would be appreciated.
User avatar
MarkDHamill
Registered User
Posts: 4885
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill »

The files are placed in /ext/phpbbservices/digests.

If you are grabbing them off the GitHub master, I found one error doing the same thing today for a client. In /acp/main_module.php, line 1568 is:

Code: Select all

					foreach (new \DirectoryIterator($path) as $file_info)
before it add:

Code: Select all

					$path = $this->phpbb_root_path . 'store/phpbbservices/digests';
Placed properly, it should appear on the list of extensions and you can thus enable it.

The procedure for installing extension is right on the extensions page, but if you need more there's this page:

https://www.phpbb.com/extensions/installing/
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
LCSF082
Registered User
Posts: 9
Joined: Sat Dec 08, 2018 12:51 pm

Re: [RC] Digests 3.2.10

Post by LCSF082 »

I made the corrections you suggested in main_module.php. No change. I see no extensions listed in the ACP extension management area other than VigLink. I moved the extracted files from: C:\Website Development\apache2\htdocs\forum\ext\phpbbservices\digest\digests-master
to: C:\Website Development\apache2\htdocs\forum\ext\phpbbservices\digest
Also no change. I still see no extension listed other than VigLink.

BTW, I downloaded the extension from the link in the very first posting of this thread.

Step 3 in https://www.phpbb.com/extensions/installing/ states:
3. Enable
Once the extension has been uploaded, navigate in the board's ACP to Customise -> Manage extensions. You should see your recently uploaded extension listed under "Disabled Extensions". Simply click its "Enable" button and installation is complete!

I do not see any heading labled "Disabled Extensions" anywhere with any items listed.

My installation is phpbb version 3.2.4 in a localhost environment accessed via: http://localhost:81/forum/
The php config.php file is located in: C:\Website Development\apache2\htdocs\forum

Any other suggestions?
User avatar
MarkDHamill
Registered User
Posts: 4885
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill »

The problem is the digest-master directory is not used. GitHub creates this because of the way the project is laid out in GitHub. Move the files in it up to the parent folder and then remove digest-master folder which is not needed.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
Praggle
Registered User
Posts: 64
Joined: Thu Feb 26, 2015 6:07 pm

Re: [RC] Digests 3.2.10

Post by Praggle »

Maybe he is also still missing the "s" at the end of digests: \ext\phpbbservices\digests\
LCSF082
Registered User
Posts: 9
Joined: Sat Dec 08, 2018 12:51 pm

Re: [RC] Digests 3.2.10

Post by LCSF082 »

Praggle,
That was it. I missed the trailing 's'. Got it installed. So far so good.
Thank You
LCSF082
Registered User
Posts: 9
Joined: Sat Dec 08, 2018 12:51 pm

Re: [RC] Digests 3.2.10

Post by LCSF082 »

All installed and working. It works great. Thank you for your effort.

I do believe I have some settings incorrect for what I would like. Is there another thread or FAQ area that I can search easily to help me out or should I just post my novice questions on this thread? My first issue is that I thought I had setup the user for 'daily' digests, however the user received a notification email immediately after a new topic was created on a board they were 'subscribed' to. I would like to have the notifications sent out no more frequently than once per day for most forums. Although for some forums the immediate notification might be useful. I'm not sure which setting needs to be changed to accomplish this.
User avatar
MarkDHamill
Registered User
Posts: 4885
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill »

Digests are not the same as phpBB notifications. You can request a feature change to phpBB's notification system, but I believe it sends just one email when a new topic or reply is posted and waits for you to visit the board before sending any more.
Need phpBB services or a phpBB consultant? I offer most phpBB services. Getting lost managing phpBB? Buy my book, Mastering phpBB Administration. Covers through phpBB 3.3.7. eBook and paper versions available.
Locked

Return to “Extensions in Development”