[RC] Digests 3.2.10

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Hippie459MN
Registered User
Posts: 893
Joined: Mon Oct 15, 2007 10:13 pm
Location: Minnesota, USA
Contact:

Re: [RC] Digests 3.2.6

Post by Hippie459MN » Sat Jun 02, 2018 11:38 pm

Ran into a slight issue with 3.2.7. When the extension is enabled, it messes up the layout in the entire ACP.

Without Digests enabled:

Image

Image

With Digests enabled:

Image

Image

:D

User avatar
MarkDHamill
Registered User
Posts: 3508
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.6

Post by MarkDHamill » Sat Jun 02, 2018 11:45 pm

Looks like this is some issue with your board notices extension. Digests is kept separate from it.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
Hippie459MN
Registered User
Posts: 893
Joined: Mon Oct 15, 2007 10:13 pm
Location: Minnesota, USA
Contact:

Re: [RC] Digests 3.2.6

Post by Hippie459MN » Sat Jun 02, 2018 11:53 pm

Nope, I disabled just about every extension installed but every time I enabled Digests it messes up all the formatting everywhere in the ACP, not just in the extensions tab.

Also, this is on phpBB 3.2.2

User avatar
MarkDHamill
Registered User
Posts: 3508
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.6

Post by MarkDHamill » Sat Jun 02, 2018 11:56 pm

Shouldn't as everything is kept in a separate namespace. I'll have to do some checking. Thanks.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
3Di
Registered User
Posts: 13000
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [RC] Digests 3.2.6

Post by 3Di » Sun Jun 03, 2018 1:27 am

MarkDHamill wrote:
Sat Jun 02, 2018 11:56 pm
Shouldn't as everything is kept in a separate namespace. I'll have to do some checking. Thanks.
You are spreading your ACP's CSS all over the native phpBB one this way:
https://github.com/MarkDHamill/digests/ ... ppend.html

Solution should be deleting the above event (the folder since you are using only it) and edit this one:
https://github.com/MarkDHamill/digests/ ... ts.html#L2

find

Code: Select all

{% INCLUDEJS '@phpbbservices_digests/acp_digests.js' %}
replace with

Code: Select all

{# Includes ACP - CSS #}
{% if not definition.INCLUDED_ACPDIGESTSCSS %}
	{% INCLUDECSS '@phpbbservices_digests/acp_digests.css' %}
	{% DEFINE INCLUDED_ACPDIGESTSCSS = true %}
{% endif %}

{# Includes ACP - JS #}
{% if not definition.INCLUDED_ACPDIGESTSJS %}
	{% INCLUDEJS '@phpbbservices_digests/acp_digests.js' %}
	{% DEFINE INCLUDED_ACPDIGESTSJS = true %}
{% endif %}
and why not, purge the cache.

Written on the fly.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate

:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
Hippie459MN
Registered User
Posts: 893
Joined: Mon Oct 15, 2007 10:13 pm
Location: Minnesota, USA
Contact:

Re: [RC] Digests 3.2.6

Post by Hippie459MN » Sun Jun 03, 2018 2:06 am

3Di, that fixed it here. Thank you. :)

User avatar
MarkDHamill
Registered User
Posts: 3508
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.6

Post by MarkDHamill » Sun Jun 03, 2018 2:12 am

Thank you so much 3Di. That is pretty obscure stuff!
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
MarkDHamill
Registered User
Posts: 3508
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.6

Post by MarkDHamill » Sun Jun 03, 2018 9:25 pm

3Di, I included your fix. Thanks again. A client job has kept me busy.

I don't wholly understand the syntax of the changes you made but clearly you have studied TWIG syntax and I haven't.

phpBB events can be a bit dangerous then as they kind of break the paradigm that everything in an extension should not affect the base code. :shock:
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
3Di
Registered User
Posts: 13000
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [RC] Digests 3.2.6

Post by 3Di » Sun Jun 03, 2018 11:08 pm

MarkDHamill wrote:
Sun Jun 03, 2018 9:25 pm
3Di, I included your fix. Thanks again. A client job has kept me busy.

I don't wholly understand the syntax of the changes you made but clearly you have studied TWIG syntax and I haven't.

phpBB events can be a bit dangerous then as they kind of break the paradigm that everything in an extension should not affect the base code. :shock:
No probs.

The issue is it seems you misunderstood what I said here
3Di wrote:
Sun Jun 03, 2018 1:27 am
Solution should be deleting the above event (the folder since you are using only it) and edit this one:
https://github.com/MarkDHamill/digests/ ... ts.html#L2
You should delete the whole folder digests/adm/style/event/ which only contains acp_overall_header_head_append.html
since as per its name that event adds assets within the `<head>` tags in the ACP.

And use the ^^above^^ solution: include your assets only within your own custom ACP template file adm/style/acp_digests.html and any other custom template which needs your CSS/JS.

The inclusion I gave you is the same as per the Docs - key concepts:
https://area51.phpbb.com/docs/dev/3.2.x ... -css-files
With a Twig sintax which is basically the same as per the one explained there.
Test if the script your extension wants to include is already defined, and if not, then include your script and define the script.
As it is now you are attempting to include the JS twice, for example.

On a side note I would create a template switch like 'S_IN_DIGEST' = true, in your ACP module(s) to use to surround the inclusions itself.

{% if S_IN_DIGEST %} inclusions {% endif %}
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate

:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
MarkDHamill
Registered User
Posts: 3508
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.6

Post by MarkDHamill » Mon Jun 04, 2018 12:12 am

Doh! Thanks again, 3Di. We extension authors appreciate your great expertise and in this case, your patience too!
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
3Di
Registered User
Posts: 13000
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [RC] Digests 3.2.6

Post by 3Di » Mon Jun 04, 2018 7:41 am

MarkDHamill wrote:
Mon Jun 04, 2018 12:12 am
Doh! Thanks again, 3Di.
No probs. Looks good to me, now.

I have though 2 comments awaiting for you onto your last commit, please check:
https://github.com/MarkDHamill/digests/ ... #r29228725
https://github.com/MarkDHamill/digests/ ... #r29228755
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate

:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
MarkDHamill
Registered User
Posts: 3508
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.6

Post by MarkDHamill » Mon Jun 04, 2018 1:59 pm

Looking at the code some more, it turns out I used the ACP .css file for only two modules, Edit Subscribers and Balance Load. And I use the ACP .js file for only Edit Subscribers. So I refactored 3Di's code and also indented the template commands.

https://github.com/MarkDHamill/digests/ ... fc4e36406e
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

AlexHowser
Registered User
Posts: 3
Joined: Fri Jan 26, 2018 4:18 pm

Re: [RC] Digests 3.2.6

Post by AlexHowser » Mon Jun 04, 2018 4:07 pm

Is it possible to somehow create a template on which forums users should have subscriptions on? I have some forums i dont want anybody to have updates on, but its verry exhausting to manually set this for each and every user :(

User avatar
MarkDHamill
Registered User
Posts: 3508
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.6

Post by MarkDHamill » Mon Jun 04, 2018 4:38 pm

This is a feature built into Digests years ago based on user feedback. Under General settings, look for the field "Always exclude these forums" near the bottom of the page.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

LNA
Registered User
Posts: 3
Joined: Fri Jun 08, 2018 3:36 pm

Re: [RC] Digests 3.2.6

Post by LNA » Fri Jun 08, 2018 3:41 pm

Hello,

and many thanks for this extension.
I've just installed 3.2.7 but I have an error message when I try to activate Digest : "phpbbservices_digests_page_url not found"

Actually the complete message in french is

Une erreur est survenue lors de la requête et une exception a été exécutée. Les modifications effectuées avant que l’erreur ne survienne ont été restaurées au mieux mais vous devriez vérifier que votre forum fonctionne correctement.

La configuration « phpbbservices_digests_page_url » est introuvable.


Could you help me ?

Thank you

Elena

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: jasolo, skybound and 23 guests