[RC] Digests 3.2.10

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Thu Nov 29, 2018 11:49 pm

Thank you! Is this link persistent or temporary?
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Fri Nov 30, 2018 1:45 am

Colin, it takes a bit of experimenting sometimes to program a cron correctly. The output provided by the cron usually gives a clue to how to fix the issue. One common thing I see: if your forum uses https, you often have to program curl to not try to check the certificate. Use the -k or --insecure curl option. Also sometimes the web server will refuse to do the work if you don't tell it you are a browser, so the -A flag is often required and you need to pass a string. See https://wiki.phpbb.com/PhpBB3.1/RFC/Mod ... ystem_cron
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

colinshead
Registered User
Posts: 48
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead » Fri Nov 30, 2018 9:28 am

Hi Mark

Thanks.

My first attempt at a curl cron string did not work, so will experiment.

However good news is that digests are being sent, albeit dependent on users 'waking up' phpBB until the 15 minute Cron task works properly.

All the best

Colin

kamaleon
Registered User
Posts: 416
Joined: Tue Sep 09, 2014 9:47 am
Location: Barcelona

Re: [RC] Digests 3.2.10

Post by kamaleon » Fri Nov 30, 2018 9:50 am

MarkDHamill wrote:
Thu Nov 29, 2018 11:49 pm
Thank you! Is this link persistent or temporary?
I have no problem in keeping it, but maybe you could add it to some repository.

Is there a way to test it? With all the variables and all the things you have in there, maybe I did a mistake... Or missed something.

How to validate the translation?

Eichohrkater
Registered User
Posts: 2
Joined: Fri Nov 30, 2018 10:23 am

Re: [RC] Digests 3.2.10

Post by Eichohrkater » Fri Nov 30, 2018 1:48 pm

Thanks for this very nice work.

But for me when trying „Manually run the mailer“ and setting switch „Clear the store“ to Yes, it runs in following Error:

Code: Select all

Fatal error: Uncaught RuntimeException: Directory name must not be empty. in /var/www/vhosts/xxx/httpdocs/forum/ext/phpbbservices/digests/acp/main_module.php:1565 Stack trace: #0 /var/www/vhosts/xxx/httpdocs/forum/ext/phpbbservices/digests/acp/main_module.php(1565): DirectoryIterator->__construct('') #1 /var/www/vhosts/xxx/httpdocs/forum/includes/functions_module.php(676): phpbbservices\digests\acp\main_module->main('\\phpbbservices\\...', 'digests_test') #2 /var/www/vhosts/xxx/httpdocs/forum/adm/index.php(82): p_master->load_active() #3 {main} thrown in /var/www/vhosts/xxx/httpdocs/forum/ext/phpbbservices/digests/acp/main_module.php on line 1565

There is also a small mistake in the German Translation.
In Line 51 there are /' what results in Error. Right would be \'
Sadly, I did not found contact data’s of the translator to inform him myself.


And is there any possibility to disable the digest for specific usergroops or users?
I would prefer to not allow it to fresh registered users.

Thanks
Last edited by bonelifer on Fri Nov 30, 2018 7:59 pm, edited 1 time in total.
Reason: Added code tags. PLEASE use code tags where appropriate.

User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Fri Nov 30, 2018 2:40 pm

You can test it by copying the files into /ext/phpbbservices/digests/language/es. Presumably you have the Spanish language pack already installed and enabled. Your board language should be Spanish, change in the User Control Panel if you allow more than one language. Then look at each panel in the ACP and UCP related to digests and make sure the translations are correct and render. Also create digests to make sure they are correct in both HTML and text digests.

If you are new to this, it's possible to introduce syntax errors into the translation so it doesn't parse correctly in PHP. The manifestation of this is often a white screen.

There are online tools that will check to see if your PHP is syntactically correct. Here is one:

https://phpcodechecker.com
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

kamaleon
Registered User
Posts: 416
Joined: Tue Sep 09, 2014 9:47 am
Location: Barcelona

Re: [RC] Digests 3.2.10

Post by kamaleon » Fri Nov 30, 2018 2:54 pm

Will try it.

There were a lot of “ and ” and some other characters like that.

User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Fri Nov 30, 2018 3:56 pm

Those provide single or double right and left quotes. The phpBB extension review team is quite picky and want slanted embedded quotes.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

kamaleon
Registered User
Posts: 416
Joined: Tue Sep 09, 2014 9:47 am
Location: Barcelona

Re: [RC] Digests 3.2.10

Post by kamaleon » Fri Nov 30, 2018 10:06 pm

Yeah I imagined.

Dunno if accents need a special character or not... There are many of them in Spanish.

kamaleon
Registered User
Posts: 416
Joined: Tue Sep 09, 2014 9:47 am
Location: Barcelona

Re: [RC] Digests 3.2.10

Post by kamaleon » Sat Dec 01, 2018 9:37 am

In General Settings there is Minimum topic post count popularity, then in User default settings we also have Minimum value for popularity.

Is that normal?

A bit confusing for me...

colinshead
Registered User
Posts: 48
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10 - Images ?

Post by colinshead » Sat Dec 01, 2018 12:14 pm

Hi Mark

Thanks to your help the Digest extension is firing on almost all cylinders, including the System Cron.

One issue - In Digest e-mails (styled) no thumbnails or associated links appear. There is simply a hashed line around where the thumbnail should be, with the image details within, e.g. file size etc. I have User defaults set to permit images, and it is also allowed in the UCP settings for the user. Have tried various e-mail clients, same result, so does not seem to be an issue with the client.

Thumbnails and images work fine on the forum itself. Am still using link to ImageMagick on the forum.

Any thoughts please, do I need to load any additional to process the images ?

You have one minor typo on the ACP General Settings page, where setting From email address, 'contract' should be 'contact'.

All the best

Colin

User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Sat Dec 01, 2018 1:11 pm

This is considered remote content. Most email clients will require you to give them permission to retrieve these images. It's generally a one time thing.

You can use the feature of the manual mailer to write the digests to the store/phpbbservices/digests folder. Download them and look at them with a browser in local mode. If the problem exists there it suggests a different problem, perhaps your server does not allow hot linking.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

colinshead
Registered User
Posts: 48
Joined: Sun Mar 29, 2015 11:37 am

Re: [RC] Digests 3.2.10

Post by colinshead » Sat Dec 01, 2018 1:31 pm

Hi Mark

You are spot on, the images etc, are all present and correct in a HTML download.

All the best

Colin

User avatar
axe70
Registered User
Posts: 113
Joined: Sun Nov 17, 2002 10:55 am
Location: Italy
Contact:

Re: [RC] Digests 3.2.10

Post by axe70 » Wed Dec 05, 2018 11:57 am

Thank you Mark for this nice Digests phpBB extension.

I experienced that was not possible to change preferences for users on ucp > Digests > Forum Selections about subscribed forums digests: unique possibility was to setup all or nothing.
I had so to change something in /ext/phpbbservices/digests/ucp/main_module.php
to make it work correctly, due to the fact that the $elt_fields var passed empty by the way.
Anybody experienced the same?

Substantially i fixed it, just changing code somewhere into something like this raw one:
on /ucp/main_module.php
where:

Code: Select all

			if (($all_forums !== 'on') && (trim($digest_type) !== constants::DIGESTS_BOOKMARKS))
					{
						$elt_fields = $this->request->variable('elt', array(''));
changed into:

Code: Select all

					//if (($all_forums !== 'on') && (trim($digest_type) !== constants::DIGESTS_BOOKMARKS))
					if ((trim($digest_type) !== constants::DIGESTS_BOOKMARKS))
					{
						$elt_fields = $this->request->variable('elt', array(''));
						
// START FIX FOR CORRECT GRAB THE EMPTY PASSED $this->request->variable('elt', array(''));
// coming from form on ucp_digests.html
$this->request->enable_super_globals();
$w3req = $_REQUEST;
$elt_fields = array();
foreach($w3req as $k => $v){
	if( strstr($k,'elt') && preg_match('/^elt_[0-9]+_[0-9]+$/u',$k) && $v == 'on' ){
	  $elt_fields[$k] = $v;
}
}
$this->request->disable_super_globals();
unset($w3req);
// should maybe check if forum ID exist for more security? it will be surely an int val by the way ...
// END FIX		
why $elt_fields = $this->request->variable('elt', array('')); ever empty, or never passed?
I've find out more easy and speedy this because is a dirty trick that work. Any suggestion?

code fixed, removed last
$elt_fields = $this->request->variable('elt', array(''));

p.s the user have to disable and re-enable the option for this to work (i've not check why), i've just change via db values to fit for my needs
Last edited by axe70 on Wed Dec 05, 2018 6:13 pm, edited 7 times in total.

User avatar
MarkDHamill
Registered User
Posts: 3553
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: [RC] Digests 3.2.10

Post by MarkDHamill » Wed Dec 05, 2018 1:05 pm

I'm not sure exactly what you are trying to accomplish, but the Edit subscribers features in the ACP for Digests allows an administrator to change any forum subscriptions for a user. You have to click on the + icon to get these details.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: andares, Gubkin, Hippie459MN, igorbond, jackennils, kamaleon, MarkDHamill, Praggle, Tbot [Bot] and 23 guests