[RC] Adsense & Ads for phpBB

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Naguissa
Registered User
Posts: 259
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [RC] Adsense & Ads for phpBB

Post by Naguissa » Wed Jan 31, 2018 3:28 pm

I've found a problematic css bit at phpbbads.css:

Code: Select all

.phpbb-ads-center > :first-child {
	display: inline-block;
	max-width: 100%;
}
This makes JS ads to interpret 1st tag as a block element (at least on Firefox and Chrome).

There are two ways to solve it:
- Prepend a span open/close tag before JS.
- Remove it from CSS file, but it makes ads to fit on screen.

User avatar
Stoker 4.0
Registered User
Posts: 1480
Joined: Sun Feb 13, 2011 1:33 pm
Location: Funen, Denmark
Name: Ulrik Christensen
Contact:

Re: [RC] Adsense & Ads for phpBB

Post by Stoker 4.0 » Wed Jan 31, 2018 3:42 pm

andreask wrote:
Wed Jan 31, 2018 2:48 pm
Stoker 4.0 wrote:
Wed Jan 31, 2018 2:11 pm
andreask wrote:
Wed Jan 31, 2018 11:09 am
Stoker,

I've enabled the page-level ads in adsense(and added the code) but when I do the testing #googleads I get a white page...
Any suggestions?

I guess you can also see by yourself forum.mens-only.gr

Thank you for your time
Works fine here
Any idea why it does not work for me?
I use both chrome and Firefox.
Mobile and desktop.
Always same result :/
I got this visiting your page: https://imgur.com/a/V6WnG
Naguissa wrote:
Wed Jan 31, 2018 3:28 pm
I've found a problematic css bit at phpbbads.css:

Code: Select all

.phpbb-ads-center > :first-child {
	display: inline-block;
	max-width: 100%;
}
This makes JS ads to interpret 1st tag as a block element (at least on Firefox and Chrome).

There are two ways to solve it:
- Prepend a span open/close tag before JS.
- Remove it from CSS file, but it makes ads to fit on screen.
That code doesnt belong to this EXT ;)

User avatar
Naguissa
Registered User
Posts: 259
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [RC] Adsense & Ads for phpBB

Post by Naguissa » Wed Jan 31, 2018 3:47 pm

Naguissa wrote:
Wed Jan 31, 2018 3:28 pm
I've found a problematic css bit at phpbbads.css:

Code: Select all

.phpbb-ads-center > :first-child {
	display: inline-block;
	max-width: 100%;
}
This makes JS ads to interpret 1st tag as a block element (at least on Firefox and Chrome).

There are two ways to solve it:
- Prepend a span open/close tag before JS.
- Remove it from CSS file, but it makes ads to fit on screen.
That code doesnt belong to this EXT ;)
[/quote]


You are true, I'm sorry. I thought it was same extension. As there was people talking about non-working ads, I thought that could be the cause, but I've messed out.

andreask
Registered User
Posts: 496
Joined: Fri Feb 27, 2009 6:13 pm
Name: Andreas

Re: [RC] Adsense & Ads for phpBB

Post by andreask » Wed Jan 31, 2018 4:48 pm

This is what I see through firefox now...
Image

And this is from chrome...
Image

page level ads is enabled....
I guess it's the 2nd case of the problems mentioned in the chrome capture... (?)
Here is what I am working on right now...
Inactive User Manager for phpBB
Give it a try...
If you would like to buy me a bier ;) for my work I will drink it on a hot summer day and thank you!!!

User avatar
Stoker 4.0
Registered User
Posts: 1480
Joined: Sun Feb 13, 2011 1:33 pm
Location: Funen, Denmark
Name: Ulrik Christensen
Contact:

Re: [RC] Adsense & Ads for phpBB

Post by Stoker 4.0 » Wed Jan 31, 2018 4:53 pm

Is the page level ads displayed?
Its is on my sites.

Google instructs to put the script inside the head tag. But thats not the way we do this anymore.
Its added in the footer.
You can manually put it inside the head tag if you like that better.

andreask
Registered User
Posts: 496
Joined: Fri Feb 27, 2009 6:13 pm
Name: Andreas

Re: [RC] Adsense & Ads for phpBB

Post by andreask » Wed Jan 31, 2018 5:02 pm

Yes it is enabled and yes they show fine in your sites... :(
Here is what I am working on right now...
Inactive User Manager for phpBB
Give it a try...
If you would like to buy me a bier ;) for my work I will drink it on a hot summer day and thank you!!!

andreask
Registered User
Posts: 496
Joined: Fri Feb 27, 2009 6:13 pm
Name: Andreas

Re: [RC] Adsense & Ads for phpBB

Post by andreask » Wed Jan 31, 2018 5:08 pm

I just used the official phpbb advertisement manager for the page-level ads.
And it's working (I think).
I used the "above header" position, I don't know if that matters though...
So I don't know what the problem is perhaps a conflict with another ext?
Here is what I am working on right now...
Inactive User Manager for phpBB
Give it a try...
If you would like to buy me a bier ;) for my work I will drink it on a hot summer day and thank you!!!

User avatar
Stoker 4.0
Registered User
Posts: 1480
Joined: Sun Feb 13, 2011 1:33 pm
Location: Funen, Denmark
Name: Ulrik Christensen
Contact:

Re: [RC] Adsense & Ads for phpBB

Post by Stoker 4.0 » Wed Jan 31, 2018 5:40 pm

andreask wrote:
Wed Jan 31, 2018 5:08 pm
I just used the official phpbb advertisement manager for the page-level ads.
And it's working (I think).
I used the "above header" position, I don't know if that matters though...
So I don't know what the problem is perhaps a conflict with another ext?
Then IT probabky Works in your site too?
I get the same message in my site using #gogleads
And I explained in my previous post why and how to solve it og You think its needs fixing

andreask
Registered User
Posts: 496
Joined: Fri Feb 27, 2009 6:13 pm
Name: Andreas

Re: [RC] Adsense & Ads for phpBB

Post by andreask » Wed Jan 31, 2018 5:55 pm

I don't get the message when I'm using the other ext, only when I use it with your ext. And it actually shows ads.
Weird, when I was using your ext, whenever there was a pagelevel ad the forum would show only a white page.
With the other ext I don't have such problem (so far).
Please understand that I want to figure out why I have this behavior and fix it.I do not blame you or your ext.
I love your ext, I've been using it since the beta release and I will continue to do so because it does the job!

I do not want to modify core files, especially if there is a way to do it via ext.
Here is what I am working on right now...
Inactive User Manager for phpBB
Give it a try...
If you would like to buy me a bier ;) for my work I will drink it on a hot summer day and thank you!!!

User avatar
Stoker 4.0
Registered User
Posts: 1480
Joined: Sun Feb 13, 2011 1:33 pm
Location: Funen, Denmark
Name: Ulrik Christensen
Contact:

Re: [RC] Adsense & Ads for phpBB

Post by Stoker 4.0 » Wed Jan 31, 2018 6:05 pm

andreask wrote:
Wed Jan 31, 2018 5:55 pm
I don't get the message when I'm using the other ext, only when I use it with your ext. And it actually shows ads.
Weird, when I was using your ext, whenever there was a pagelevel ad the forum would show only a white page.
With the other ext I don't have such problem (so far).
Please understand that I want to figure out why I have this behavior and fix it.I do not blame you or your ext.
I love your ext, I've been using it since the beta release and I will continue to do so because it does the job!

I do not want to modify core files, especially if there is a way to do it via ext.
Oh, i thought the white page was only when you used #googleads :mrgreen:

User avatar
Bruno36
Registered User
Posts: 287
Joined: Fri Mar 02, 2007 2:16 pm
Location: france
Name: bruno astie
Contact:

Re: [RC] Adsense & Ads for phpBB

Post by Bruno36 » Wed Jan 31, 2018 8:01 pm

Stoker 4.0 wrote:
Wed Jan 31, 2018 2:44 pm
Bruno36 wrote:
Wed Jan 31, 2018 2:13 pm
A video is better than a long speech
https://www.youtube.com/watch?v=ooaUd4_ ... e=youtu.be
Would have been much easier if you have explained that the adblock detector didnt work in Edge instead of claiming it doesnt work at all ;)
But now you actually have explained the Edge bug I can confirm that there is a bug when using Edge and Adblock
because my english is very bad, I'm really sorry :oops:
Excuse me for my poor English, I speak french
Bruno36

Harrison76
Registered User
Posts: 42
Joined: Wed Jul 12, 2017 7:25 am

Re: [RC] Adsense & Ads for phpBB

Post by Harrison76 » Wed Feb 14, 2018 11:13 am

hello, this plugin works very well.
If, however, instead of a adsense banner, I want to insert an image banner with a link to the site, and that it is all responsive, what code should I enter? graces

User avatar
Stoker 4.0
Registered User
Posts: 1480
Joined: Sun Feb 13, 2011 1:33 pm
Location: Funen, Denmark
Name: Ulrik Christensen
Contact:

Re: [RC] Adsense & Ads for phpBB

Post by Stoker 4.0 » Wed Feb 14, 2018 4:46 pm

Harrison76 wrote:
Wed Feb 14, 2018 11:13 am
hello, this plugin works very well.
If, however, instead of a adsense banner, I want to insert an image banner with a link to the site, and that it is all responsive, what code should I enter? graces
use the html code for image and url

Harrison76
Registered User
Posts: 42
Joined: Wed Jul 12, 2017 7:25 am

Re: [RC] Adsense & Ads for phpBB

Post by Harrison76 » Wed Feb 14, 2018 5:21 pm

Stoker 4.0 wrote:
Wed Feb 14, 2018 4:46 pm
use the html code for image and url
I tried an iframe, but it was not clickable: do you have an example of a working code?

Harrison76
Registered User
Posts: 42
Joined: Wed Jul 12, 2017 7:25 am

Re: [RC] Adsense & Ads for phpBB

Post by Harrison76 » Wed Feb 14, 2018 5:31 pm

now I have tried this, which from pc is okay, but is not responsive so from cell phone is cut off

Code: Select all

<a href="https://www.forumelettrico.it/"><img src="https://www.forumelettrico.it/banner_prova_jeep.jpg"></a>
How can I solve it?
graces

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: canonknipser, Hippie459MN, igorbond, jackennils, kamaleon, Praggle, Restless Rancor, Tbot [Bot], webdevilopers and 33 guests