[CDB] Best Answer

[kinerity]

Using what release? I just pushed an update about 2 days ago that addressed this.

[SalazarAG]

There is a time I had a SQL error when activated the extension. How good it was fixed. great extension, my congratulations!

[SalazarAG]

ignore my previous comment ...

I installed, tested and after some time I have this error again

Code: Select all

	
Clique aqui para voltar ao índice	
Erro Geral
SQL ERROR [ mysqli ]

Not unique table/alias: 'p' [1066]

SQL

SELECT f.*, ft.mark_time, u.user_avatar, u.user_avatar_type, u.user_avatar_width, u.user_avatar_height, t.topic_id AS forum_last_post_topic_id, t.bestanswer_id, t.topic_id AS forum_last_post_topic_id FROM (phpbb_forums f) LEFT JOIN phpbb_forums_track ft ON (ft.user_id = 2 AND ft.forum_id = f.forum_id) LEFT JOIN phpbb_users u ON (u.user_id = f.forum_last_poster_id AND forum_type != 0) LEFT JOIN phpbb_posts p ON (f.forum_last_post_id = p.post_id) LEFT JOIN phpbb_topics t ON (t.topic_id = p.topic_id) LEFT JOIN phpbb_posts p ON (f.forum_last_post_id = p.post_id) LEFT JOIN phpbb_topics t ON (t.topic_id = p.topic_id) ORDER BY f.left_id

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 855
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/includes/functions_display.php
LINE: 151
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/index.php
LINE: 75
CALL: display_forums()

Por favor, contate o administrador ou webmaster deste fórum: lucas_vinicius98@live.com
Powered by phpBB® Forum Software © phpBB Limited 

[kinerity]

That's cause by this function. Can you try replacing that entire function with the one below and let me know if it works? I'm not on my normal development computer.

Code: Select all

[removed]

If that one doesn't work, give this one a go.

Code: Select all

[removed]

[kasimi]

The code on GitHub looks fine to me.

• $sql_ary['LEFT_JOIN'][] .= array(...); won't work as .= is only applicable to strings.

• Code: Select all

  $sql_ary['FROM'][] = array(
      POSTS_TABLE     => 'p',
      TOPICS_TABLE    => 't',
  ); 

  This would result in the array below which doesn't look quite right.
  

  Code: Select all

  array(
  	FORUMS_TABLE		=> 'f',
  	array(
  		POSTS_TABLE     => 'p',
  		TOPICS_TABLE    => 't',
  	)
  );

  This should work:
  

  Code: Select all

  $sql_ary['FROM'] = array_merge($sql_ary['FROM'], array(
      POSTS_TABLE     => 'p',
      TOPICS_TABLE    => 't',
  )); 

Apart from the above, in the SQL error there's a left join on the phpbb_users table which neither happens in phpBB's display_forums() function nor in this extension, so it's likely that there's a conflict with another extension that adds the duplicate left joins on the phpbb_posts and phpbb_topics table.

[SalazarAG]

I will try it.

But if it can be a conflict, I think it has to do with the Topic Count (which counts the topics of users). This extension has been a problem for me while I need a lot of it.

[kinerity]

• $sql_ary['LEFT_JOIN'][] .= array(...); won't work as .= is only applicable to strings.

Ah, you're right. I had a brain fart there.

the SQL error there's a left join on the phpbb_users table which neither happens in phpBB's display_forums() function nor in this extension, so it's likely that there's a conflict with another extension

I missed this. Thanks for pointing it out. I'll leave the code the way it is.

[SalazarAG]

I tried the codes and did not work!

I installed the extension in a new forum and the error did not occur. It seems to be a conflict with some other extension even. But they are many, it is difficult to find.

[kasimi]

But they are many, it is difficult to find.

Try to disable those that deal with avatars.

[SalazarAG]

But they are many, it is difficult to find.

Try to disable those that deal with avatars.

I disabled "Last post avatar" and the erros appears changed

Code: Select all

Erro Geral
SQL ERROR [ mysqli ]

Not unique table/alias: 'p' [1066]

SQL

SELECT f.*, ft.mark_time, t.topic_id AS forum_last_post_topic_id, t.bestanswer_id, t.topic_id AS forum_last_post_topic_id FROM (phpbb_forums f) LEFT JOIN phpbb_forums_track ft ON (ft.user_id = 2 AND ft.forum_id = f.forum_id) LEFT JOIN phpbb_posts p ON (f.forum_last_post_id = p.post_id) LEFT JOIN phpbb_topics t ON (t.topic_id = p.topic_id) LEFT JOIN phpbb_posts p ON (f.forum_last_post_id = p.post_id) LEFT JOIN phpbb_topics t ON (t.topic_id = p.topic_id) ORDER BY f.left_id

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 855
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/includes/functions_display.php
LINE: 151
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/index.php
LINE: 75
CALL: display_forums()

[kasimi]

Looks like there's another extension that adds t.topic_id AS forum_last_post_topic_id as well as those two duplicate left joins. Try to disable any extension that works with data from a forum's last post.

I'll leave the code the way it is.

You could try to only add the left joins if they aren't already present. I'm not sure if that's the most reliable way though.

Code: Select all

if (!$this->has_left_join($sql_ary['LEFT_JOIN'], POSTS_TABLE))
{
    $sql_ary['LEFT_JOIN'][] = array(
        'FROM'    => array(POSTS_TABLE => 'p'),
        'ON'    => 'f.forum_last_post_id = p.post_id',
    );
} 

... and the same for the TOPICS_TABLE. Here's the has_left_join() function:

Code: Select all

private function has_left_join($haystack, $needle)
{
    foreach ($haystack as $left_join)
    {
        if (isset($left_join['FROM'][$needle]))
        {
            return true;
        }
    }

    return false;
} 

[kinerity]

Looks like there's another extension that adds t.topic_id AS forum_last_post_topic_id

That line is probably going to change. I don't think it's needed, but I need to test it out. As a matter of fact, that whole function will probably change.

[SalazarAG]

Hello again!

The conflict is with the extension [pre]fixed.

I do not know how to solve, but the two extensions are useful.

[kinerity]

I actually just pushed an update. See if it solves your problem. It's a variation of kasimi's code.

[SalazarAG]

Updated and the problem is solved!

Thank kinerity!