[3.1][3.2][RC] PhpBB IUM (Inactive User Manager/reminder)

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
User avatar
Hartenheer
Registered User
Posts: 776
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by Hartenheer » Mon Oct 24, 2016 11:10 am

The latest version is 0.9.3?
If I download I get PHPBB_IUM-master.

It is a nice extension
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

andreask
Registered User
Posts: 533
Joined: Fri Feb 27, 2009 6:13 pm
Name: Andreas

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by andreask » Mon Oct 24, 2016 4:39 pm

potku wrote:
andreask wrote: For the topics.
in andreask/ium/classes/reminder.php find:
...
These have probably changed, right?

By the way, I really like the fact that you can send test e-mails. :)
Yes it has, just a bit.

in andreask/ium/classes/reminder.php find:

Code: Select all

foreach ($topics as $item)
		{
			$topic_links .= PHP_EOL;
			$topic_links .= PHP_EOL;
			$topic_links .= '"' . $item['topic_title'] . '"' . PHP_EOL;
replace with:

Code: Select all

foreach ($topics as $item)
		{
			$topic_links .= PHP_EOL;
			$topic_links .= PHP_EOL;
			$topic_links .= $item['topic_title'] . PHP_EOL;
You mean the template e-mail to admin? Yes I had that in my mind for a while to do it. Thanks!
potku wrote:Sounds good! :)

Would there be a way to exclude certain forums or pick topics from certain forums only?
I actually think that this would be a very good addition. Let me see what I can do for it.
I guess that if there will be something it will be for the forums and subforums (categories and forums NOT for topics).
whocarez wrote: Feature request:
a log entry for sent emails to members not only for "SENT REMINDER TO ADMIN".
Something like that: "Sent xy reminders" or "Sent reminders to x, y, z ..."
It is already there. you should see in admin logs a similar line like this one...

Code: Select all

admin 	192.168.1.107 	23 Oct 2016, 18:00 	{10 reminders were sent.}
It needs SENT_REMINDERS and it is in language/en/log.php
Hartenheer wrote:The latest version is 0.9.3?
If I download I get PHPBB_IUM-master.

It is a nice extension
Bedankt Willem,

The version is 0.9.5 and you can download it from here...

https://github.com/andreaskou/PHPBB_IUM ... 5-beta.zip

-------------------------------------------------------------------------------------------------------------
I found a new bug that effects the list of inactive users (not the ext overall).
The list shows a user line with no username.
This is because this user is newly registered and the ext's db table is not updated.
If the user will stay inactive and a reminder will be sent to him this will fix the problem.
If the user will stay active this will remain.

I do not have a "soft" fix for this now.
If you see this behavior in you inactive users list and do not like the idea of waiting of potential "autofix", you can...
  • uninstall ext
  • clean the ext's db table
  • reinstall the extension.
Of course by doing so you will "reset" the counters for the sent reminders.
From release 0.9.5 newly registered users will be auto populated in ext's db table, but if you had any registrations during that period you will still see this behavior in your list.

:shock: oO(boy that was a big post!) :D
Here is what I am working on right now...
Inactive User Manager for phpBB
Give it a try...
If you would like to buy me a bier ;) for my work I will drink it on a hot summer day and thank you!!!

User avatar
Hartenheer
Registered User
Posts: 776
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by Hartenheer » Mon Oct 24, 2016 4:56 pm

Thanks for the new download.
I try always.
it is awesome
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

whocarez
Registered User
Posts: 144
Joined: Sat Apr 18, 2009 9:19 pm

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by whocarez » Tue Oct 25, 2016 7:54 pm

andreask wrote:
whocarez wrote: Feature request:
a log entry for sent emails to members not only for "SENT REMINDER TO ADMIN".
Something like that: "Sent xy reminders" or "Sent reminders to x, y, z ..."
It is already there. you should see in admin logs a similar line like this one...

Code: Select all

admin 	192.168.1.107 	23 Oct 2016, 18:00 	{10 reminders were sent.}
It needs SENT_REMINDERS and it is in language/en/log.php
hm, I don't see that. In my adminstration logs I see only this {SENT REMINDER TO ADMIN} for my test mails, without translation, despite the fact, that there is a translation for "SENT REMINDER TO ADMIN" and also for "SENT_REMINDER_TO_ADMIN". The same for "SENT_REMINDERS". A translation is there, but nothing to see. It seem to me, that log.php in language/xx/ is ignored.

I use the latest 0.9.5 from github ....

andreask
Registered User
Posts: 533
Joined: Fri Feb 27, 2009 6:13 pm
Name: Andreas

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by andreask » Tue Oct 25, 2016 10:25 pm

OK, thats weird, does anyone else have the same problem with whocarez?

@whocarez

I guess you are still using phpbb 3.1.10 correct?
Here is what I am working on right now...
Inactive User Manager for phpBB
Give it a try...
If you would like to buy me a bier ;) for my work I will drink it on a hot summer day and thank you!!!

whocarez
Registered User
Posts: 144
Joined: Sat Apr 18, 2009 9:19 pm

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by whocarez » Tue Oct 25, 2016 10:32 pm

andreask wrote:OK, thats weird, does anyone else have the same problem with whocarez?

@whocarez

I guess you are still using phpbb 3.1.10 correct?
Yes and my little bit older PHP 5.4.

User avatar
Cooper_si
Registered User
Posts: 67
Joined: Mon Jun 06, 2005 1:55 pm
Location: Newcastle, UK
Name: Simon
Contact:

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by Cooper_si » Tue Nov 01, 2016 10:30 pm

Great extension !

One or two spelling mistakes which I have changed via language.

"Bellow" change to "Below" in body.php

and partial....

"'PAGE_NOT_EXIST' => 'We are teribly sorry for the inconvinience...." changed to "'PAGE_NOT_EXIST' => 'We are very sorry for the inconvenience...." in user_self_delete_page.php

;)
MINI Club for the North East, UK
FULLONMINIs.co.uk

andreask
Registered User
Posts: 533
Joined: Fri Feb 27, 2009 6:13 pm
Name: Andreas

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by andreask » Wed Nov 02, 2016 1:47 am

Thanks Simon!
whocarez wrote:Yes and my little bit older PHP 5.4.
Could you please purge your boards cache?
And let me know if the problem is fixed?


New version 0.9.6
With an addition. In settings and on language files.

Any issues please report here or at github!

Thank you all!
Here is what I am working on right now...
Inactive User Manager for phpBB
Give it a try...
If you would like to buy me a bier ;) for my work I will drink it on a hot summer day and thank you!!!

whocarez
Registered User
Posts: 144
Joined: Sat Apr 18, 2009 9:19 pm

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by whocarez » Wed Nov 02, 2016 7:39 am

andreask wrote: Could you please purge your boards cache?
And let me know if the problem is fixed?
I installed 0.9.6. and cleaned all the caches (board cache and xcache). Now the translation for the test mails is visible, but still within brackets {...}.
For the sent reminders I have to wait till the evening.

Thanks for this "exclude forums" option. Very useful!

User avatar
potku
Registered User
Posts: 850
Joined: Wed Dec 22, 2004 10:26 pm
Location: Tampere, Finland
Contact:

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by potku » Wed Nov 02, 2016 9:06 am

whocarez wrote:Thanks for this "exclude forums" option. Very useful!
+1!

This is a really good addition at least for our board. While there are several active martial arts discussion, the non-martial arts forum that covers everything else in life (yes, even martial artists have lives :D ) is the most active forum. But, since martial arts are the main focus of our website, it's better to have those MA topics in these e-mails. Thank you!
Potku.net

"Before I speak, I have something important to say."

- Groucho Marx

andreask
Registered User
Posts: 533
Joined: Fri Feb 27, 2009 6:13 pm
Name: Andreas

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by andreask » Wed Nov 02, 2016 4:03 pm

Glad that it's useful.

@whocarez
This will be fixed (is already locally) on next release.

Since this is a minor problem, there are some issues that I need to fix first and as soon as I fix them I'll do the next release, for now fell free to explore and report! :mrgreen:
Here is what I am working on right now...
Inactive User Manager for phpBB
Give it a try...
If you would like to buy me a bier ;) for my work I will drink it on a hot summer day and thank you!!!

andreask
Registered User
Posts: 533
Joined: Fri Feb 27, 2009 6:13 pm
Name: Andreas

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by andreask » Fri Nov 04, 2016 4:55 pm

Hello,

New release https://github.com/andreaskou/PHPBB_IUM ... 7-beta.zip

2 bug fixes.
Logging issues and inactive users list show empty username.

Best regards!
Here is what I am working on right now...
Inactive User Manager for phpBB
Give it a try...
If you would like to buy me a bier ;) for my work I will drink it on a hot summer day and thank you!!!

User avatar
Hartenheer
Registered User
Posts: 776
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by Hartenheer » Fri Nov 04, 2016 5:12 pm

Thanks for this report.
Go install
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

User avatar
potku
Registered User
Posts: 850
Joined: Wed Dec 22, 2004 10:26 pm
Location: Tampere, Finland
Contact:

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by potku » Sun Nov 06, 2016 6:13 pm

You are very active with this. :)

Which files were changed from 0.9.6 to 0.9.7?
Potku.net

"Before I speak, I have something important to say."

- Groucho Marx

andreask
Registered User
Posts: 533
Joined: Fri Feb 27, 2009 6:13 pm
Name: Andreas

Re: [BETA] PhpBB IUM (Inactive User Manager/reminder)

Post by andreask » Mon Nov 07, 2016 7:01 pm

Hi Potku,

Mainly because I'm unemployed (health issues). :)

really affected files are:
Fixed x-headers -> classes/reminder.php
Fix inactive user list bug -> acp/main_module.php
Fix deprecated function -> acp/main_module.php & acp/main_module.php
Replaced language file log with info_acp_ium -> classes/delete_user.php classes/reminder.php
Autofocus on buttons -> adm/style/acp_ium_approval_list.html adm/style/acp_ium_body.html
log language moved from log.php to info_acp_ium.php -> language/en/acp/info_acp_ium.php
language/en/log.php deleted.

This is all beta though once it goes to RC it will stabilize a lot (I hope)
:)
Here is what I am working on right now...
Inactive User Manager for phpBB
Give it a try...
If you would like to buy me a bier ;) for my work I will drink it on a hot summer day and thank you!!!

Post Reply

Return to “Extensions in Development”

cron