[RC] Tables

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
Sniper_E
Registered User
Posts: 582
Joined: Wed May 09, 2007 12:18 am
Location: Shreveport, Louisiana
Name: Ed Humphrey
Contact:

Re: [RC] Tables

Post by Sniper_E » Fri Jul 28, 2017 5:26 pm

I found the problem with that fa-fa table image showing in prosilver's page.
Copy/Paste error in styles/prosilver/template/event/overall_header_head_append.html

The code in that file needs to be as shown below.

Code: Select all

<!-- INCLUDECSS @sniper_tables/tables.css -->
Update on Github: https://github.com/Sniper-E/tables/comm ... 61d3e07f11
I've created a new tables icon image also... coming in next release.
Image
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!
:!: Sniper_E Styles | phpbbmodders :!:

User avatar
Galixte de EzCom
Registered User
Posts: 780
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] Tables

Post by Galixte de EzCom » Sat Jul 29, 2017 1:43 pm

Hi Sniper_E,

i have tested the last snapshot on GitHub on a local vanilla 3.2.1 phpBB forum, the problem with ABBC3 extension is still present.

This is the error from Apache2 logs and concerns the “Contact” settings page, in the ACP:

Code: Select all

[Sat Jul 29 15:27:14.060111 2017] [:error] [pid 3288:tid 1236] [client ::1:55462] PHP Fatal error:  Uncaught exception 'Twig_Error_Loader' with message 'Unable to find template "@sniper_tables/event/vse_abbc3_posting_editor_buttons_custom_tags_before.html" (looked into: ) in "@vse_abbc3/abbc3_posting_buttons.html" at line 204.' in C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\vendor\\twig\\twig\\lib\\Twig\\Loader\\Filesystem.php:232\nStack trace:\n#0 C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\phpbb\\template\\twig\\loader.php(135): Twig_Loader_Filesystem->findTemplate('@sniper_tables/...')\n#1 C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\vendor\\twig\\twig\\lib\\Twig\\Loader\\Filesystem.php(150): phpbb\\template\\twig\\loader->findTemplate('@sniper_tables/...')\n#2 C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\vendor\\twig\\twig\\lib\\Twig\\Environment.php(329): Twig_Loader_Filesystem->getCacheKey('@sniper_tables/...')\n#3 C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\vendor\\twig\\twig\\lib\\Twig\\Environment.php(419): Twig_Environment->getTemplateClass('@sniper_tables/...')\n#4 C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321 in C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\vendor\\twig\\twig\\lib\\Twig\\Loader\\Filesystem.php on line 232, referer: http://localhost:8080/quickinstall/boards/phpBB321/adm/index.php?sid=ff43cde514675377adc47138f7d4b622&i=acp_board&mode=registration
Futhermore, if i activate the “Board Announcements” extension, always with ABBC3 extension activated, i have this is the error from Apache2 log, in the ACP on “EXTENSIONS” tab when i want to access the the “Board Announcements” settings page:

Code: Select all

[Sat Jul 29 15:27:57.160483 2017] [:error] [pid 3288:tid 1236] [client ::1:55519] PHP Fatal error:  Uncaught exception 'Twig_Error_Loader' with message 'Unable to find template "@sniper_tables/event/vse_abbc3_posting_editor_buttons_custom_tags_before.html" (looked into: ) in "@vse_abbc3/abbc3_posting_buttons.html" at line 204.' in C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\vendor\\twig\\twig\\lib\\Twig\\Loader\\Filesystem.php:232\nStack trace:\n#0 C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\phpbb\\template\\twig\\loader.php(135): Twig_Loader_Filesystem->findTemplate('@sniper_tables/...')\n#1 C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\vendor\\twig\\twig\\lib\\Twig\\Loader\\Filesystem.php(150): phpbb\\template\\twig\\loader->findTemplate('@sniper_tables/...')\n#2 C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\vendor\\twig\\twig\\lib\\Twig\\Environment.php(329): Twig_Loader_Filesystem->getCacheKey('@sniper_tables/...')\n#3 C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\vendor\\twig\\twig\\lib\\Twig\\Environment.php(419): Twig_Environment->getTemplateClass('@sniper_tables/...')\n#4 C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321 in C:\\UwAmp_3.1.0\\www\\quickinstall\\boards\\phpBB321\\vendor\\twig\\twig\\lib\\Twig\\Loader\\Filesystem.php on line 232, referer: http://localhost:8080/quickinstall/boards/phpBB321/adm/index.php?sid=ff43cde514675377adc47138f7d4b622&i=28
Same kind of error. In fact, all pages which require full text editor will have this error.

Curiously, in the UCP, on “Edit signature” page, the error isn’t more displayed.

I will search same errors here, maybe i’ll can submit you some solutions to fix this. ;)
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

User avatar
Galixte de EzCom
Registered User
Posts: 780
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] Tables

Post by Galixte de EzCom » Sat Jul 29, 2017 1:47 pm

See this: https://github.com/BoardTools/QuickRepl ... .html#L122, and this: https://github.com/BoardTools/QuickRepl ... r.php#L286.

Maybe those examples will help you to fix this problem. ;)
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

User avatar
Sniper_E
Registered User
Posts: 582
Joined: Wed May 09, 2007 12:18 am
Location: Shreveport, Louisiana
Name: Ed Humphrey
Contact:

Re: [RC] Tables

Post by Sniper_E » Sat Jul 29, 2017 5:35 pm

Galixte de EzCom wrote:
Sat Jul 29, 2017 1:43 pm
Hi Sniper_E,
i have tested the last snapshot on GitHub on a local vanilla 3.2.1 phpBB forum, the problem with ABBC3 extension is still present.
Yes Galixte I was just fixing that prosilver fa-fa image showing in the body on that last post.
I was still working on the abbc3 problem I had. Fixed on Github - https://github.com/Sniper-E/tables

I'm now adding permissions and then I'll release 2.1.2 for testing.
I always welcome your valuable input and thank you for taking the time sharing!
Image
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!
:!: Sniper_E Styles | phpbbmodders :!:

User avatar
Galixte de EzCom
Registered User
Posts: 780
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] Tables

Post by Galixte de EzCom » Sun Jul 30, 2017 10:03 am

Hi Sniper,

yes it’s better, thanks. No more error in ACP with ABBC3. :)

I have submit you a new PR on GitHub to update FRENCH translation and fix the displaying of the Table icon in ACP: https://github.com/Sniper-E/tables/pull/3.
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

User avatar
Sniper_E
Registered User
Posts: 582
Joined: Wed May 09, 2007 12:18 am
Location: Shreveport, Louisiana
Name: Ed Humphrey
Contact:

Re: [RC] Tables

Post by Sniper_E » Sun Jul 30, 2017 2:15 pm

I see my mistake. I took the ../../ and replaced with ../ in those 2 /adm event templates. Thanks!

But I do not like the way you put spaces in your language file between the Titre, Texte and the numbers.
I left those spaces out for a purpose. You are trying to make text that is going to be replaced look good.
But you have spent way too much of your personal time changing all that so I'll fix your language file.

I do appreciate your efforts though. Thank you Galixte!
Image
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!
:!: Sniper_E Styles | phpbbmodders :!:

User avatar
Galixte de EzCom
Registered User
Posts: 780
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] Tables

Post by Galixte de EzCom » Sun Jul 30, 2017 6:54 pm

How does it concern you? :lol: If i spend time to fix my translation, it’s my problem, no ? Not yours. ;)

But, as it seems that you care about the time I spend, this is my way : I use notepad++ to update files and the process it’s very short with regex and regular expressions. :P

Moreover, i see what you’re talking about concerning space, i used in my FRENCH translation some non-breaking space instead of “simple” spaces, i’ll update them.
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

User avatar
Sniper_E
Registered User
Posts: 582
Joined: Wed May 09, 2007 12:18 am
Location: Shreveport, Louisiana
Name: Ed Humphrey
Contact:

Re: [RC] Tables

Post by Sniper_E » Sun Jul 30, 2017 8:29 pm

I have your update thank you. I have updated Github with your latest translations.
I apologize for messing with those capital letters when they NEED to be lowercase.
I must leave that up to all translators in the future. Sorry.

Now that we have all of this worked out and everyone is happy... it's time to move forward.
Image
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!
:!: Sniper_E Styles | phpbbmodders :!:

User avatar
Sniper_E
Registered User
Posts: 582
Joined: Wed May 09, 2007 12:18 am
Location: Shreveport, Louisiana
Name: Ed Humphrey
Contact:

Re: [RC] Tables

Post by Sniper_E » Mon Jul 31, 2017 4:12 pm

Sir Galixte. Your idea of putting a _ between the letters and numbers of the markers would be good.
Using Titre_21 and Texte_21 would be fine. As long as a user can double click to highlight all of it.
We need to change all the language files to match your text format.
Image
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!
:!: Sniper_E Styles | phpbbmodders :!:

User avatar
Galixte de EzCom
Registered User
Posts: 780
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] Tables

Post by Galixte de EzCom » Mon Jul 31, 2017 7:24 pm

My Lord, new PR submitted to replace spaces with _: https://github.com/Sniper-E/tables/pull/5. ;)
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

User avatar
Sniper_E
Registered User
Posts: 582
Joined: Wed May 09, 2007 12:18 am
Location: Shreveport, Louisiana
Name: Ed Humphrey
Contact:

Re: [RC] Tables

Post by Sniper_E » Tue Aug 01, 2017 4:49 am

Galixte, if you look anything like your avatar I will never anger you again. :lol:
You own that fr lang file. :D make that file more French if you want.

Got an update on Github. You push away! ;)

Edit: On further testing I found out that using Text_21 instead of using Text21 will not work for me.
I will update Github with the language file changes when I get them codded like they need to be.
Please wait for the changes.
Image
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!
:!: Sniper_E Styles | phpbbmodders :!:

User avatar
Galixte de EzCom
Registered User
Posts: 780
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] Tables

Post by Galixte de EzCom » Wed Aug 02, 2017 2:52 am

Hi,
Thanks for 2.1.2 update!
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

User avatar
Sniper_E
Registered User
Posts: 582
Joined: Wed May 09, 2007 12:18 am
Location: Shreveport, Louisiana
Name: Ed Humphrey
Contact:

Re: [RC] Tables

Post by Sniper_E » Wed Aug 02, 2017 3:54 pm

Thank you Galixte, translation and fix merged. ACP background color removal commited.

Now for the permissions I added. dmzx has tried to teach me these extension setups.
But I struggle. I have something off with permissions or something missing. Looking into it.
Not seeing it in phpmyadmin php_config table either.
Image
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!
:!: Sniper_E Styles | phpbbmodders :!:

User avatar
Sniper_E
Registered User
Posts: 582
Joined: Wed May 09, 2007 12:18 am
Location: Shreveport, Louisiana
Name: Ed Humphrey
Contact:

Re: [RC] Tables

Post by Sniper_E » Fri Aug 04, 2017 2:59 am

:D
Aight Gents, I think Tables 2.1.2 is ready to pack up and let you guys test it out.

I'm waiting on Miri4ever's and Galixte's language file update and I'll send it your way.
Image
No is NEVER an Option and NEVER is the only Option when it comes to Giving Up!
:!: Sniper_E Styles | phpbbmodders :!:

User avatar
Galixte de EzCom
Registered User
Posts: 780
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [RC] Tables

Post by Galixte de EzCom » Fri Aug 04, 2017 9:55 am

Sniper_E wrote:
Fri Aug 04, 2017 2:59 am
:D
Aight Gents, I think Tables 2.1.2 is ready to pack up and let you guys test it out.

I'm waiting on Miri4ever's and Galixte's language file update and I'll send it your way.
FRENCH translation updated here: https://github.com/Sniper-E/tables/pull/10, you can merge it. ;)
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: Galixte de EzCom, rohde, VSE and 25 guests

cron