Page 2 of 4

Re: [DEV] Who Visited This Topic

Posted: Fri Sep 30, 2016 9:04 am
by martin123456
OmkePom wrote:Sorry,

I see only visitors at topic when they are alowed to see WVTT.

I only want moderators and up to see al visitors?

:ugeek:
There is a setting for all groups to be set to how you want it set no need to edit files if you set it up.

Image

Re: [DEV] Who Visited This Topic

Posted: Sat Oct 01, 2016 4:33 pm
by OmkePom
martin123456 wrote:
There is a setting for all groups to be set to how you want it set no need to edit files if you set it up.

Image
No, if users cant use it (read it) they dont show in the vieuw eigther!

:mrgreen:

Re: [DEV] Who Visited This Topic

Posted: Sun Oct 09, 2016 10:57 am
by bitsss
OmkePom wrote:Sorry,

I see only visitors at topic when they are alowed to see WVTT.

I only want moderators and up to see al visitors?

:ugeek:
I think this behavior is a heavy bug.

The group permissions sounds "Can view ....". If i set it to "NO" or "NEVER", on the one hand all affected users cannot view the extension-functionality anymore, one the other hand this users will not be logged anymore for visiting a topic.

@dmzx: what`s your opinion?

Re: [DEV] Who Visited This Topic

Posted: Sun Oct 09, 2016 11:19 am
by bitsss
furthermore i have an improvement proposal for the next release:

Disable "Show Avatar"

Re: [DEV] Who Visited This Topic

Posted: Sun Oct 09, 2016 6:52 pm
by OmkePom
I solved it this way for Mods and higher in "viewtopic_body_footer_before.html"
OmkePom wrote:

Code: Select all

<!-- IF PERMISSION_VIEW -->
in

Code: Select all

<!-- IF PERMISSION_VIEW and U_MCP -->
or only for Admin in,

Code: Select all

<!-- IF PERMISSION_VIEW and U_ACP -->
Workes fine by me ;)

Re: [DEV] Who Visited This Topic

Posted: Tue Oct 11, 2016 7:08 am
by bitsss
OmkePom wrote:I solved it this way for Mods and higher in "viewtopic_body_footer_before.html"
@OmkePom: thank you very much for this workaround. nevertheless i hope the developer fix the problem in the next release.

Your workaround does have an affect to the group permissions.

"Can view ...." does mean now: "User will be counted"

Re: [DEV] Who Visited This Topic

Posted: Tue Oct 11, 2016 7:55 am
by bitsss
I have another improvement proposal:

the own username should be disabled!

Re: [DEV] Who Visited This Topic

Posted: Tue Oct 11, 2016 9:21 am
by dmzx
Change in listener

Code: Select all

if (($this->user->data['user_id'] != ANONYMOUS) && (!$this->user->data['is_bot']) && $this->auth->acl_get('u_whovisitedthistopic') && $this->config['whovisitedthistopic_allow_topics'])
to

Code: Select all

if (($this->user->data['user_id'] != ANONYMOUS) && (!$this->user->data['is_bot']) && $this->config['whovisitedthistopic_allow_topics'])
so member will be counted always, now you can set permissions to the group who can view it.
bitsss wrote:Disable "Show Avatar"
Will think about this.
bitsss wrote:the own username should be disabled!
You mean admin username?

Re: [DEV] Who Visited This Topic

Posted: Tue Oct 11, 2016 5:23 pm
by bitsss
dmzx wrote:You mean admin username?
I mean the username on the first position, because this username is ALWAYS the account of the observer (i hope this is The correct english word).
It make no sense to view this username.

Re: [DEV] Who Visited This Topic

Posted: Thu Oct 13, 2016 6:17 pm
by dmzx
First post updated

Re: [DEV] Who Visited This Topic

Posted: Fri Oct 14, 2016 7:05 am
by bitsss
dmzx wrote:First post updated
Great job, thanx!

In the changelog i am missing something:

Changelog v1.0.5
Added ACP option to switch off avatar
Added permission
Fixed fatal error --> viewtopic.php?p=14535956#p14535956

Re: [DEV] Who Visited This Topic

Posted: Tue Nov 22, 2016 11:12 am
by sunpig
This works perfect on our phpBB 3.1.10.

Great work!

Re: [DEV] Who Visited This Topic

Posted: Sun Nov 27, 2016 7:21 pm
by bitsss
"Who Visited This Topic" looks like this:

MY_USERNAME, User X, User B, User K, User F, ...

"MY_USERNAME" will be shown always on the first position, so it is no usefull.

I have an idea:

normally the list will be sort by last visit. in the future, MY_USERNAME should get a special behavior:

MY_USERNAME (sort by second-to-last visit)
User X (sort by last visit)
User B (sort by last visit)
User K (sort by last visit)
User F (sort by last visit)


result (for example)
Who Visited This Topic: User X, User B, User K, MY_USERNAME, User F, ...

This list means: User X, B and K visited the topic (again) since my last visit.

It would be SOOOOO GREAT, so usefull!

Is it possible to implement?

Re: [DEV] Who Visited This Topic

Posted: Thu Feb 02, 2017 12:12 am
by BBBenj
Hello,

I'm very interested by your wonderful extension, but I need to know ALL the visitors' name on a specific topic, not only the XXXX ones (I know how to change that number).

By the way, by editing your code, I can show the 2.500 viewers of a topic among the 310 members of my forum. In fact, I'd like your extension to show how many unique people came on a topic, how many times they came and when they came last time. Exactly what does the previous mod, in fact.

Can you do this for me, please?

Re: [DEV] Who Visited This Topic

Posted: Fri Feb 10, 2017 4:53 pm
by TheNiceBigFella
This has worked great so far on my live board. It would be nice to add the collapsing field.

Also it would be great, like the old one, to be able to show the ability of when the person last visited a topic. I believe the old one would show the date/time of the last visit.

So far, so good. If the above could somehow happen. I'll make a tuition donation to the cause.