Page 8 of 9

Re: [3.2][RC] Simple mentions

Posted: Tue Apr 18, 2017 6:05 pm
by Paul
It should display the avatar in the notifications if the mentioned user has a avatar. If not, please report it to github.

Re: [DEV][3.2] Simple mentions

Posted: Tue Apr 18, 2017 6:19 pm
by odf
eunaumtenhoid wrote:
Fri Nov 11, 2016 11:30 pm
coming soon? promises :)

We need this ext to 3.1
Sure, we need it for phpBB 3.1.x.

Re: [3.2][RC] Simple mentions

Posted: Tue Apr 18, 2017 6:20 pm
by Paul
As I said before, I won't make it 3.1 compatible. There are too many incompatible changes between 3.1 and 3.2 to have 1 version for it both.

Re: [3.2][RC] Simple mentions

Posted: Sat Apr 22, 2017 12:56 am
by bcurran3
Paul,

Keep up the good work. I finally quit using @mentions last week and am now actively using your extension.

Looking forward to seeing implementation of some of the feature requests.

Re: [3.2][RC] Simple mentions

Posted: Wed Apr 26, 2017 12:39 pm
by Cin-
Hey paul,

Great extension, works great on my test board. A few remarks so far:

- you can mention yourself and you will receive a notification. Don't know if this behavior is intended?

- A lot of people find it annoying that you get a notification when someone quotes the part of a message you are mentioned. I'd recommend that behavior is altered - if possible - so that a user only receives a notification when the mention tag is not included in a quote tag.

Re: [3.2][RC] Simple mentions

Posted: Wed Apr 26, 2017 12:46 pm
by Paul
Please report feature requests in the github tracker (But make sure to check if issues are not reported already first).

Re: [3.2][RC] Simple mentions

Posted: Wed Apr 26, 2017 12:56 pm
by Cin-
Okay, done.

Re: [3.2][RC] Simple mentions

Posted: Thu Apr 27, 2017 8:13 pm
by Paul
A second release candidate has been released, and can be downloaded at https://github.com/paul999/mention/rele ... /1.0.0-RC2

Changes in this release: https://github.com/paul999/mention/milestone/1?closed=1

Re: [3.2][RC] Simple mentions

Posted: Sun Apr 30, 2017 7:38 am
by VSE
Nice paul!

Just a few comments:

1. Can the notification message also mention the post? e.g.,
"You have been mentioned by username in "Title of the post"

I think it'd be super helpful to know where you've been mentioned :)

2. The ext seems to be titled "Simple mentions" but in composer.json the display name is "phpBB mentions".

Re: [3.2][RC] Simple mentions

Posted: Sun Apr 30, 2017 8:26 am
by dmzx
And what does the adm/style do? ;)

Re: [3.2][RC] Simple mentions

Posted: Sun Apr 30, 2017 2:34 pm
by moose5
Nice one Paul!! Thank you very much!

Re: [3.2][RC] Simple mentions

Posted: Tue May 02, 2017 3:05 pm
by maras2626
Hi, If you quote a post this will display an error:

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/ext/paul999/mention/event/main_listener.php on line 287: Undefined index: message
[phpBB Debug] PHP Notice: in file [ROOT]/ext/paul999/mention/event/main_listener.php on line 290: Indirect modification of overloaded element of phpbb/event/data has no effect
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4511: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3257)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4511: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3257)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4511: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3257)
Simple mentions ver. RC2

Re: [3.2][RC] Simple mentions

Posted: Tue May 02, 2017 3:06 pm
by Paul
Please report it to the issue tracker at github.com

Re: [3.2][RC] Simple mentions

Posted: Tue May 02, 2017 9:54 pm
by escovinhas
IS this work 100% on 3.2.0 ??

Cheers

Re: [3.2][RC] Simple mentions

Posted: Wed May 03, 2017 6:03 am
by zorni
escovinhas wrote:
Tue May 02, 2017 9:54 pm
IS this work 100% on 3.2.0 ??

Cheers
Yes.