[3.1][3.2][DEV] Image Upload

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
nou nou
Registered User
Posts: 328
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.1][3.2][DEV] Image Upload

Post by nou nou » Wed Oct 18, 2017 9:52 pm

Sweet, two solutions for a single problem, I like it :)

Thanks Sippan and kim902!

nou nou
Registered User
Posts: 328
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.1][3.2][DEV] Image Upload

Post by nou nou » Thu Oct 19, 2017 1:48 am

Great and useful extension! Thanks!

Doesn't work well with the Subway style though. As soon as I enable Image Upload, the login screen animation changes and the login information cannot be filled out anymore. Something seems to be clashing. This is on 3.1.9...

Disabling the extension fixes the issue. Should anything be influencing the login screen at all, though?

nou nou
Registered User
Posts: 328
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.1][3.2][DEV] Image Upload

Post by nou nou » Fri Oct 20, 2017 12:47 am

I seem to have nailed it down.

In imageupload/styles/prosilver/theme/imageupload.css there is a bracket too many at line 72. Delete that and all is working in Subway.

EDIT: I spoke too soon. Fixed for wide screens but not for mobile. There is more weirdness in that css file... will dig further :)

BigRed01
Registered User
Posts: 472
Joined: Mon Jan 24, 2005 9:26 am
Location: The upper midwest

Re: [3.1][3.2][DEV] Image Upload

Post by BigRed01 » Fri Oct 20, 2017 3:19 pm

When clicking on image upload, it opens a new tab. Any chance of having this open in the current tab?

kim902
I've Been Banned!
Posts: 59
Joined: Wed Nov 09, 2016 5:49 pm

Re: [3.1][3.2][DEV] Image Upload

Post by kim902 » Fri Oct 20, 2017 3:43 pm

nou nou wrote:
Fri Oct 20, 2017 12:47 am
I seem to have nailed it down.

In imageupload/styles/prosilver/theme/imageupload.css there is a bracket too many at line 72. Delete that and all is working in Subway.

EDIT: I spoke too soon. Fixed for wide screens but not for mobile. There is more weirdness in that css file... will dig further :)
My line 72 is this and it dont have an extra bracket ?

Code: Select all

@media (max-width: 850px) {
	#codes input{
		width: 80%;
	}
	.buttoncopy {
		padding-top: 2px;
		padding-bottom: 4px;
	}
}
Hardest thing in life is accepting some one else has done it better.

nou nou
Registered User
Posts: 328
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.1][3.2][DEV] Image Upload

Post by nou nou » Fri Oct 20, 2017 9:46 pm

Sorry - my bad. Turns out the bracket was a red herring.

It has to do with this bit in the .css file:

Code: Select all

.modal {
    display: none;
    position: fixed; 
    z-index: 1;
    padding-top: 100px; 
    left: 0;
    top: 0;
    width: 100%; 
    height: 100%; 
    overflow: auto;
    background-color: rgb(0,0,0);
    background-color: rgba(0,0,0,0.9);
}

.modal-content {
    margin: auto;
    display: block;
    width: 80%;
    max-width: 700px;
}

#caption {
    margin: auto;
    display: block;
    width: 80%;
    max-width: 700px;
    text-align: center;
    color: #ccc;
    padding: 10px 0;
    height: 150px;
}

.modal-content, #caption { 
    -webkit-animation-name: zoom;
    -webkit-animation-duration: 0.6s;
    animation-name: zoom;
    animation-duration: 0.6s;
}

@-webkit-keyframes zoom {
    from {-webkit-transform:scale(0)} 
    to {-webkit-transform:scale(1)}
}

@keyframes zoom {
    from {transform:scale(0)} 
    to {transform:scale(1)}
}
Delete that and Subway's login screen works as before. I haven't checked yet what the influence is on the Image Upload extension.

In fact, if you only get rid of line 134:

Code: Select all

z-index: 1;
The login screen animation is all wonky but you can at least get your credentials in there.

TBC... :)

nou nou
Registered User
Posts: 328
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.1][3.2][DEV] Image Upload

Post by nou nou » Sat Oct 21, 2017 4:54 am

Hmm. More issues. I'm getting this message when trying to view an uploaded image:

Code: Select all

No route found for "GET /ext/dmzx/imageupload/files/b7b66e4d981a4fe3b6f40b0bcba5c1b4.jpg"
I have had extensions throw this message before and it was because the forum is located in a subfolder like www.myforum.org/myforum/ rather than in the root.

I'll see if I can fix it by hardcoding the path in the extension somewhere and I'll report back.

nou nou
Registered User
Posts: 328
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.1][3.2][DEV] Image Upload

Post by nou nou » Mon Oct 23, 2017 4:49 pm

No luck so far in getting this resolved.

It's weird though, almost everything works. Upload works, images end up where they should be on the server etc. Just cannot read them.

Also this code to add a button to mChat:

Code: Select all

<!-- IF S_USER_LOGGED_IN -->
<input type="button" class="button2" onclick="popup('./imageupload', 550, 400); return false;" value="{L_IMAGES_TITLE}" title="{L_IMAGES}" />
<!-- ENDIF -->

Results in the button being named IMAGES_TITLE, rather than the replacement string. And in the Post Editor there is a button named Img-Upload.


EDIT: the correct code for use in the mChat event is:

Code: Select all

<!-- IF IMAGEUPLOAD_USE_UPLOAD -->
<input type="button" class="button2" onclick="popup('./imageupload', 550, 400); return false;" value="{L_IMAGEUPLOAD_UPLOAD}" title="{L_IMAGEUPLOAD_UPLOAD}" />
<!-- ENDIF -->
Perhaps that helps ringing a bell for someone?

Thanks!
Last edited by nou nou on Tue Oct 24, 2017 11:50 pm, edited 1 time in total.

nou nou
Registered User
Posts: 328
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.1][3.2][DEV] Image Upload

Post by nou nou » Tue Oct 24, 2017 10:19 pm

Found the problem. All the uploaded pictures have their permission set to 0600.

Now how to fix this is the next question... :)

It's weird because the code to set the permissions to 0644 is right there... :?:

I've run out of ideas at the moment, if anyone has any further pointers I'd be grateful.

Thanks!

EDIT: I found some other person who had a similar issue, and it was suggested the hosting provider didn't allow setting permissions on file through php. Not the case here, so that's not the issue. Is the chmod path construction in imageupload.php correct?

nou nou
Registered User
Posts: 328
Joined: Sat Oct 29, 2016 8:08 pm

Re: [3.1][3.2][DEV] Image Upload

Post by nou nou » Wed Oct 25, 2017 6:12 am

Argh. On my 3.2 test board it works. Same general setup, though, same theme and everything.

On 3.1 it fails.

Ah well. It will be for after the 3.2 migration I guess.

User avatar
Bruno36
Registered User
Posts: 287
Joined: Fri Mar 02, 2007 2:16 pm
Location: france
Name: bruno astie
Contact:

Re: [3.1][3.2][DEV] Image Upload

Post by Bruno36 » Sat Nov 04, 2017 1:06 pm

Hello!
I have an error message when I want to send an image

No route found for "GET /imageupload/" (from "https://www.scooter-chinois-4t.com/foru ... post&f=105")
Excuse me for my poor English, I speak french
Bruno36

User avatar
Galixte de EzCom
Registered User
Posts: 1028
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [3.1][3.2][DEV] Image Upload

Post by Galixte de EzCom » Sat Nov 04, 2017 8:35 pm

Hi,

you have to apply a CHMOD 777 to the folder

Code: Select all

./ext/dmzx/imageupload/files/
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.

User avatar
Bruno36
Registered User
Posts: 287
Joined: Fri Mar 02, 2007 2:16 pm
Location: france
Name: bruno astie
Contact:

Re: [3.1][3.2][DEV] Image Upload

Post by Bruno36 » Sun Nov 05, 2017 6:53 am

The folder is on the FTP server :shock:
Excuse me for my poor English, I speak french
Bruno36

User avatar
Galixte de EzCom
Registered User
Posts: 1028
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [3.1][3.2][DEV] Image Upload

Post by Galixte de EzCom » Sun Nov 05, 2017 10:41 am

Indeed, if it's not on your FTP, create it.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.

User avatar
german-german
Registered User
Posts: 56
Joined: Sun Jan 15, 2017 1:56 am
Location: Buenos Aires - Argentina
Name: Germán A. Sassone
Contact:

Re: [3.1][3.2][DEV] Image Upload

Post by german-german » Fri Dec 08, 2017 2:41 pm

Is It posible not to load automatically the pictures I already uploaded

Image

When It loads auto, my forum takes forever to finish loading

And It gets saturated

Maybe a solution would be, load the pictures only when you click a button or similar

Thanks

Post Reply

Return to “Extensions in Development”