[3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
maras2626
Registered User
Posts: 61
Joined: Tue Feb 07, 2017 4:48 pm

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by maras2626 » Wed Mar 22, 2017 7:45 pm

3Di wrote:
Wed Mar 22, 2017 12:58 am
Open the file /ext/threedi/qaip/event/main_listener.php and FIND this line

Code: Select all

if ($mode == 'quote' && !$submit && !$preview && !$refresh)
REPLACE the above line with this one

Code: Select all

if ( $mode == 'quote' && !$submit && !$preview && !$refresh && (empty($post_data["poll_title"])) )
SAVE the file back and use it, no need to disable the extension at all.

Hi, quoting and attachments do not work with any topic after I have replaced this code. It also doesn't work with topics without any polls :(

User avatar
3Di
Registered User
Posts: 11719
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by 3Di » Wed Mar 22, 2017 9:28 pm

maras2626 wrote:
Wed Mar 22, 2017 7:45 pm
3Di wrote:
Wed Mar 22, 2017 12:58 am
Open the file /ext/threedi/qaip/event/main_listener.php and FIND this line

Code: Select all

if ($mode == 'quote' && !$submit && !$preview && !$refresh)
REPLACE the above line with this one

Code: Select all

if ( $mode == 'quote' && !$submit && !$preview && !$refresh && (empty($post_data["poll_title"])) )
SAVE the file back and use it, no need to disable the extension at all.

Hi, quoting and attachments do not work with any topic after I have replaced this code. It also doesn't work with topics without any polls :(
Strange, we are discussing the issue starting from here
https://3di.space/32/viewtopic.php?p=530#p530
you can follow there since you have already got an account yourself.

Did you save the file with a decent editor as UTF-8 no-bom?

As I said, the above isn't a FIX, it is a hack(ish) work-around for to temporarily amend/minimize the issue.

Thanks for feedback. :)
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades

User avatar
3Di
Registered User
Posts: 11719
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by 3Di » Fri Mar 24, 2017 2:43 am

QAIP v1.0.0-b3 is available, see first post(s) for details.
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades

User avatar
John connor
Registered User
Posts: 1367
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by John connor » Fri Mar 24, 2017 4:04 am

Thanks!

maras2626
Registered User
Posts: 61
Joined: Tue Feb 07, 2017 4:48 pm

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by maras2626 » Fri Mar 24, 2017 11:19 pm

Thanks for your work

User avatar
3Di
Registered User
Posts: 11719
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by 3Di » Fri Mar 24, 2017 11:20 pm

My pleasure, thanks you all. :)
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades

User avatar
John connor
Registered User
Posts: 1367
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by John connor » Sat Sep 16, 2017 7:33 am

Hi. Is it possible to show the images in the posting box that you want quoted? I have posts that contain many images and figuring out which image is which to quote is tough to do as it's just a link in the post box. I'm thinking the image links need to be parsed in the posting box?

User avatar
3Di
Registered User
Posts: 11719
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by 3Di » Sun Sep 17, 2017 4:37 am

Every thing is possible or at least that's what a famous motto says.
I don't think though that's a good idea and I can't make something just for one request, hope you will understand. It could be a good idea to file a feature request at the repo, so to don't forget it. (see first posts)

Ps.: simply mouse hover the img you want to quote and copy the link, or simply look at which position has been placed... before to quote the message. Those are ordered.
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades

User avatar
John connor
Registered User
Posts: 1367
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by John connor » Sun Sep 17, 2017 7:38 pm

3Di wrote:
Sun Sep 17, 2017 4:37 am
)

Ps.: simply mouse hover the img you want to quote and copy the link, or simply look at which position has been placed... before to quote the message. Those are ordered.
Yeah, my users are too dumb to have to do that. Especially new users. I tried to quote the first image, but it quoted the very last. Maybe I did something wrong. Regardless, it would be so much more easier if users could see the parsed images in the post so that they can delete images as necessary to quote which ones they want.

I'll add a comment at github I guess...

User avatar
3Di
Registered User
Posts: 11719
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by 3Di » Sun Sep 17, 2017 9:37 pm

John connor wrote:
Sun Sep 17, 2017 7:38 pm
I'll add a comment at github I guess...
Here's your Feature request: https://github.com/3D-I/qaip/issues/5

In addition, the images are already parsed in preview and post reply/preview but is not possible to excerpt an image from there because it is ... an image. Not text.

Anyway, thx. :)
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades

User avatar
John connor
Registered User
Posts: 1367
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by John connor » Tue Sep 19, 2017 5:56 am

My motto is: Nothing is impossible and every problem has a solution.

If I have to make core changes I will. I really like to have images parsed in the post. :geek:

User avatar
3Di
Registered User
Posts: 11719
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by 3Di » Wed Sep 20, 2017 8:38 pm

Quote the post, modify it, click on Preview and see if what you have done is ok ----> click on Submit. ;)

I will not provide hacks nor I add a feature I don't like/think is worth the effort (or who explicitely requested this extension didn't ask for).

Regards. :)
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades

User avatar
John connor
Registered User
Posts: 1367
Joined: Fri Nov 14, 2014 5:14 pm
Location: U S Of A
Contact:

Re: [3.1][3.2][BETA] QAIP - Quote Attachments Img in Posts

Post by John connor » Wed Sep 20, 2017 11:54 pm

I understand what you're saying and I can do that, but I can't expect my users to know that especially since about 90% of them use a smart device of one form or another and that would entail extra steps.

Regardless of what YOU think, I think it would be prudent to listen to your users who use your extension and consider their ideas rather than shutting them down. I think what I propose here is a valid idea, especially since all of your other mainstream forums have the same feature.

User avatar
Galixte de EzCom
Registered User
Posts: 780
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

FRENCH translation for the Quote Attachments Img in Posts extension

Post by Galixte de EzCom » Thu Sep 21, 2017 2:03 pm

Hi,

FRENCH translation for the Quote Attachments Img in Posts extension on GitHub and available on EzCom Community.
Last edited by Galixte de EzCom on Fri Sep 22, 2017 8:20 am, edited 1 time in total.
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

User avatar
3Di
Registered User
Posts: 11719
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][DEV] QAIP - Quote Attachments Img in Posts

Post by 3Di » Thu Sep 21, 2017 9:10 pm

3Di wrote:
Sat Feb 18, 2017 6:24 am
Language support
  • The extension supports the following languages, please avoid to create PRs on GitHUb for extra languages, those will be not merged. Create a fork of the language and share the link, instead.
  • en
  • en_us
Thanks. :)
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: Bing [Bot], maco8024 and 21 guests

cron