david63 wrote: ↑Thu Jan 04, 2018 3:03 pm
I have one feed which is a FB page fed via FetchRSS. This works fine not a problem as such. Before you changed the feed to use namespace this feed also brought in images now it does not - the images are there in FetchRSS. I took a quick look through the code and as far as I can see it should still work.
As always: can you provide an example I can work with?
david63 wrote: ↑Thu Jan 04, 2018 3:03 pm
Oh - I also noticed that you have the feed types as hard coded language in the template (obviously missed on your first submission but if noticed would be a reason for denial)
You mean this part?
https://github.com/GerB/feedpostbot/blo ... ml#L81-L83
AFAIK, this isn't language-dependent, just like PHP, HTML, CSS etc. aren't. Why would this need to be parsed as language vars?
canonknipser wrote: ↑Thu Jan 04, 2018 3:14 pm
Ger, thanks for that great extension.
Any chance to enable post approval depending on bot user permissions?
I recognized you disabled it hardcoded atm:
https://github.com/GerB/feedpostbot/blo ... r.php#L499
My intention is that not all feeds from a source would be interesting for a board, so the bot user will have "can post without approval" to "never" and a moderator has a chance to look over the posts before they are published and approve / deny them.
Well, I actually just used the basic template as provided by
the documentation and assumed it was required to provide a boolean value here. I looked into the actual function being called and it seems that this isn't entirely correct since there are constants
ITEM_...
used instead of booleans and when it isn't passed it will just use the default permission system.
I think it doesn't do any harm to simply remove this line from my extension, but I need to give that a little bit of thought.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2
Like my work?
Buy me a coffee to keep it coming.
-Don't PM me for support-