[3.2][ALPHA] Topic Title Color

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Ideas Centre
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Miri4ever
Registered User
Posts: 392
Joined: Sat Mar 07, 2015 11:18 am

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by Miri4ever » Wed Aug 09, 2017 5:32 pm

I don't know what your extension is thinking and doing. I don't programmed it. I did an test installation again with only your extension disabled and enabled and got this result with language change. Maybe there are Ghosts inside I don't know:

Image
Homepage: Terra Oceanica

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16544
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by DavidIQ » Thu Aug 10, 2017 12:20 pm

Miri4ever wrote:
Wed Aug 09, 2017 5:32 pm
I don't know what your extension is thinking and doing. I don't programmed it. I did an test installation again with only your extension disabled and enabled and got this result with language change. Maybe there are Ghosts inside I don't know:
Or maybe you changed your language to English and forgot? ;) If you have other extensions they might be causing your problems and are somehow conflicting with this extension. There really isn't anything in this extension that would cause this, unless, of course, you've changed core code for whatever reason in which case that's not something I can help you with. In fact this is the only spot in the extension where anything is being done with the user's language and, as you can see, it's very specific to the post mode and only on the posting.php page.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
Galixte de EzCom
Registered User
Posts: 828
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by Galixte de EzCom » Thu Aug 10, 2017 4:56 pm

A way to find the problem:
  1. disable all extensions except this extension,
  2. test this extension,
  3. if no problem results,
  4. activate one other extension which you use,
  5. test this extension,
  6. if no problem results,
  7. activate one other extension which you use,
  8. test this extension,
  9. if no problem results,
  10. ….
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

Miri4ever
Registered User
Posts: 392
Joined: Sat Mar 07, 2015 11:18 am

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by Miri4ever » Thu Aug 10, 2017 6:52 pm

I got a fresh install of PHPBB 3.2.1 as I said and only this extension running. Installed 4 different translations and all results the same. No matter if french, german or another. A few core translations still got switched to english instead of the real.

For example the preview and submit button always being english. User profile button and logout. Delete boards cookies, sticky and announce and lock topic. The only things that is translated right is global announce .

And yes it only happens if posting is called. As soon as I switch off extension everything is fine. And it's the only working extension at the board. With fresh install and only prosilver style there can't be any wrong setting.

Ok well it could be a core problem with PHPBB why this happens but here we should work together instead of blame eachother. Maybe some more members who using other languages as english who could see and find out whats wrong with this here.
Homepage: Terra Oceanica

User avatar
Galixte de EzCom
Registered User
Posts: 828
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by Galixte de EzCom » Fri Aug 11, 2017 6:55 am

Okey, i didn’t realize your problem, i thounght it was more specific about functionnality from this extension.

It’s strange as issue, because four days ago i reported to sanatanov a similar issue with phpBB Gallery: https://www.phpbb.com/customise/db/exte ... 51#p579651 (see report number 4 in my message).

Could you take a look DavidIQ?
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

Miri4ever
Registered User
Posts: 392
Joined: Sat Mar 07, 2015 11:18 am

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by Miri4ever » Fri Aug 11, 2017 7:41 am

Yes this is the problem and you see it just replace language in some strange behaves. I few day before I deleted [ABD] Prime Ban to Group Extension this caused the same but everywhere on index page. Don't know if this from old PHPBB 3.1 code or something inside the core that some old exentsions produce this kind of behave.

There is also a big difference in people with translations: Some using just [] others doing with array() but this also did no solution to me with the changes.
Homepage: Terra Oceanica

User avatar
Galixte de EzCom
Registered User
Posts: 828
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by Galixte de EzCom » Fri Aug 11, 2017 7:59 am

After testing this extension i can report as an issue maybe similar as phpBB Gallery:

Topic Title Color extension doesn’t take in consideration the USER language, except if it’s ENGLISH, explanations:
  1. If i set the default board language to FRENCH, and i set my UCP language setting to FRENCH => it’s not ok, the board is displayed in FRENCH, except on posting pages (new topic and reply) where it’s displayed in mixed languages FRENCH and ENGLISH, see below some examples (red for FRENCH and green for ENGLISH):
    • new topicImage
    • replyImage
  2. if i set the default board language to FRENCH, and i set my UCP language setting to ENGLISH => it’s Ok, the board is displayed in ENGLISH,
  3. If i set the default board language to ENGLISH, and i set my UCP language setting to ENGLISH => it’s Ok, the board is displayed in ENGLISH,
  4. if i set the default board language to ENGLISH, and i set my UCP language setting to FRENCH => it’s not ok, the board is displayed in FRENCH, except on posting pages (new topic and reply) where it’s displayed in mixed languages FRENCH and ENGLISH.
All tests come from Quickinstall installation with a fresh install of phpBB 3.2.1.
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16544
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.2][ALPHA] Topic Title Color

Post by DavidIQ » Fri Aug 11, 2017 10:50 am

Sounds like a bug in the core somewhere since you've seen it in other extensions. You should just report it to our tracker.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16544
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.2][ALPHA] Topic Title Color

Post by DavidIQ » Fri Aug 11, 2017 11:11 am

Actually don't do that. I may have something to work around this. The event used for setting up needs clearer documentation.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
Galixte de EzCom
Registered User
Posts: 828
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [3.2][ALPHA] Topic Title Color

Post by Galixte de EzCom » Fri Aug 11, 2017 12:03 pm

Do you mean it’s not a core bug, but only a bad use from a PHP event by the extension authors?
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16544
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.2][ALPHA] Topic Title Color

Post by DavidIQ » Fri Aug 11, 2017 12:07 pm

It sort of is a core bug, but we're not sure if it can be fixed in a proper manner:
https://tracker.phpbb.com/browse/PHPBB3-15315

I can just switch to using a different event for the one causing this:
https://github.com/DavidIQ/topictitlecolor/issues/6

The events are being used by extension authors in a proper way, but with this unexpected consequence.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
Galixte de EzCom
Registered User
Posts: 828
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [3.2][ALPHA] Topic Title Color

Post by Galixte de EzCom » Fri Aug 11, 2017 12:28 pm

Thanks for explanations and good luck to find the good way. ;)
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

User avatar
Galixte de EzCom
Registered User
Posts: 828
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [3.2][ALPHA] Topic Title Color

Post by Galixte de EzCom » Mon Aug 28, 2017 2:35 am

Any news about this issue?

PR Submitted for the FRENCH translation on GitHub, also available on EzCom community.
Communau EzCom
Image « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
ImageLists of all extensions identified for phpBB 3.1.x & 3.2.x.
ImageLists of all styles identified for phpBB 3.1.x & 3.2.x.

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: donsenilo, JoshyPHP, Meis2M, PhilDiscuss, RomaamoR, wrkalot and 25 guests