[3.2][ALPHA] Topic Title Color

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Get Involved
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
User avatar
uruguayito
Registered User
Posts: 259
Joined: Mon Dec 13, 2010 2:46 pm
Location: Montevideo - Uruguay

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by uruguayito » Sat Apr 15, 2017 1:16 pm

Isn't possible select a colour for the message, With this ext active....
I speak spanish
Sorry for my bad english

User avatar
3Di
Registered User
Posts: 11461
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by 3Di » Mon Jul 31, 2017 9:10 pm

DavidIQ wrote:
Tue Apr 11, 2017 6:40 pm
uruguayito wrote:
Tue Apr 11, 2017 5:17 pm
when a user wants leave a message with a colour, there is a conflict with this ext..... :roll:
What conflict? :roll:
Confirmed.

Hi David, today I worked on this succesfully. Basically got rid of Js, using now HTML5.
Modified the migration and some of the PHP/HTML/CSS code here and there, no yet permission added.

Now there is a new added color-picker based on a per user's OS, instead for posts will continue to use the native one not interferring with color BBcodes (tested).

Here's a screenshot http://prntscr.com/g2p80c of what I am talking about.

This way, without Js, the user will not notice a "lag" of any sort btw, last but not least IMO.
There is more to do as well, when I get some more spare time I will do it.

If you are interested on this approach pls let me know, I will be more than glad to finish it and make a PR, once completely done and thruly tested.

Regards.
Want to compensate me for my interest? You can.
You can pm me only in case of request for paid job. Thx.
MOD conversions, Extensions and Scripts for phpBB.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16343
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by DavidIQ » Mon Jul 31, 2017 9:20 pm

Looks interesting. Does it work with IE11?
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
3Di
Registered User
Posts: 11461
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by 3Di » Mon Jul 31, 2017 9:27 pm

DavidIQ wrote:
Mon Jul 31, 2017 9:20 pm
Looks interesting. Does it work with IE11?
We are using intensively this one within a new extension that will be soon published here, got to study the case then. If not supported, like IE11 (3,32% global use) as a fallback returns a type text color-picker. ;)

https://caniuse.com/#search=type%3D%22color
Want to compensate me for my interest? You can.
You can pm me only in case of request for paid job. Thx.
MOD conversions, Extensions and Scripts for phpBB.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16343
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by DavidIQ » Mon Jul 31, 2017 9:59 pm

Not really interested in having one set of code do one thing and another do something else. Thanks for clarifying for that other person that never responded some 3 months later. Now it makes more sense. I'll take a look at the bug though and get it resolved.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
3Di
Registered User
Posts: 11461
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by 3Di » Tue Aug 01, 2017 12:33 am

DavidIQ wrote:
Mon Jul 31, 2017 9:59 pm
having one set of code do one thing and another do something else.
Just to clarify, the present code needs the user to submit one time for the topic color and submit again for the post. So two times instead of one. In the meantime there is the issue with this bug.

Mine offers the user the chance to select a color for the topic and in meantime continue editing the post as it see it fits, while doing that - and before to submit the topic just one time using the same button at the bottom of the message area - the topic title color can be changed again and again.. the whole topic with the selection/message will be submitted smoothly pressing just the native button, as I said.

Not to mention you are getting rid of Js and unused code, with just one simple HTML5 introduction, full compatible with all browsers having a native automatic fallback.

Anyway, thanks for your attention.
I did it as an exercise to experiment a bit more on this and trying to help here.

Regards. :)
Want to compensate me for my interest? You can.
You can pm me only in case of request for paid job. Thx.
MOD conversions, Extensions and Scripts for phpBB.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16343
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by DavidIQ » Tue Aug 01, 2017 1:02 am

3Di wrote:
Tue Aug 01, 2017 12:33 am
Just to clarify, the present code needs the user to submit one time for the topic color and submit again for the post. So two times instead of one. In the meantime there is the issue with this bug.
Pretty sure to accomplish that it's just a one line code addition in the JavaScript to add the title to a panel of some sort and simultaneously apply the color to the topic title. This is more like a feature request and not a bug at all because right now in the standard posting page, as far as I know, after one enters the text into the subject text box it doesn't automatically show up on the page prior to previewing the post. ;) If you set the topic title color and submit the post the selected color saves just fine without the need to submit again (I just checked). This is why there is a color preview box after selection.
3Di wrote:
Tue Aug 01, 2017 12:33 am
Not to mention you are getting rid of Js and unused code, with just one simple HTML5 introduction, full compatible with all browsers having a native automatic fallback.
Going off of your screenshot I have no idea how you could possibly simultaneously add the text one adds to the topic subject textbox to an HTML section on the page and change its color all without any JavaScript whatsoever. Maybe you should share how this is accomplished so others can benefit from not having to use any JS for doing such updates on page elements based on input entered on say a text box or maybe radio buttons, etc.
3Di wrote:
Tue Aug 01, 2017 12:33 am
I did it as an exercise to experiment a bit more on this and trying to help here.
And I do appreciate it. Thanks for the feedback. 👍
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
3Di
Registered User
Posts: 11461
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by 3Di » Tue Aug 01, 2017 2:42 am

DavidIQ wrote:
Tue Aug 01, 2017 1:02 am
This is more like a feature request and not a bug at all because right now in the standard posting page, as far as I know, after one enters the text into the subject text box it doesn't automatically show up on the page prior to previewing the post.
Just to let you know I am not a fan of this extension nor I will use it for my own scope, I am taking this as an exercise as I said.

I see now the problem here is more concerned about the "preview" then. Let's talk about it.

It doesn't, indeed, show the choosen color in preview while creating the topic.
Instead it does while editing as you can see here http://prntscr.com/g2sdtt
DavidIQ wrote:
Tue Aug 01, 2017 1:02 am
Pretty sure to accomplish that it's just a one line code addition in the JavaScript to add the title to a panel of some sort and simultaneously apply the color to the topic title.
And still keeping Js here.. ;)

That's IMO irrilevant due to the fact the poster would like to watch the content of the message area and finally decide for the final topic title's color, in case. ;)
DavidIQ wrote:
Tue Aug 01, 2017 1:02 am
If you set the topic title color and submit the post the selected color saves just fine without the need to submit again (I just checked). This is why there is a color preview box after selection.
But the noticed bug still remains with the post message area color BBcode.

The color preview selection is real-time here btw ;)
DavidIQ wrote:
Tue Aug 01, 2017 1:02 am
...Maybe you should share...
All what I can do about sharing it is to make a PR against your repo when I feel I did enough test, from that point onward you could decide to use, improve, or whatever .. it. That's not a prob. :)
DavidIQ wrote:
Tue Aug 01, 2017 1:02 am
And I do appreciate it. Thanks for the feedback. 👍
Thanks for your time. :)
Want to compensate me for my interest? You can.
You can pm me only in case of request for paid job. Thx.
MOD conversions, Extensions and Scripts for phpBB.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16343
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by DavidIQ » Tue Aug 01, 2017 12:10 pm

Well I'm pretty interested to see how you accomplished all of this without any JS whatsoever. I'll create a ticket for the preview issue as it is an oversight. Thanks.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
kustajuspin
Registered User
Posts: 46
Joined: Sat Apr 02, 2016 9:49 am
Location: China,Shandong
Name: Weitong 司
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by kustajuspin » Wed Aug 02, 2017 4:00 pm

[*]Chinese translation
Creating a folder named (zh_cmn_hans) or (zh_cmn_hant)

Code:

Code: Select all

<?php
/**
 *
 * titlecolor [Simplified Chinese]
 *
 * @package language
 * @copyright (c) 2017 DavidIQ.com
 * @license http://opensource.org/licenses/gpl-license.php GNU Public License
 *
 */
/**
 * DO NOT CHANGE
 */
if (!defined('IN_PHPBB'))
{
	exit;
}
if (empty($lang) || !is_array($lang))
{
	$lang = array();
}
// DEVELOPERS PLEASE NOTE
//
// All language files should use UTF-8 as their encoding and the files must not contain a BOM.
//
// Placeholders can now contain order information, e.g. instead of
// 'Page %s of %s' you can (and should) write 'Page %1$s of %2$s', this allows
// translators to re-order the output of data while ensuring it remains correct
//
// You do not need this where single placeholders are used, e.g. 'Message %d' is fine
// equally where a string contains only two placeholders which are used to wrap text
// in a url you again do not need to specify an order e.g., 'Click %sHERE%s' is fine
//
$lang = array_merge($lang, array(
	'TITLE_COLOUR'		=> '&#x6587;&#x7AE0;&#x6807;&#x9898;&#x989C;&#x8272;',
	'NO_TITLE_COLOR'		=> '&#x672A;&#x9009;&#x62E9;&#x6587;&#x7AE0;&#x6807;&#x9898;&#x989C;&#x8272;',
));
I Omitted some unnecessarycode here.
traditional Chinese:

Code: Select all

	'TITLE_COLOUR'		=> '&#x6587;&#x7AE0;&#x6A19;&#x984C;&#x984F;&#x8272;',
	'NO_TITLE_COLOR'		=> '&#x672A;&#x9078;&#x64C7;&#x6587;&#x7AE0;&#x6A19;&#x984C;&#x984F;&#x8272;',
));
I am waiting for a permission to be translated.
Thank you ext builder

And have A MAIN STEP:

Open the DW(Adobe Dreamweaver) or microsoft FrontPage.
open that php file,turn to the CODE MODE,copy the whole code into it.
(it is not in Preview mode.)
◣ CNtdf ◥
I'm not living in Japan,please don't regard me as a Japanese. ;)

Miri4ever
Registered User
Posts: 385
Joined: Sat Mar 07, 2015 11:18 am

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by Miri4ever » Sat Aug 05, 2017 11:32 am

How can I change the layout and design of this color picker inside this extension ? I just wanted some few colors to choose just behind the input field and not this big long block under it. It uses a lot of space at the posting Editor.
Homepage: Terra Oceanica

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16343
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by DavidIQ » Sat Aug 05, 2017 11:47 am

It's the one built in to phpBB so you'd be changing it for the other parts of the board that use it.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16343
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by DavidIQ » Sat Aug 05, 2017 11:56 am

Ive created an enhancement task to improve that a bit:
https://github.com/DavidIQ/topictitlecolor/issues/5
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

Miri4ever
Registered User
Posts: 385
Joined: Sat Mar 07, 2015 11:18 am

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by Miri4ever » Wed Aug 09, 2017 3:08 pm

I found another thing happening when this extension is on and the posting editor is started.

This exentsion change just some of my board languages to english. For example I can tell here quicklinks, acp and mcp, create a new topic all those maybe more appear now in english instead of german.
Homepage: Terra Oceanica

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16343
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [3.1][3.2][ALPHA] Topic Title Color

Post by DavidIQ » Wed Aug 09, 2017 3:48 pm

Miri4ever wrote:
Wed Aug 09, 2017 3:08 pm
I found another thing happening when this extension is on and the posting editor is started.

This exentsion change just some of my board languages to english. For example I can tell here quicklinks, acp and mcp, create a new topic all those maybe more appear now in english instead of german.
This extension doesn't do anything to languages and doesn't load globally. How did you come to the conclusion it is doing something to your board's language?
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: dsaf, hewmac06, oBot, zorni and 24 guests