[3.2][RC] Random Banner Scroll

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Suggested Hosts
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
User avatar
Galandas
Registered User
Posts: 732
Joined: Thu Jul 23, 2009 4:11 pm
Location: Italy
Name: Rey
Contact:

[3.2][RC] Random Banner Scroll

Post by Galandas »

Extension Name: Random Banner Scroll
Author: Galandas

Extension Description: This extension allows you to insert Random Banner that flow into a really nice effect. Fully configurable from ACP.

Extension Version: Image

Requirements: Phpbb 3.2* --- php 5.4

Features:
  • ACP: Enable/Disable
  • ACP: you can add new banner
  • ACP: You can change the banner
  • ACP: you can delete the banner
  • ACP: URL Title in tooltip
  • banner at random at every page load
  • Title or description banner in tooltip
  • Administrator Base Permissions
  • Integrated Collapsible Forum Categories
  • Languages: :flag_it: - :flag_gb: - :flag_br:
Screenshots: Click here

Demo: Click here


Extension Download: Click here
Last edited by Galandas on Sun Jun 04, 2017 1:45 pm, edited 10 times in total.
English is not my native language My CDB Contributions My RC extensions
User avatar
RMcGirr83
Former Team Member
Posts: 21696
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [3.2][RC] Random Banner Scroll

Post by RMcGirr83 »

From your acp file

Code: Select all

$submit = (isset($_POST['submit']))
pretty sure will fail validation. Some reason you aren't using the $request class? Happens more than this time in this file.

Code: Select all

$name = utf8_normalize_nfc(request_var('name', ''));
should be

Code: Select all

$name = request_var('name', '', true);

Code: Select all

and isset($edit) and $edit_id != 0 
can simple be

Code: Select all

and !empty($edit_id)

Code: Select all

$action = (isset($_GET['action']) or isset($_POST['action']))
you need to get away from using globals and I am surprised phpBB itself didn't tell you so.

listener file

Code: Select all

        $this->template->assign_block_vars('banner_scroll', array(
        'B_IMG'			=> $row_banner['banner_image'],
        'B_URL'			=> $row_banner['banner_url'],
        ));
not following coding guidelines concerning tabbing.

migrations

Code: Select all

					"banner_url"		=> "http://phpbb3world.altervista.org/community/viewtopic.php?f=68&t=2299#p3582",
					"banner_image"		=> generate_board_url() . '/ext/galandas/bannerscroll/styles/all/theme/images/banner/advanced_login.png',
Why are you hotlinking to your forum?

This extension seems to be a linking extension to your forum.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
Galandas
Registered User
Posts: 732
Joined: Thu Jul 23, 2009 4:11 pm
Location: Italy
Name: Rey
Contact:

Re: [3.2][RC] Random Banner Scroll

Post by Galandas »

Thanks for the tips, I'm not that familiar with phpBB 3.2 definitely adjust everything.
yet not submitted for validation, there are still many things to adjust, as you well to be noticed and reported.

Links are just examples of the pre-set, users can delete quietly and customize, this extension has been created for this.
English is not my native language My CDB Contributions My RC extensions
User avatar
Galandas
Registered User
Posts: 732
Joined: Thu Jul 23, 2009 4:11 pm
Location: Italy
Name: Rey
Contact:

Re: [3.2][RC] Random Banner Scroll

Post by Galandas »

Updated version 1.0.1
enhancements to the code, and made compatible with the extension Advanced Active Topics to prevent them from going in conflict, because they use the same js script.
English is not my native language My CDB Contributions My RC extensions
User avatar
zardos
Registered User
Posts: 129
Joined: Mon Feb 29, 2016 12:23 pm
Location: England, uk

Re: [3.2][RC] Random Banner Scroll

Post by zardos »

Nice work, i love it, thankyou. ;)
User avatar
Galandas
Registered User
Posts: 732
Joined: Thu Jul 23, 2009 4:11 pm
Location: Italy
Name: Rey
Contact:

Re: [3.2][RC] Random Banner Scroll

Post by Galandas »

thankyou
Updated version 1.0.2, more enhancements to the code.
English is not my native language My CDB Contributions My RC extensions
User avatar
null2
Registered User
Posts: 510
Joined: Wed Jan 20, 2010 11:03 am

Re: [3.2][RC] Random Banner Scroll

Post by null2 »

Translation to Portuguese-Brazil: https://www.sendspace.com/file/pk0q4h

============

Suggestion: Change default value to "banner_scroll_enable" to 0, to avoid activate this extension after install it and before to define banners. Just change that in galandas\bannerscroll\migrations\release_1_0_0.php, line #51:

array('config.add', array('banner_scroll_enable', 0)),
Sorry for my bad english. I'm from USA.
User avatar
Galandas
Registered User
Posts: 732
Joined: Thu Jul 23, 2009 4:11 pm
Location: Italy
Name: Rey
Contact:

Re: [3.2][RC] Random Banner Scroll

Post by Galandas »

Thanks for the translation, I add it in the next version.
Good tips, thanks.
English is not my native language My CDB Contributions My RC extensions
User avatar
Galandas
Registered User
Posts: 732
Joined: Thu Jul 23, 2009 4:11 pm
Location: Italy
Name: Rey
Contact:

Re: [3.2][RC] Random Banner Scroll

Post by Galandas »

Updated version 1.0.3, Added Administrator Permissions, And Brazilian Portuguese Language Thanks to null2.
English is not my native language My CDB Contributions My RC extensions
User avatar
Galandas
Registered User
Posts: 732
Joined: Thu Jul 23, 2009 4:11 pm
Location: Italy
Name: Rey
Contact:

Re: [3.2][RC] Random Banner Scroll

Post by Galandas »

Updated version 1.0.4, Added Collapsible Forum Categories.
English is not my native language My CDB Contributions My RC extensions
Fribster
Registered User
Posts: 7
Joined: Tue Feb 20, 2018 11:27 pm
Location: Worldwide
Contact:

Re: [3.2][RC] Random Banner Scroll

Post by Fribster »

Awesome Extension and by far the best advertising extension imo..
Ran this random banner 0n 3.0, pretty sure it worked correctly then, running again no on 3.2, but the banner images do not resize for mobile view ?
Even using your standard banners they do not resize correctly on mobile.
The container itself resizes perfectly but not the banner images.
Can you assist with code edits please ?
my board https://f-ribsandsibs.com/forum/
https://f-ribsandsibs.com/forum
Premier Inflatable Boat Forum for Ribs|Sibs|F-Ribs|Kayaks
Fun, Free & Friendly Boating Community.
User avatar
ac_roma
Registered User
Posts: 318
Joined: Thu Mar 08, 2007 2:48 pm
Location: egypt,alexandria
Contact:

Re: [3.2][RC] Random Banner Scroll

Post by ac_roma »

useful mod and good work

thank you ;)
Post Reply

Return to “Extensions in Development”