[3.2][RC] Thanks for posts (and optional Tapatalk integration)

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
User avatar
nhseacoast
Registered User
Posts: 482
Joined: Sun Sep 22, 2002 10:31 pm
Location: NH, USA
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by nhseacoast » Tue Nov 21, 2017 11:56 pm

Does this version use an AJAX refresh when a post is thanked or is it the same page refresh/redirect?

User avatar
Naguissa
Registered User
Posts: 224
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Wed Nov 22, 2017 5:39 am

nhseacoast wrote:
Tue Nov 21, 2017 11:56 pm
Does this version use an AJAX refresh when a post is thanked or is it the same page refresh/redirect?
It uses page load. Even more when messages are active.

Active: Confirmation (only remove) -> message -> return

Inactive: Confirmation (only remove) -> reload with changes (thankslist and button).

User avatar
nhseacoast
Registered User
Posts: 482
Joined: Sun Sep 22, 2002 10:31 pm
Location: NH, USA
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by nhseacoast » Wed Nov 22, 2017 8:37 am

Just to be clear. The whole page refreshes? Or just the Thank info?

User avatar
Naguissa
Registered User
Posts: 224
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Wed Nov 22, 2017 7:02 pm

nhseacoast wrote:
Wed Nov 22, 2017 8:37 am
Just to be clear. The whole page refreshes? Or just the Thank info?
Whole page.

User avatar
Naguissa
Registered User
Posts: 224
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Wed Dec 13, 2017 8:22 am

New version of tweaked tapatalk "mobiquo" folder to support Thanks in the app available (new plug-in version catch-up): https://github.com/Naguissa/mobiquo_tha ... ses/latest

yasirktk
Registered User
Posts: 1
Joined: Thu Dec 14, 2017 6:30 pm
Name: yasir khan
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by yasirktk » Thu Dec 14, 2017 6:39 pm

oes this version use an AJAX refresh when a post is thanked or is it the same page refresh/redirect?

User avatar
Naguissa
Registered User
Posts: 224
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Fri Dec 15, 2017 7:03 pm

yasirktk wrote:
Thu Dec 14, 2017 6:39 pm
oes this version use an AJAX refresh when a post is thanked or is it the same page refresh/redirect?
Still no AJAX. The update is for the tapatalk modifications, not for the extension.

darkobgd
Registered User
Posts: 14
Joined: Thu Oct 22, 2015 10:03 am

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by darkobgd » Fri Jan 12, 2018 5:51 pm

Hmmm, my notifications are not working again :(

After noticing that problem i deleted whole TT, uploaded mobiquo and ext folder, then replaced original mobiquo with your modified one. No notifications.

2.0.6 version.

User avatar
Naguissa
Registered User
Posts: 224
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sat Jan 13, 2018 7:29 am

darkobgd wrote:
Fri Jan 12, 2018 5:51 pm
Hmmm, my notifications are not working again :(

After noticing that problem i deleted whole TT, uploaded mobiquo and ext folder, then replaced original mobiquo with your modified one. No notifications.

2.0.6 version.
I've just tested (on web and Tapatalk) and no problem with that.

Are you on latest versions on both? Currently:

Extension: v.3.0.7-r1 - https://github.com/Naguissa/thanks_for_posts/releases
Mobiquo folder: v.2.0.6-r1 - https://github.com/Naguissa/mobiquo_thanks/releases



In the other side, I've recieved a "reject" response to officially realease v.3.0.7-r1 as official extension. There's a really in-deep report telling all failures, wich is really usefull to fix it. One example: " Line 193: please remove commented code. Same on line 245, 337, 418, 465, 466, 469."

As I said, really in-deep and really useful report. And they ask for a really clean code, that may slow down everything a little but assures a really great quality on extensions.

There's no severe warnings, so I'll fix ASAP.

User avatar
Naguissa
Registered User
Posts: 224
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sat Jan 13, 2018 3:49 pm

New 3.1.1 version released: https://github.com/Naguissa/thanks_for_posts/releases

It has some code changes to adapt to phpbb validation.

jackennils
Registered User
Posts: 155
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by jackennils » Sat Jan 13, 2018 5:43 pm

Hey there!

Just updated from 3.0.6 to the latest 3.1.1. However, when I click on a thumb to thank for a post, I only get a reload of the page. Worked fine before I did the update. Please help!

You can try here: https://mafia-daily.net/forum/viewtopic.php?f=3&t=2523

Just try to thank for the post via the thumb icon:
Image

Also, when I try to remove the plugin in order to do a clean re-install I get this:

Image

User avatar
Naguissa
Registered User
Posts: 224
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sat Jan 13, 2018 9:38 pm

Actions: Fixed, there was an error when adapting to phpbb coding guidelines. I was looking for a more complicated fix on page rendering and overlooke this simple thing.

Uninstall: It appears to be an error that was on 3.1.0, and that's why 3.1.1 appeared several minutes later.

I've created a new release, 3.1.2, that must fix all of this.

jackennils
Registered User
Posts: 155
Joined: Mon Jun 01, 2009 7:48 pm

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by jackennils » Sun Jan 14, 2018 1:28 am

Now Thanks are back and working, but suddenly ratings are enabled and I'm not able to disable them. Saving any settings has no effect. :shock:

And trying to completely remove the extension still outputs the SQL error from above.

darkobgd
Registered User
Posts: 14
Joined: Thu Oct 22, 2015 10:03 am

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by darkobgd » Sun Jan 14, 2018 10:40 am

Naguissa wrote:
Sat Jan 13, 2018 7:29 am
I've just tested (on web and Tapatalk) and no problem with that.

Are you on latest versions on both? Currently:
Extension was not up to date, now it is(3.1.2) and everything is ok, thank you :)

User avatar
Naguissa
Registered User
Posts: 224
Joined: Thu Mar 02, 2017 6:55 am
Location: Barcelona
Name: Naguissa
Contact:

Re: [3.2][RC] Thanks for posts (and optional Tapatalk integration)

Post by Naguissa » Sun Jan 14, 2018 2:36 pm

New realease, I hope it solves all bugs added when trying to addopt phpbb coding guidelines.

1) Fixed an out-of-order migration that gives a DB error when deinstalling. It was happening to me, using MariaDB, but it was not correct as it was.

2) Fixed administration parameter processing; it was skipping arrays when retrieving parameters.


P.S.: I'm used to Zend Framework and some time have problems with Symphony's way of do things. Methods are more or less the same but behaviour are sometimes completely different.

Post Reply

Return to “Extensions in Development”

Who is online

Users browsing this forum: andreask, david63, fagbutlil, GanstaZ and 25 guests